From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0066.outbound.protection.outlook.com [104.47.38.66]) by dpdk.org (Postfix) with ESMTP id C598B5597 for ; Mon, 10 Oct 2016 07:10:11 +0200 (CEST) Received: from BY2PR03CA068.namprd03.prod.outlook.com (10.141.249.41) by CY4PR03MB2439.namprd03.prod.outlook.com (10.168.163.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Mon, 10 Oct 2016 05:10:10 +0000 Received: from BY2FFO11FD046.protection.gbl (2a01:111:f400:7c0c::105) by BY2PR03CA068.outlook.office365.com (2a01:111:e400:2c5d::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11 via Frontend Transport; Mon, 10 Oct 2016 05:10:10 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD046.mail.protection.outlook.com (10.1.15.170) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Mon, 10 Oct 2016 05:10:09 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9A5A6A5030502; Sun, 9 Oct 2016 22:10:07 -0700 To: Thomas Monjalon References: <1475949668-26829-1-git-send-email-shreyansh.jain@nxp.com> <184506162.Hjg7Xy8FWv@xps13> <4525292.xovB97rfbE@xps13> CC: "david.marchand@6wind.com" , , "nhorman@tuxdriver.com" From: Shreyansh Jain Message-ID: Date: Mon, 10 Oct 2016 10:41:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4525292.xovB97rfbE@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131205498102169166; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(377424004)(377454003)(24454002)(199003)(189002)(86362001)(586003)(65956001)(31686004)(31696002)(92566002)(33646002)(65806001)(93886004)(104016004)(626004)(110136003)(23746002)(77096005)(54356999)(11100500001)(76176999)(5660300001)(230700001)(47776003)(65826007)(50986999)(106466001)(105606002)(50466002)(6666003)(6916009)(83506001)(2906002)(19580395003)(81166006)(8676002)(68736007)(81156014)(64126003)(7846002)(19580405001)(8936002)(87936001)(4001350100001)(189998001)(97736004)(4326007)(305945005)(36756003)(85426001)(2950100002)(356003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2439; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD046; 1:TRS95HJqFK6God9wJSXBqqsWtFOW7tfFc0Z9VlK4fxS4652dS+GQKtKSs7a999c/jLg/6oT77enmPl/JDCzDM4hUAJyx+fmlohE2mOWnI6S1uRsRaxtVRSfrsaTJ84JxGZuhirE3whySqdoiXFZoqG66ZQ81BB7eVWvM/MxNmbJHuMd7DLGEoez7D2OBcetwscoNVkyhqn8HymrSH7k1YtDztzse3ozmuib/9QfJ76SzJXXZfKUw2RUE6AukLmi3oQi5foyl8SXgHONMYXbsEZ7ZexviHooBxsp/6En1XccL00h8B/6u+3DuDLUJKovtoMsdqh0LmFMhfuFGLhE8C0tUO2KGkYrsk1ckrcki5IT2Q59XuX+g0on2Yk7ffm3FURXy7f3PX2/as3Ov/SPrBbsMQnl+cLVjKtrrcNlR6sIT0kIAmNSgNUZD6iY+muwabP3KZguK8gEVn/GTPiT7K1GALvAedzWVQg59tZBxNZmaweNzzVXO9iDc5NtwqepraXDIQ2OOpwOXrBS5xoHycp812gS/i98LCjHHvNL9+HT0SN/7UHOaJNIVSsNgoIR8OpznG78DYELV7Om0teDtEg== X-MS-Office365-Filtering-Correlation-Id: 552975c8-9154-4356-3e4e-08d3f0cbb56c X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2439; 2:5vik5N7vEWYW9fdFgTSV2EosPvXVCG5hQBz3OEKVk0iq2S5Q0WuYhlfk9rjMvZjwalnbI/d3bGNWXKhtxHT4zvWtbo6iJTJ48yO9kKYWZMQvsMhzN3NSck8PDrwzRKZipoIMFcNUUtH4WYYJDByOQx63e7TkCjOuxcMgK1Uvb/qbufGv4FqrOrtT3NNfWf4eIjSvoyYLio2RwzSSDC5N0Q==; 3:2fF+24xaraCn2U031yCsOBJxaSN3ni/rhOKMln4UehOuwrxlW2NnD1VIcKa4NOhHSNvQk8vzcU4ImrZFTGVOUPWNqyF+CZtYV9Wv9mcO/GAmrhLpMEzlIK1G5rjccHaHMEdugAEbKfS3ek7cU7IIyHAke/S8Q1zNF1q5iDHSdFIJszzxtkqivq24ESBRI4+McNt+SD+3tPm+PeN5gZP8pF0+tnYY2h3Z/d6usMpXRivYQHZaS2I+W+hCq8ss+VwZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2439; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2439; 25:vR9RhVCM9h4mF1BHtTKHKh3T65rMSW7ZUgIETQFZlwu/c3/fXMpnYvpNGQvVaRadds2O/ZINj6cbnmZ/2eSRy3Pj6C+b8QoNQY3+LPs2yL2vO8qS/Yd+fwBIdPojzU3WvkmD228GtCML/ALdv75Ah0BVIDzsIFZuyvNPfwXJ3Kr8VkG8vnK/cAJRqYUvsezWtJt5LQUWUNtXgpplQQKdhUHtMWx8l1JT294WOt4flu2BVJIj/GL/H4rO2rQD6KgjAtqhfOTSj5W23Q5rzvA4VxhfRFp5G0R8HLsbQc3TXYApsUOWAzUkJPuuyqPm6IxjqF3U70fKjII75lq32dB1d8pxPpTv6wrl7M2R2L40RF7Uyb22bBG/kRWJZedSZjgJGQucjV/ok0cxuVI2yEqr0Jo3lTET1BO8rMr0E7JLx7U29a95izNxj9K9RcsSd3uSnMLkVaLbGh9v8cJ3U/VBl69HBEgfep4Uk6la6ClsDE0dB6R/dh2pPst2wsydv9kyUm8U83S4m82Xcc5h0aekFLcSq03hkhW1x445lTEpx9IhoCJQHQNNC/T+UqlRRoBaV156p81eA60wgDDOyt5bgx+QnzuK7TuupV3pl6QkwZoQrby+UdEnzXlv6eIJNrDO4wgqL1GZ6qQy3KozqSIEaXG71EQ8ChfZ+STJvc8qb0tcIGkncCjl8OnH7aD9CArFkak01CN20tfdmty21dvst1BOzEVyA8lz8DkMaH9bkc2QZ4Km41hYpln69qzHk8nmtjpLDYYfbQ8MecSILtjsXg== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2439; 31:ODaE+SJ+C8RZK33/20y6cHsWGthJOBHy2GmJpObdg6jS8pXxZvJinlvGdFV+kNGS7LBGDXlalCHeAdLuevH5rdpyIYTrCIoJ05hqP6lrnW9G+4e49Br2UJb1cYoDKZ8MkU19HDGH+EwE/6rV+wQaGq4YNZhFW9MEVCLY78da//W10abH3gQJaogUvaMmVwt7YR6nMLnYRLk7NcbIPdO2tfvAvsmAuEr4YGqaRmXneQZqFHUxSsrEnPDPXPkIuQfa; 4:aw+KZL2AsdLhwgQiy987hsiQvxvSDUh/hv5iqxLpkhFEPLizOrqteX8LpN9GvYrJygEd2zel79iSbAIatNecsjSrP/hUEFO8iIc0sIXHzIitPWnXWdZ6o68az/f4os0Wck2bGFRU4BMUivo/Rt/xNBzO8/JPXFeS+QQVlcp69jIAeXAbxR8HZQ9XmxUHpImTv4YJ9YhSzvhgjkYKER14Nxd4j7umB6qjL586SgEYhkUC3BpnD83xQSi+qilb84RnYZoAN/0zylcCXGw1DL+tyrNFQtfNmseu9BJxh7SEvwloSRZ/eqV+YzdZbLFS7UClcVuRIuzXJlEKX2vlUgREF6/WLcDR1c+065v7YGFalk2tPHE1LIApTckiJ6Hxow6c/Jw8mBtNIRvOl8rbCvjOEYsodvaIzWKAN1czYQkISRAuTsDh5LvW8GdkjZ6iweZnyqo5Ifbcwf4iZNmS0VIz5kzGl4d3zKzYub59uuMOq4nnFl2+MUY6JFrc3xMfUmcfP7w8ezw1BN6x0knayhWQyw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13018025)(5005006)(13023025)(8121501046)(13017025)(13015025)(13024025)(10201501046)(3002001)(6055026); SRVR:CY4PR03MB2439; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2439; X-Forefront-PRVS: 0091C8F1EB X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2439; 23:1tJ4qhZwm+mqXPHiLU/f5q+xomLH/34JLqFw+?= =?Windows-1252?Q?JkQCv1TUgnU8VYakUm592uGjU+uGrXwiBfso0vUMMCWE7CNjPMDZhUBs?= =?Windows-1252?Q?WYHdPc0WX8c0Knri60NAWJdn+/ghu5jmNINEBZBR5bhQ0DaJg/JJBDtD?= =?Windows-1252?Q?XQ1eegq10xZCoaW9w+bJA28W5s/nxWWXozOWxJgjPT73gbaM5FAM268N?= =?Windows-1252?Q?oFdnNOhPUjmGapjh8D9gneeDOyLtiv+PvIcsdKNZBsnfmj3fbmm1egEQ?= =?Windows-1252?Q?5gRWjGAQHLbpQdLrZA7iidHgCwGLRAwzR7255dkDt0/hb71ktPVB1xdy?= =?Windows-1252?Q?eOHVl0U4kUYDLoPnfR6G8se9q9S9Pp6b7I+9FgccsukCKtsCfaA/havx?= =?Windows-1252?Q?bs0qhJtew8hRueLIA1mSJ8evwVvPR+odOmocmNEP9atKEZuh+EwwElIs?= =?Windows-1252?Q?VzJkf8qLuVGKJ1sn2uFiO1qTRrbDPSLD6cdEcxkIOQmfGg3j7PgnHa7e?= =?Windows-1252?Q?9CFaTk53ZlhztwC5Qlqj1etanAn9LiPiy/Jiboo+Swn/YLLS/37ZZXIv?= =?Windows-1252?Q?OX0ST3nT+wzaDyqXsRM5qWiLbBmCpP1Tnn2C/V5HS1PwzLeokr+FXT20?= =?Windows-1252?Q?kS/8KSTYEsqs/0ge53z9o7SczNDt5ofW8z9UNGrXJsTs07RMe2wVa29q?= =?Windows-1252?Q?MG9cKMAWXwHtakK+OvLxyR+aPWyuxsz4QyRG35SdvEkHLLNbo46V9QYL?= =?Windows-1252?Q?U80JpQj10fMr2z0CegM986q7tH0//lbs4WyO0MG+PkB7xmHhtwx1mAmR?= =?Windows-1252?Q?Gmw0DoTQNafpawWc70DtiPvIwjh8q6s9bdEMOs/+Pe0JSDMk3Gfvxw9S?= =?Windows-1252?Q?koB/QMYCEzksYFawMHdt8B95WdNkkdemKjhULjC7Sgb8Xin8BXlugzd2?= =?Windows-1252?Q?RY8tGfz0Jqs4CGuNsmSWfUp8ItmUDPQjMBH0KKVXMZ8QFw1hjKlOlUXK?= =?Windows-1252?Q?IVGfa6dc2x164FzpjJBmAJY4OT/sUfCZpWIFJx+MDmsEkVQDJUM4CyIz?= =?Windows-1252?Q?BOWWj2Jn7LMWEMTFeZU1EJb5XbCb84EHKyutOvlPXG2XStElkBpnyWHM?= =?Windows-1252?Q?AC9WDhrcTPPVQPxeKzR9JHMrnn9OuCWiQFQaT6nC+J/lTX4yCIJLsiUj?= =?Windows-1252?Q?hhUK5rT4ojQNv8bt23yq26YGEVI2Ad56yRWSI8EJFmcCnNOAUFy7Cx/L?= =?Windows-1252?Q?EIg42WZAKm1qdDZCJZUq9SaoUynkcZINrQN5Byowm0hCwA6DFsNXiVat?= =?Windows-1252?Q?o9UQjlh7ucq/I/9uzO3dW6neWCiCpi0kkPYLFXj8whaPsLXeT9Gaky++?= =?Windows-1252?Q?fJga0yjiHsRLd0teJtoaHjeJDrAV8nosOxrVopXT0N0Vj+Kmh9qs9elP?= =?Windows-1252?Q?k/i6cIDz3yzW1xsMcOt32ABtJf6KsoTcW2OvMY5yGyAp4dufFK57LCuM?= =?Windows-1252?Q?TqxVNSOZKxG2VcA3ZVnZT974S0gJG/KxKAKib+x6kCpKGiyIdWf8mBLI?= =?Windows-1252?Q?tvgWdVlkCg5tuCTMFh8YyWhfz/g+G51XJ0yutGKu20MguNlyq5tJoCQm?= =?Windows-1252?Q?/obiyGRodXPyOhxSvuf5b8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2439; 6:VHogN6XmVWnJPwjBrW3zAfTft3lgi5KYKli1QMs/MmJxVwSqGHbME75CDtKt0/QOGzG2AptmP7FfsdzuqrJEb6JkrbnyZSjrjy7k3RIllVD6d9Sf6GGeKecCVUdLdK74DS4ReO1HuW1QkiS2ott1zEgf32sdsvSY5X+ZxEHWdyiWZdj3Jv5PdsyWo6qmnO1LmuF9eQX/3QndqsMK0RiMAmaF1CoVGQp9rB3CamJNwqX3HNpwMehkBMlqBAnqSMloN7drLgunuKTOhXOhSod+A5irNgyGUd01PghuosXlM72Teys5VmEEcJIX4VRLkE5n; 5:AEuEttgy7kbMO3NeQS3ytT6yk3684HBuADG0AZJtHLRh79KpBjJMf5l+di5ItL1RWfNS5rGsaVIQAvC4BI+hWKYkST3ikrNe+2iTU+KLk3XAEWcfIhgBl2t5Ecoq4o4d8YPHWmjhDf7Y53DhDbXaiT9F94VmOnMGyHoG6Kge2yADJJb+J72f2pjJH0tNO89N; 24:tNnjjnRiLIKrby0QsMIUWu8k/EmNd31QHkUiTL2ilkQIHwFT62kByryWE+iXvWbmFWa7C7BbRaZYu2ISJ+y0N0aqzHfbLKuAz7sacvDGu4s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2439; 7:IeodgG3VjJWwCFv0lWay0/ag3vPQ1vR2aAyg6MUk7LOF5rBVIaKFEOcJNjy2bemGVi4uPf/LvSFJJ90PU+RGdlquvhlcD/UhczE6xIZhJXPGoXXqM6HC0xV8/0HowiQPN0rz3QdS5uTEkkGcOYs99v24Moo1m5xHhkEKe/Mdp4rX+XqV6M9ps5xszoJOHZjJRZHRXXIxZAjShCmtBaCHYoVn2fYiH9Vc+AtNR0RaGH6bm3Dwi6a/Yq1K1PcWhMx11hkthAqNmjJuXL+KY9hIGtn226vqW0qdkJ4QCp7MzeeEUob+Yvk/B/NrxWmI4PsSGy5cGK69XiKseqg+zta06IRwrZrNrymejiUSvv47bcA= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2016 05:10:09.7645 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2439 Subject: Re: [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 05:10:12 -0000 On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote: > 2016-10-09 15:12, Shreyansh Jain: >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >>> 2016-10-08 23:35, Shreyansh Jain: >>>> +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\. >>> ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\ >>>> + then \ >>> >>> I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ? >> >> Because I want to make sure that the grep matches only the DRIVER registration functions. >> In case a new macro (or driver type) is added in future, this macro can be updated. This way we can reduce the probability of a faulty match. >> >> Is there a problem with closest possible match? > > It is just long and useless. A macro starting with RTE_PMD_REGISTER_ must > be called from a PMD. What else? Long, yes. But I don't know why you state it as useless. Reducing probability of a false positive is what it does. Anyways, I will send a v3 with "grep -Eq 'DRIVER_REGISTER_.*\(.*\)'". - Shreyansh