From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64E17A0546; Fri, 30 Apr 2021 10:34:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 466CD4014F; Fri, 30 Apr 2021 10:34:46 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 562994013F for ; Fri, 30 Apr 2021 10:34:44 +0200 (CEST) IronPort-SDR: M3j3K1uY7c+4u9ARhxwNdKpoI8akClhzTnSvWeWAQTwqHc4AGPe2OjFcdDPqjzAfOuLFJsW9CS vunhWed+c+CQ== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="177383500" X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="177383500" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 01:34:43 -0700 IronPort-SDR: t276b22wDMhzq+YiQqj1g09x+AyStTbzSt1gg88Aj1mqJuQGKWA7oYQTVBxXisP6QGbshJlbGa HqHUNq1ZPmnw== X-IronPort-AV: E=Sophos;i="5.82,262,1613462400"; d="scan'208";a="404519051" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.242.68]) ([10.213.242.68]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 01:34:40 -0700 To: Viacheslav Ovsiienko , dev@dpdk.org, Andrew Rybchenko Cc: rasland@nvidia.com, matan@nvidia.com, Michael Baum , Thomas Monjalon References: <20210426124250.42771-1-michaelba@nvidia.com> <20210429095542.7800-1-viacheslavo@nvidia.com> <20210429095542.7800-2-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 30 Apr 2021 09:34:37 +0100 MIME-Version: 1.0 In-Reply-To: <20210429095542.7800-2-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/mlx5: support flow count action handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 10:55 AM, Viacheslav Ovsiienko wrote: > From: Michael Baum > > Existing API supports counter action to count traffic of a single flow. > The user can share the count action among different flows using the > shared flag and the same counter ID in the count action configuration. > > Recent patch [1] introduced the indirect action API. > Using this API, an action can be created as indirect, unattached to any > flow rule. > Multiple flows can then be created using the same indirect action. > The new API also supports query operation of an indirect action. > > The new API is more efficient because the driver gets it's own handler > for the count action instead of managing a mapping between the user ID > to the driver handle. > > Support create, query and destroy indirect action operations for flow > count action. > > Application will use the indirect action query operation to query this > count action. > > In the meantime the old sharing mechanism (with the sharing flag) > continues to be supported, and the user can choose the way he wants to > share the counter. > The new indirect action API is only supported in DevX, so sharing > counter action in Verbs can only be done through the old mechanism. > There is already a deprecation note to remove the 'shared' flag from counter action [2] in favor of 'shared actions'. Shared action become "indirect actions" [3] which this patch implements Is it a good time to remove the old sharing mechanism from driver since touching on it? [2] https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v21.05-rc1#n95 [3] https://git.dpdk.org/dpdk/commit/?h=v21.05-rc1&id=4b61b8774be9 > [1] https://mails.dpdk.org/archives/dev/2020-July/174110.html > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad <...>