From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08F85A0525; Thu, 20 Feb 2020 23:14:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D297358C4; Thu, 20 Feb 2020 23:14:57 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 12CBA34F3 for ; Thu, 20 Feb 2020 23:14:56 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id n10so6413378wrm.1 for ; Thu, 20 Feb 2020 14:14:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=HVYwAPMTgHw9293b+cabueeiFG+I/qwiFN24SVyQeAg=; b=ruVRet1xzy8x8eycCchhTlVvWp4KNBIf/wCeTNX7TEUDe80mGCRdyGf9Jl/KBenf3e VzD/wj0E3UKys2FAMDi8cJum/Atb92sP2686TzhknyoACxsx5veeTxZ0sbYBDb1chKvR 79J0hrT0fR/cULrrjhfiAEYRLJxIsBcpGZwU3VEfmgFjcRCZ68EMkTrScLWnVoMCJ47V OFmIBqxBiwY2a8VtfakZRcj75+CfaMtO/6ffddLQBpSlPFrwAemqxLPIbRla7LwSf+KK ePQKFYUzpTDv5iN2PObzQlbCxrojulx/3vjSAML0iDQTXGlV3hfmUCWiA3Q2Dc3t0SmA ypWQ== X-Gm-Message-State: APjAAAXQtQjlzze8vK+FxGdHILl9b//o/BvYmu/HteoJcN2yWGPfEobZ rtL9UOKRpIn5PF4BOqCmHaw= X-Google-Smtp-Source: APXvYqzcje2wBokMjQMf5Q3Gqz+R4knJq+yQRMfc/qj0fmrfvUIxjmNP3TQfhmuvqpcKjfTujkWJBA== X-Received: by 2002:adf:f7c6:: with SMTP id a6mr46529362wrq.164.1582236895663; Thu, 20 Feb 2020 14:14:55 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z1sm872223wmf.42.2020.02.20.14.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:14:55 -0800 (PST) Message-ID: From: Luca Boccassi To: Ferruh Yigit , Thomas Monjalon , Neil Horman , Bruce Richardson Cc: dev@dpdk.org, ray.kinsella@intel.com, david.marchand@redhat.com, ktraynor@redhat.com Date: Thu, 20 Feb 2020 22:14:54 +0000 In-Reply-To: <20200220195454.2363094-1-ferruh.yigit@intel.com> References: <20200220195454.2363094-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: fix experimental library versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-02-20 at 19:54 +0000, Ferruh Yigit wrote: > The problem occurred when workaround that makes soname two digits > applied. With this change for the ABI version "20.0.1" the > experimental > library version become ".so.2001". > After workaround removed in ABI version 21.0, the experimental > library > version will become ".so.210". > "2001" is bigger value than "201" although it is a previous version > of > the library version, this can break the version comparisons. >=20 > To fix this, introducing a temporary sub level versioning for the > experimental libraries, so that minor version comparison will > continue > to work. >=20 > After change experimental libraries will follow below versioning: >=20 > DPDK version ABI version soname library name > ------------ ----------- ------ ------------ > DPDK 19.11 20.0 .so.0.200 .so.0.200 > DPDK 20.02 20.0.1 .so.0.200.1 .so.0.200.1 > DPDK 20.05 20.0.2 .so.0.200.2 .so.0.200.2 > DPDK 20.11 21.0 .so.0.210 .so.0.210 > DPDK 21.02 21.1 .so.0.211 .so.0.211 >=20 > Note: After workaround removed in DPDK 20.11 and soname switch back > to > single digit this patch won't work and needs to be updated. >=20 > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 > compatibility") >=20 > Signed-off-by: Ferruh Yigit < > ferruh.yigit@intel.com Acked-by: Luca Boccassi This solution looks like a good compromise to me. Thanks Ferruh. --=20 Kind regards, Luca Boccassi