From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 633EC1B6E6; Tue, 6 Feb 2018 15:18:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 06:18:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,468,1511856000"; d="scan'208";a="25255990" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 06 Feb 2018 06:18:51 -0800 To: "Mcnamara, John" , "Zhao1, Wei" , "dev@dpdk.org" Cc: "stable@dpdk.org" , "orika@mellanox.com" References: <20180130074431.116094-1-wei.zhao1@intel.com> <20180131021227.129117-1-wei.zhao1@intel.com> <37e0c4ff-3370-27d7-fe03-6889b5f4c35c@intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Feb 2018 14:18:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 14:18:55 -0000 On 2/5/2018 3:31 PM, Mcnamara, John wrote: > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, January 31, 2018 5:24 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Mcnamara, John ; stable@dpdk.org; >> orika@mellanox.com >> Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document >> >> On 1/31/2018 2:12 AM, Wei Zhao wrote: >>> This patch will update example application of flow_filtering document. >>> It add Tx queues configuration related comment. >>> >>> Signed-off-by: Wei Zhao >>> Reviewed-by: Ori Kam >> >> Hi Wei, >> >> This patch is causing documentation warning: >> ...dpdk/doc/guides/sample_app_ug/flow_filtering.rst:161: WARNING: Could >> not lex literal_block as "c". Highlighting skipped. > > Hi, > > The reason for the warning was due to 2 instances like the following: > > + rte_exit(EXIT_FAILURE, > + ":: Rx queue setup failed: err=%d, > + port=%u\n", > + ret, port_id); > > > Here the error string extends over 2 lines so the error message will print out a newline and a lot of whitespace in the middle of the string. It should probably > be something like the following: > > + rte_exit(EXIT_FAILURE, > + ":: Rx queue setup failed: err=%d, " > + "port=%u\n", > + ret, port_id); > > or just: > > + rte_exit(EXIT_FAILURE, > + ":: Rx queue setup failed: err=%d, port=%u\n", > + ret, port_id); Thanks for clarifying this John. Patch pulled from next-net-intel to next-net and suggested fix applied on next-net.