From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFC0BA0032; Fri, 18 Feb 2022 18:05:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96F814014E; Fri, 18 Feb 2022 18:05:26 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3018D40141 for ; Fri, 18 Feb 2022 18:05:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645203925; x=1676739925; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=qKuvbXPZh8NE2oG2pM+vwmwOmJafzeBqAZ/6FntlpeA=; b=jgkax7z48Z1M3BiAg3bkKRRGQTa4CV+80rnURXcNV4u71PLMgxs9+ISp dINcCJMJEsY3u6g/fJOOWomZZa5ZxFCQ/GZ5X5pFD06u7O0u5PXHOfp8C YsUi7RvvwjJNqhoas/PSm04bwUVirpdk4xYRCT2mddPaR3n3dwE0R9RI8 F9c0a1PvOWrzVzpdRbBMHnGycXoC4EjRwQxJ+uNFVGuz6/c1PN88ijCnq OZ2POEaILw0Qq6C5+rVSTQwbzPsn2sSGsCr4BUIAA51tTYqYtXBTVVJtr VeTkn86ciSo1LeW/Ecz/aTZvKxlt76Alx+VY2fYmvbhIrwB5iNMaA6Fp0 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="234698770" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="234698770" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 09:04:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="541957398" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 18 Feb 2022 09:04:45 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 09:04:45 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 09:04:45 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 09:04:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZF3x12804XY2qbPw0/7OW/8BR6jFgownOTDh5Z9nD/SUHUYG8dQE8QCDeYknguXyD7PiTeN6IlcvmwB54cr8h3UGoEVIcHDA1TnRkZYEyu4xhOvu7Ep1eJu5YX/YD6Q615Ep+SbzGzMtm3hhRIOaHBFqRN4bKhRCTlH5jEbNJQxMrgunX2GKb4hkOuQomGmyUL0zFBI0I5OfLxdSNo5s7hO9iC/vH+xUSueCaFenb2vYcyridrOwhqwUsioO94JUtmhJIYQDjkTqTNLAnoLPdZVTMDuBLg8C72yJ/c/tTcbgo8Q6lfMlXcEt+EncfnR2o5pBJF50olCpvlVd7fGShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=foXOOdUynA+CXUDbWcU9xQSrvx5SIu5rjmEzLrQcsmY=; b=FGLyp2kJgd6k9FoflxqOYeqT4AYuwAPfpiVaF0xymbOtgy3GnieiGH9zzGwft5AxIkOXs6pIrKN/WjZO7eNjE5KU/cM9VgR3gvpW7zsCre613szewTBsmyeRqqyepi3eTEwkM3d5ClszSK9XbjA5ZZ7PlEmjYNLGWoFiTSZio9mwZZ4//1mgpMU6oYY4JSw/SdQH4lhUYTSHK6cN3nbR8RRDDMYRcwsZtCi6mHtQtV14H4seSiunyvRKe4fnhq56ChBxcnlG5zhkqYYMwyrdcFWLjZCkrPWUvDtmfm18di0iWYjA/xf/8qH2ySEdU88e5duCIO989dYISp8RFipibA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR1101MB2203.namprd11.prod.outlook.com (2603:10b6:4:52::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Fri, 18 Feb 2022 17:04:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 17:04:40 +0000 Message-ID: Date: Fri, 18 Feb 2022 17:04:33 +0000 Content-Language: en-US To: , , , , , CC: References: <20220217101428.385751-1-wenxuanx.wu@intel.com> <20220217101428.385751-3-wenxuanx.wu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd X-User: ferruhy In-Reply-To: <20220217101428.385751-3-wenxuanx.wu@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0109.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bafc11be-f966-4e56-fe69-08d9f300c04b X-MS-TrafficTypeDiagnostic: DM5PR1101MB2203:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yIStUdwFXODlRZDNswzOi8RiYpjsnkmW45smIQHA0a25c7pOfpeQ8DOJBdRXHIy7/KybuXLb41JXs3DDifjaoZ9zXrvAi5xwr2a6BCSfOmypn2bb8DAeabBhPpAHV75OiVEbj28v8f0FGIegSLopUxtoRHvIz2JUVp/2s50XxR44ynzB+CF7uKWqGEJl4yqmS1MfZbzsYW0IyzbVEAi4hN/Huj6ceoSkKn2y2fCafxE5LY7/7V4z5h4bXPH6HFB50E59PQetCr2cLoJJbCflmfRKmOm8N7RM0BHjFqWDKUlW+bZLRLodGwoi+AfR/vx76uJAUEmhC/8Kl6REt906jyw0R4wI2odb+XPMGsOaJ5Ao+Kp1YKX5FFPZdKYqiUVSlx3RDDOYBg/qSaaoobAG/c3bumJ6s5ZGZ70rv1CImx2Hl5uooA75DSswtWhPKxxzVc4A+31EqehqMOdTiJyD6712ETF9qfOZlX1O6Zf4gfUIV+u4W7vrABXvZcuCUQuXJYd95iyRUOVMJ3gyKtcA8IqaS9MYbUqQ0cDQzojmXBJ7hfEiAJWDyR5VHDzDV57Kp2mZtZ4KQ6JFYibBI+8vcazgiohze8Yu0Tuq4h090hrBwC1sh9/dQTlqaIiZ16F34DBhBHpz5buNtpmFACthxmkfrsNVRlb6sbe2ODF7JuYw4qnQydL940xuCP42+eNjaedbW0E3462wbOWb3HvUJg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6666004)(186003)(26005)(6636002)(31686004)(2616005)(36756003)(31696002)(316002)(44832011)(53546011)(5660300002)(86362001)(6506007)(82960400001)(2906002)(8936002)(6512007)(83380400001)(6486002)(66946007)(66556008)(66476007)(8676002)(508600001)(38100700002)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ti9OeUhMTGdwU1c4NHdhemwwc0FtbUtQZm5YQTc2cWR6THRIbDB0OGxBUFpo?= =?utf-8?B?eFlLME5mWFI1dFkrcUhBYzZobGJvYXhzL1RiNWVHcjY5RHVZdmFwb1pUWk5R?= =?utf-8?B?MzRCY3NKRktvUkJVc24rYnlQSXpKWlRYNzJQR0ZlL1hidFE5WGZsd0tBNkNG?= =?utf-8?B?bkdWN1AyU2hhT0pJc2kyY2l6QURrM0F4WnhiTVRrdGdndENpWVlvZk9ZbjQ3?= =?utf-8?B?dDhXTk9iV1BsMGZCU3BEZXVWWkhST1M3djZQdzBZaWFnNTlnait2U1A3cThN?= =?utf-8?B?aDZSc2ZtRCtzdXNnME0wZmlwT2xPd1hlUytNalduSVFQVEt4Skp0dHNZcTcv?= =?utf-8?B?NHpCVS9FcWdEd05UQUtUeVI4dmt4WkZva2dNRXFxVkxibXQ4U2lRZ2tPQkxk?= =?utf-8?B?amtTRFlDemVYcWJqQlpLWEJmODNrTkRtSDJ5UDd4K0tZZGpadDFCZWtqaFhh?= =?utf-8?B?dHkrWTJOa1IwdUJDYWtDTEtURDc4bzF1aHNoc0l3RjV4QkxWQWc2RzRiNjR6?= =?utf-8?B?SVl6TnhCUUdyZUUxTnFjd2Q2aHRySllHeXRJYitrbHV2bUJSOUd3bzZ5ZkVB?= =?utf-8?B?V1lTVEFMemhtdWF3bFpRVWFkU3BaNEJkdnVWUGgyWVJTa1pjVE9MSStQYU9a?= =?utf-8?B?RHN1NEl5MXB2dG5pOHBaOFk1NEJxN2hVY2wxWmJCcm5oeE8wZXMwbGp5eUNF?= =?utf-8?B?cEFHVlFySnV5Z1NwOHg1UGtHdDM4TkJ5Wk9EdklMOUJYcE1XeEc4cVltR1U4?= =?utf-8?B?UTE4VWlPT1BJdGNQRXlhcS84VEpLNU9sMWZsWUJ0dTg3SjJUWFhzZEhETThk?= =?utf-8?B?aUJlY29BNithNVR4anJlaTdoTDhrKzRWSWJ2NFFiTmFlWFpiOVY4MnRLU0RS?= =?utf-8?B?bnFqTTE4ZFNDa1NlQjRlTTRsTjdVYkVmekVNMDY4bmxzcWJDQ01nUTFNN2U0?= =?utf-8?B?ZnNiWVhZd01jNFFqemI5c0g3TWhXZVcreGxPUGs1Rk1jWS9JQXYxWVFBN1c2?= =?utf-8?B?YkRCY1BwbStOclQrMGZhczllK2ZDeXlsdDdSckJBMTZVKzN0RDM1ZFpHd2hv?= =?utf-8?B?YWpUd2s4QnM3bjFkU1I1SHhDUk5KUlN1U0x6N1FweEVDcklUcmhsY0tWOWdi?= =?utf-8?B?aDBDV0plK0t6dWpGcmtuS3VCUHZJTjdlZXM0eXFNbk5BdTc5NHEyL29Mc1NH?= =?utf-8?B?enM0ZjU2UkpSQ2Y3cFUvY0NjSlFVeFNHTWVpMHpMWGdTaWZXbkJxQVc0V2VB?= =?utf-8?B?V1RyVi9NOFhycEppTUFBMHQxRTVLT1RTRjIzQVlGYlJwbFVoOWUxWFVKK0xz?= =?utf-8?B?ZGYxcDEva0JsTlF6SmhMREN5QlBvMGZTVjVtTUVPVHhGUVpweHI5Z0I3eUhw?= =?utf-8?B?WFU1Mkw0YXlSSGtvMmJmQWpjS2lXakxGQ09xSzFhQVgrelYzd2Z3NzlTOUZ5?= =?utf-8?B?TmM2YlJicWI0eWlhblFESDRXVWI2YTZDL3Fmb1hxYkM5VFA2aDdlUGVFUGJG?= =?utf-8?B?bjB2V3VzTitPM3ViUHBod2FGMzRBQTZMNzh1cmF0S3dUSVpDRVZtb0NxVUZn?= =?utf-8?B?WWNyNDNFMk40SmZRRlNnamVSZkFFRDFmUEJLN0hqb2UzNlBldlNrb1N6aTlJ?= =?utf-8?B?MTVyS0VjODdqdk9rUHNTcUtBYmJ4SWhScnZ0OEsvVFJtMTJCbklueVowUE9B?= =?utf-8?B?SnFXYXAzbmRITzNDd2l2WjRzeVlPN2FuSlVZM3hSdlFJWTFHOGovMzNEQ3Fx?= =?utf-8?B?Um83NnRtVngrcWw2Q0JzeHg4bWZzWTZ5V0o4enM4Rk9VQlgxbHQxVE5vdmd1?= =?utf-8?B?eDBncTFKVVZnNE5ZNGx4d1MwYlpWWmd0S2MrS0UrR1NMckcxalFuejM5NWFD?= =?utf-8?B?SVE4RDBzSkt5cDRGUjVwU052NVQ5V2U1akI2a0Z1cnk3VmRCYVJWcmNrTVNI?= =?utf-8?B?YnpDVTZ1SUduSUpuTGl4dE1pV3J2ZHlFQm84eW1JNHJsMTNPNDVnaHpPaXdt?= =?utf-8?B?WnoxMlpMY01FdU8zUy9zRVY2WWxtYnhOUVkyNElYWWRmdmQxUDQrOWdMSFVC?= =?utf-8?B?WHZON3cybkhyNGxGRnkxZnNXUVM5MmtIREJjZ1VmRzdrZnAyU3hnRlR4UFB2?= =?utf-8?B?VGtkbWg5WGxqczFhVHMvKzVPbGlWVE0zYU5ZUFh6blQ4R2Z1ZWFnaFZyYXBv?= =?utf-8?Q?Gp0MDfsmvy/SOYdgm672x08=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bafc11be-f966-4e56-fe69-08d9f300c04b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 17:04:40.4828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G0Amg+XlwlyUOG74OHP0oSDM8w+CLUTNbP2cawAPXAVdew8VY7mOE9ENs0Ksli5R9Hmmp4gSMnihEls/HYeN0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2203 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/2022 10:14 AM, wenxuanx.wu@intel.com wrote: > From: wenxuan wu > > There is a heap-free-after-use bug when quit testpmd > with pf and vfs, stop and close ports in reverse order > is a more reasonable approach. > > Cc: stable@dpdk.org > > Signed-off-by: wenxuan wu > --- > lib/ethdev/rte_ethdev.h | 14 +++++++++++++- This patch should come before testpmd patch, because testpmd is using macro defined here. > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 2660e4f374..e080840b06 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -2185,9 +2185,13 @@ struct rte_eth_dev_owner { > * @return > * Next valid port ID owned by owner_id, RTE_MAX_ETHPORTS if there is none. > */ > -uint64_t rte_eth_find_next_owned_by(uint16_t port_id, > +uint64_t > +rte_eth_find_next_owned_by(uint16_t port_id, > const uint64_t owner_id); > > +uint64_t > +rte_eth_find_prev_owned_by(uint16_t port_id, const uint64_t owner_id); > + This function declared but not implemented, can remove above. > /** > * Macro to iterate over all enabled ethdev ports owned by a specific owner. > */ > @@ -2212,6 +2216,14 @@ uint16_t rte_eth_find_next(uint16_t port_id); > #define RTE_ETH_FOREACH_DEV(p) \ > RTE_ETH_FOREACH_DEV_OWNED_BY(p, RTE_ETH_DEV_NO_OWNER) > > +/** > + * Macro to iterate over all enabled and ownerless ethdev ports in reverse order, for quit purpose. No need to add comment related to "quit purpose", macro can be used for different reasons. > + */ > +#define RTE_ETH_FOREACH_DEV_REVERSE(p) \ > + for (p = (rte_eth_dev_count_total() - 1 >= 0) ? (rte_eth_dev_count_total() - 1) : 0; \ Below check already relies on 'p' is unsigned, also 'rte_eth_dev_count_total()' returns unsigned, if so above check is unnecessary, it can just have: "p = rte_eth_dev_count_total() - 1" > + p < rte_eth_dev_count_total(); \ > + p--) > + > /** > * Iterates over ethdev ports of a specified device. > *