DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] ethdev: add include for vtune
@ 2022-10-12 12:02 Markus Theil
  2022-10-12 12:26 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Theil @ 2022-10-12 12:02 UTC (permalink / raw)
  To: dev; +Cc: Ferruh Yigit, Thomas Monjalon, Andrew Rybchenko, Michael Pfeiffer

From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>

Adding this include allowed us to use vtune
with DPDK.

Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
---
 lib/ethdev/ethdev_profile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
index 7978f351ac..90339cb2ee 100644
--- a/lib/ethdev/ethdev_profile.c
+++ b/lib/ethdev/ethdev_profile.c
@@ -3,6 +3,7 @@
  */
 
 #include "ethdev_profile.h"
+#include "ethdev_driver.h"
 
 /**
  * This conditional block enables Ethernet device profiling with
-- 
2.38.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethdev: add include for vtune
  2022-10-12 12:02 [PATCH] ethdev: add include for vtune Markus Theil
@ 2022-10-12 12:26 ` Ferruh Yigit
  2022-10-12 14:32   ` Markus Theil
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2022-10-12 12:26 UTC (permalink / raw)
  To: Markus Theil, dev; +Cc: Thomas Monjalon, Andrew Rybchenko, Michael Pfeiffer

On 10/12/2022 1:02 PM, Markus Theil wrote:
> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> 
> Adding this include allowed us to use vtune
> with DPDK.
> 
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> ---
>   lib/ethdev/ethdev_profile.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
> index 7978f351ac..90339cb2ee 100644
> --- a/lib/ethdev/ethdev_profile.c
> +++ b/lib/ethdev/ethdev_profile.c
> @@ -3,6 +3,7 @@
>    */
>   
>   #include "ethdev_profile.h"
> +#include "ethdev_driver.h"
>   

"ethdev_profile.h" already includes "ethdev_driver.h". What was the 
problem without above change?

>   /**
>    * This conditional block enables Ethernet device profiling with


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethdev: add include for vtune
  2022-10-12 12:26 ` Ferruh Yigit
@ 2022-10-12 14:32   ` Markus Theil
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Theil @ 2022-10-12 14:32 UTC (permalink / raw)
  To: Ferruh Yigit, dev; +Cc: Thomas Monjalon, Andrew Rybchenko, Michael Pfeiffer

On 10/12/22 14:26, Ferruh Yigit wrote:
> On 10/12/2022 1:02 PM, Markus Theil wrote:
>> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>>
>> Adding this include allowed us to use vtune
>> with DPDK.
>>
>> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>> ---
>>   lib/ethdev/ethdev_profile.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
>> index 7978f351ac..90339cb2ee 100644
>> --- a/lib/ethdev/ethdev_profile.c
>> +++ b/lib/ethdev/ethdev_profile.c
>> @@ -3,6 +3,7 @@
>>    */
>>     #include "ethdev_profile.h"
>> +#include "ethdev_driver.h"
>
> "ethdev_profile.h" already includes "ethdev_driver.h". What was the 
> problem without above change?
>
Thanks for the hint. I've overlooked that this was already fixed in 
2022/05 with 8c9e97ddbedd735f70a2e6b1d5d4ffef02a9b0b9. I'm archiving the 
patch.
>>   /**
>>    * This conditional block enables Ethernet device profiling with
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-12 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 12:02 [PATCH] ethdev: add include for vtune Markus Theil
2022-10-12 12:26 ` Ferruh Yigit
2022-10-12 14:32   ` Markus Theil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).