From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9CBA4A0543;
	Wed, 12 Oct 2022 16:32:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4B73143027;
	Wed, 12 Oct 2022 16:32:24 +0200 (CEST)
Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67])
 by mails.dpdk.org (Postfix) with ESMTP id E395E42EF7
 for <dev@dpdk.org>; Wed, 12 Oct 2022 16:32:22 +0200 (CEST)
Received: from [10.183.254.100] (unknown [80.88.23.165])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 6C75E580097;
 Wed, 12 Oct 2022 16:32:22 +0200 (CEST)
Message-ID: <de8adb3c-3a2f-c7a8-db12-5b586d4c66c8@tu-ilmenau.de>
Date: Wed, 12 Oct 2022 16:32:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] ethdev: add include for vtune
Content-Language: en-US
To: Ferruh Yigit <ferruh.yigit@amd.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
References: <20221012120202.11123-1-markus.theil@tu-ilmenau.de>
 <29b00899-404b-8b38-f36a-eef0fc2f7234@amd.com>
From: Markus Theil <markus.theil@tu-ilmenau.de>
In-Reply-To: <29b00899-404b-8b38-f36a-eef0fc2f7234@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/12/22 14:26, Ferruh Yigit wrote:
> On 10/12/2022 1:02 PM, Markus Theil wrote:
>> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>>
>> Adding this include allowed us to use vtune
>> with DPDK.
>>
>> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>> ---
>>   lib/ethdev/ethdev_profile.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
>> index 7978f351ac..90339cb2ee 100644
>> --- a/lib/ethdev/ethdev_profile.c
>> +++ b/lib/ethdev/ethdev_profile.c
>> @@ -3,6 +3,7 @@
>>    */
>>     #include "ethdev_profile.h"
>> +#include "ethdev_driver.h"
>
> "ethdev_profile.h" already includes "ethdev_driver.h". What was the 
> problem without above change?
>
Thanks for the hint. I've overlooked that this was already fixed in 
2022/05 with 8c9e97ddbedd735f70a2e6b1d5d4ffef02a9b0b9. I'm archiving the 
patch.
>>   /**
>>    * This conditional block enables Ethernet device profiling with
>