From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Li RongQing <lirongqing@baidu.com>,
dev@dpdk.org, stable@dpdk.org, ciara.loftus@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH][V2] net/af_xdp: avoid deadlock due to empty fill queue
Date: Tue, 22 Sep 2020 14:04:19 +0100 [thread overview]
Message-ID: <de9d639b-6cd4-15dd-84d4-8071986f9294@intel.com> (raw)
In-Reply-To: <1600428751-30105-1-git-send-email-lirongqing@baidu.com>
On 9/18/2020 12:32 PM, Li RongQing wrote:
> when receive packets, it is possible to fail to reserve
> fill queue, since buffer ring is shared between tx and rx,
> and maybe not available temporary. at last, both fill
> queue and rx queue are empty.
>
> then kernel side will be unable to receive packets due to
> empty fill queue, and dpdk will be unable to reserve fill
> queue because dpdk has not pakcets to receive, at last
> deadlock will happen
>
> so move reserve fill queue before xsk_ring_cons__peek
> to fix it
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> Signed-off-by: Dongsheng Rong <rongdongsheng@baidu.com>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-09-22 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:32 [dpdk-dev] " Li RongQing
2020-09-22 13:04 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de9d639b-6cd4-15dd-84d4-8071986f9294@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=lirongqing@baidu.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).