From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0231A04B6; Tue, 22 Sep 2020 15:04:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC5D91D8DA; Tue, 22 Sep 2020 15:04:30 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0868B1D713; Tue, 22 Sep 2020 15:04:28 +0200 (CEST) IronPort-SDR: XcyyzvDXQXOHXp9ua3rBZNhb23xAxGBnDWSfOVzxCrwY3u7+dZrfdEjyYAIx27tEHiS9ozbVZ1 s5KE3r3m76cA== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="157973259" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="157973259" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 06:04:24 -0700 IronPort-SDR: HoVNp89VDcNyO3fNaNqKXSSIsLzfIzoOLy+I2PYncnZ/Ih8+THGrhQFDOXS4jfhq5r+3HZjdv1 C9To+0K9O4xw== X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="454485942" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.201]) ([10.213.227.201]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 06:04:23 -0700 To: Li RongQing <lirongqing@baidu.com>, dev@dpdk.org, stable@dpdk.org, ciara.loftus@intel.com References: <1600428751-30105-1-git-send-email-lirongqing@baidu.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <de9d639b-6cd4-15dd-84d4-8071986f9294@intel.com> Date: Tue, 22 Sep 2020 14:04:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600428751-30105-1-git-send-email-lirongqing@baidu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH][V2] net/af_xdp: avoid deadlock due to empty fill queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 9/18/2020 12:32 PM, Li RongQing wrote: > when receive packets, it is possible to fail to reserve > fill queue, since buffer ring is shared between tx and rx, > and maybe not available temporary. at last, both fill > queue and rx queue are empty. > > then kernel side will be unable to receive packets due to > empty fill queue, and dpdk will be unable to reserve fill > queue because dpdk has not pakcets to receive, at last > deadlock will happen > > so move reserve fill queue before xsk_ring_cons__peek > to fix it > > Cc: stable@dpdk.org > > Signed-off-by: Li RongQing <lirongqing@baidu.com> > Signed-off-by: Dongsheng Rong <rongdongsheng@baidu.com> > Acked-by: Ciara Loftus <ciara.loftus@intel.com> Applied to dpdk-next-net/main, thanks.