From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 987E9A0560;
	Tue, 18 Oct 2022 12:52:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3695E4021E;
	Tue, 18 Oct 2022 12:52:31 +0200 (CEST)
Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com
 [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 791B64021D
 for <dev@dpdk.org>; Tue, 18 Oct 2022 12:52:29 +0200 (CEST)
Received: by mail-pj1-f49.google.com with SMTP id
 d7-20020a17090a2a4700b0020d268b1f02so16979470pjg.1
 for <dev@dpdk.org>; Tue, 18 Oct 2022 03:52:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=content-language:content-transfer-encoding:in-reply-to:mime-version
 :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc
 :subject:date:message-id:reply-to;
 bh=qhCZ8QnRgxyBN4USIdUTqDrphMGcbAHzwon65C/p0Lg=;
 b=FNa5dAcx+46ggrq9XBJqDa6A6TykY39Bc4LncapGAD8Tya7ykryMvHchPH9QA6ufNq
 vezz5QfkOf7A6sx7r/+qDBFAVwMaDFXO+HpDAI8suCEwbbzHgwBgNXhP4/pja2laS64X
 ldLT3cdE3EVEHdW0yvTqXzOOtbHyP69FH2aeuyKD6IuciNCLdTg3DM8UVxmJRGgoO4cb
 w81qg42y+5JnYIZF3gEtohgwLdA+xkijUYar+KMnWv7F/zB0S8khm0Px9WTFUKRzfgpo
 mio7svcpaUgURv//dnURDgaTab+JYy+ICwbHWR4nB8MXWtvmfx04eJ3FPnkr5Cp/FC1L
 9OYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-language:content-transfer-encoding:in-reply-to:mime-version
 :user-agent:date:message-id:from:references:cc:to:subject
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=qhCZ8QnRgxyBN4USIdUTqDrphMGcbAHzwon65C/p0Lg=;
 b=hEaxz41SQomWsh4QFs7zL8/ZwaK2SfijKODw8eSVnDPNIoKnCiBO20It3t74GnsntW
 k4WkB73IqZeazJftQFsOePpAimSwEID/x+bs+Cg5g4XK4hTA2nQenYy3R0S5DWYmfKEv
 Y3OTqSd7QvrJMi9YyHhzWjoEA+XN98xbfy3USFtYwjJDCTY0zXd9kVNPxom2p+i1s8R/
 0FxiV9CztD0k0vmqsZUAjC6qhxlVNINFu7xBQwmWspAOUcWRPTef4NdHEtEVi5bSa1HG
 Ugw2THIF8BhwKXRAMdp1SfQUqMroq5p/rL0kbYgtni0JmLjNnkgCm63N63+XUBRef1S/
 cXqg==
X-Gm-Message-State: ACrzQf29Bzhu7eIwGOGGaWT+ZJ5sMv8UYHDWjlpBDW0h/B0LNwyG0xli
 jKlZ+jbpbv/HjOmH+Z2Gc8Hq4A==
X-Google-Smtp-Source: AMsMyM4CBNxWYFIvDhpv/TTsD8BV5+ZLEH3axreCiHjMFnkzJXTrvvDmtdqHVK8QsWcg0TGCAXZgwQ==
X-Received: by 2002:a17:902:ec91:b0:185:4b76:6267 with SMTP id
 x17-20020a170902ec9100b001854b766267mr2578980plg.154.1666090348568; 
 Tue, 18 Oct 2022 03:52:28 -0700 (PDT)
Received: from [100.64.100.6] ([199.101.192.140])
 by smtp.gmail.com with ESMTPSA id
 t2-20020a170902e84200b00185002f0c6csm8462706plg.134.2022.10.18.03.52.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 18 Oct 2022 03:52:28 -0700 (PDT)
Subject: Re: crypto/uadk: introduce uadk crypto driver
To: Zhangfei Gao <zhangfei.gao@linaro.org>, Akhil Goyal <gakhil@marvell.com>, 
 "techboard@dpdk.org" <techboard@dpdk.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "acc@openeuler.org" <acc@openeuler.org>
References: <CO6PR18MB44848DBA263658B2245AA71ED8299@CO6PR18MB4484.namprd18.prod.outlook.com>
 <9e897e5c-b6db-bea7-3490-b57c1f76a8ba@linaro.org>
 <316c505f-8072-5da8-0ca0-d5105ea479a6@linaro.org>
From: Zhangfei Gao <zhangfei.gao@linaro.org>
Message-ID: <dea6abea-7274-1f1a-19ee-838c329da16e@linaro.org>
Date: Tue, 18 Oct 2022 18:52:23 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <316c505f-8072-5da8-0ca0-d5105ea479a6@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



On 2022/10/18 下午6:07, Zhangfei Gao wrote:
> Hi, Akhil
>
>>
>> On 2022/10/17 下午3:02, Akhil Goyal wrote:
>>>
>>> Hi everyone,
>>>
>>> We have a new crypto PMD submitted on ML 
>>> (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei.gao@linaro.org/)
>>>
>>> This PMD is dependent on an external library which needs to be cross 
>>> compiled for ARM on x86.
>>>
>>> It mandatorily need “numactl” also cross-compiled and instead of 
>>> using pkg-config of libnuma, it need the library and headers to be 
>>> copied manually to aarch toolchain.
>>>
>>> And if that is also done, it is not generating pkg-config which DPDK 
>>> can use to compile the PMD.
>>>
>>
>> Thanks for the guidance
>>
>> We are trying to provide pkgconfig file for uadk libs
>> https://github.com/Linaro/uadk/pull/513
>>
>> And have fixed the x86 local build.
>> https://github.com/Linaro/uadk/pull/512
>
> Under this git pull, I have verified building and installing dpdk on 
> x86 with this diff to switch to pkg-config
>
> diff --git a/drivers/crypto/uadk/meson.build 
> b/drivers/crypto/uadk/meson.build
> index dda6c6b257..f6fae0a239 100644
> --- a/drivers/crypto/uadk/meson.build
> +++ b/drivers/crypto/uadk/meson.build
> @@ -8,18 +8,12 @@ if not is_linux
>      subdir_done()
>  endif
>
> -if arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64')
> -    build = false
> -    reason = 'only supported on aarch64'
> -    subdir_done()
> -endif
> -
>  sources = files(
>          'uadk_crypto_pmd.c',
>  )
>
>  deps += 'bus_vdev'
> -dep = cc.find_library('libwd_crypto', required: false)
> +dep = dependency('libwd_crypto', required: false, method: 'pkg-config')
>  if not dep.found()
>         build = false
>         reason = 'missing dependency, "libwd_crypto"'
> @@ -27,7 +21,7 @@ else
>         ext_deps += dep
>  endif
>
> -dep = cc.find_library('libwd', required: false)
> +dep = dependency('libwd', required: false, method: 'pkg-config')
>  if not dep.found()
>         build = false
>         reason = 'missing dependency, "libwd"'
>
>
> One uncertainty is numa,  "Requires: numa",
> This requires numa.pc has to be installed, so numa only can be 
> installed from source code (make install).
> While apt-get install libnuma-dev does not install numa.pc, so system 
> can not search numa.
> So do we have to build numa from source code?

By the way.

When trying to use +Libs.Private: -lnuma,
I found Even remove building uadk, the dpdk fails if no numa.pc, though 
apt-get insall libnuma-dev

/usr/bin/ld: lib/librte_eal.so.23.0: version node not found for symbol 
numa_run_on_node_mask@@libnuma_1.2
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
[2813/3314] Compiling C object 
'drivers/a715181@@tmp_rte_event_cnxk@sta/event_cnxk_tx_cn10k_tx_112_127_seg.c.o'.
ninja: build stopped: subcommand failed.


Thanks