From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C37DD1B626; Mon, 5 Feb 2018 17:34:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 08:34:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="24979527" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 08:34:27 -0800 To: Rasesh Mody , dev@dpdk.org Cc: Harish Patil , Dept-EngDPDKDev@cavium.com, stable@dpdk.org References: <1517637799-15390-1-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: Date: Mon, 5 Feb 2018 16:34:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517637799-15390-1-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/qede: fix VF vport creation sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 16:34:33 -0000 On 2/3/2018 6:03 AM, Rasesh Mody wrote: > From: Harish Patil > > Few adjustments are required to effectively handle VF vport create/delete > sequence. The problem is exposed by recent ethdev TX offload changes > which requires port to be in down state before applying TX offloads. > > - Move vport creation from dev_init() to dev_configure() > - Force to stop vport if it was already started due to previous run > (restart case) > - Move link state enable/disable to dev_init() and dev_close() > respectively. > - For MTU change, recreate vport with new MTU value and restore old > config. This is necessary since VF MTU value can be changed only upon > vport creation. > > Fixes: ec94dbc57362 ("qede: add base driver") > Cc: stable@dpdk.org > > Signed-off-by: Harish Patil Series applied to dpdk-next-net/master, thanks.