From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22AC1A0C3F; Thu, 15 Apr 2021 17:51:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE2616239E; Thu, 15 Apr 2021 17:51:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 87423161FB9 for ; Thu, 15 Apr 2021 17:51:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618501882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mjzkYksdRkJ0H0gT98oyxKbfp0rOvjAZxgb9sK97Z7k=; b=XoITta0LfRjJnmEpkFQYGsJvrKkwbbFOlXbDTivRH/WC5i3HJ40PaR/9fXKNw/1Jxq8FRG tOl526Nrbjq9l5eHn71dWmixUEj9Ib/lW2SKTJqLg8hWDv9AP1kBrWgjvTVsItE9A7Arcb 8zX/kXjsOx6v4yAkNLF3IaRI7aaOrU4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-OVAlRAKSMJKmQ9bmlYs5mg-1; Thu, 15 Apr 2021 11:51:21 -0400 X-MC-Unique: OVAlRAKSMJKmQ9bmlYs5mg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CFDB8B1060 for ; Thu, 15 Apr 2021 15:50:52 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6AA4105C720; Thu, 15 Apr 2021 15:50:51 +0000 (UTC) To: David Marchand , Balazs Nemeth Cc: dev References: <87be741c28c8d93a4cf93dc1af556cd4ead687ed.1617790501.git.bnemeth@redhat.com> From: Maxime Coquelin Message-ID: Date: Thu, 15 Apr 2021 17:50:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/4] vhost: allocate and free packets in bulk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/15/21 5:45 PM, David Marchand wrote: > On Thu, Apr 15, 2021 at 5:33 PM Maxime Coquelin > wrote: >> On 4/7/21 12:17 PM, Balazs Nemeth wrote: >>> Now that all allocation and freeing has been moved together, use the >>> faster bulk versions instead of handling packets one by one. >>> >>> Signed-off-by: Balazs Nemeth >>> --- >>> lib/librte_vhost/virtio_net.c | 11 ++++++----- >>> 1 file changed, 6 insertions(+), 5 deletions(-) >>> >>> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c >>> index 496f750e3..2f0c97b91 100644 >>> --- a/lib/librte_vhost/virtio_net.c >>> +++ b/lib/librte_vhost/virtio_net.c >>> @@ -2469,10 +2469,10 @@ virtio_dev_tx_packed(struct virtio_net *dev, >>> { >>> uint32_t pkt_idx = 0; >>> uint32_t remained = count; >>> - uint16_t i; >>> >>> - for (i = 0; i < count; ++i) >>> - pkts[i] = rte_pktmbuf_alloc(mbuf_pool); >>> + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) { >>> + return 0; >>> + } >> >> OK, get it now :) >> Maybe just add a comment in previous patches that it is going to be >> handled when moving to bulk allocation. > > Looking at the whole series, it is easy to read and understand as a > single patch. > And it avoids this intermediate issue. I agree with David, better to squash the first three patches. Thanks, Maxime