From: Declan Doherty <declan.doherty@intel.com>
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: out-of-bounds read
Date: Thu, 30 Jun 2016 10:15:16 +0100 [thread overview]
Message-ID: <ded3b9e5-d7d0-de76-0bd4-99a265391661@intel.com> (raw)
In-Reply-To: <1467202744-4140-1-git-send-email-slawomirx.mrozowicz@intel.com>
On 29/06/16 13:19, Slawomir Mrozowicz wrote:
> Overrunning array crypto_statistics of 32 64-byte elements
> at element index 63 using index cdevid.
> Fixed by extend crypto_statistics array.
>
> Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
> Coverity ID 120145
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---
> examples/l2fwd-crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index 8dc616d..70fada5 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -243,7 +243,7 @@ struct l2fwd_crypto_statistics {
> } __rte_cache_aligned;
>
> struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS];
> -struct l2fwd_crypto_statistics crypto_statistics[RTE_MAX_ETHPORTS];
> +struct l2fwd_crypto_statistics crypto_statistics[RTE_CRYPTO_MAX_DEVS];
>
> /* A tsc-based timer responsible for triggering statistics printout */
> #define TIMER_MILLISECOND 2000000ULL /* around 1ms at 2 Ghz */
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2016-06-30 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:19 Slawomir Mrozowicz
2016-06-30 9:15 ` Declan Doherty [this message]
2016-07-11 14:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded3b9e5-d7d0-de76-0bd4-99a265391661@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).