From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCD2942607; Thu, 21 Sep 2023 17:13:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95737402C9; Thu, 21 Sep 2023 17:13:03 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by mails.dpdk.org (Postfix) with ESMTP id 2778C402B3 for ; Thu, 21 Sep 2023 17:13:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRpYk0cjvIML8eeHrSAQBmoptiWhHiDAURU7FoExWnnSWoTWRck++XDNXR09hs7KUME8bYsXCvU3zUjY8cJD7awykgtTXlQj6GBSnn2smAbaAv4ToINIc/fzzRSTt/mYnDjTP7gsQLbOe8+FNnAGPQJuYpGdzetOJ6gHTTSdeyGkicCYVxubCG8xDQ+PM/tu/AlOfRvFBfrMIlURkEPzOe4dL1qtFcHOaC0MgN1ahifJcUXnF2FaEHVobC70RHVRMvFdFlTNXr73EOLM3FZ/VLlAGZDz5iqnHKBARFbqyrKcmsQvJVQiSIK58obGb2ZeR5+ryUJNisE2R9v8pSdDHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SuXGQeMdvhzB2XUsFKgcw3665sJ/PJHCiR7X9zuTrEQ=; b=Id4UzswxbXa5PNO3vIim3Y5wA9fBXqg67Sk2sAtIBDXvb4J3SihMqGbGOA8Ix95zt6kndKB9Oc7wnHhwK6yKLgPlPfdkujcbAgV59hueXiRozeF/1VQF0oTJ1UgrQ7FZMZ7XI6pDBJ47yOwB4oEBTrCrw1UfmmfsJQMAPMYJySaz0n4nCA46oCw55WYsE37D6K0CTK+QMhctP2gUQ5Zy3ciWxZMDp8VnK+aDQf5CUzqf+wnmrgxFqSMXC0HKaV5gKzZ2l2aNCD3bKpYSBDCxYsLQjlakDlvJE2JjoVMUvO328VxRFyZcDlzMpOhaKuU+Jep8tFyoeVFBlJsTciC08w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SuXGQeMdvhzB2XUsFKgcw3665sJ/PJHCiR7X9zuTrEQ=; b=sVu0uL0VR3Ru5zUhRdJMtJh3rp1i9b+bLhODYwWcaGdfKYzfzgxkSmuhdzR7nmFAkCSKcUmBUajzbwYRXxP5/5bVcnRjhYlUm4nccyYrwdiqCcgnIYFOpCtXDCtDFEJW0B07G6c4As/N8bcowy7qvxu0B+RMZGd/P9r5aCwAwys= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB7859.namprd12.prod.outlook.com (2603:10b6:806:305::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Thu, 21 Sep 2023 15:13:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 15:12:59 +0000 Message-ID: Date: Thu, 21 Sep 2023 16:12:52 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: validate reserved fields Content-Language: en-US To: Bruce Richardson , Stephen Hemminger Cc: dev@dpdk.org, thomas@monjalon.net, Andrew Rybchenko References: <20230525203942.129413-1-stephen@networkplumber.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:208:ac::40) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB7859:EE_ X-MS-Office365-Filtering-Correlation-Id: 1573c144-7a1c-4540-f808-08dbbab53e09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ScpMherRlbCow51kxGMYgMuwGdEddGPgeqwKFBqRwhYBwp4QIVzmnR9hu7YftYAJ9byTUo/iIwqzoE5fTxXs+oHFD9qKwAXOKQwjI8TXz0hXHfdAx9Any39/QvhNM1S5Z/mkhkbDBF3vU6pAIpbUeokyDfvw6WP9vKumlaGD9oRWpyMN5NuZiuqKJPKLDdWNvp503Y8hmeay4AST77OFUbEsjnKN+cq/hhBXWVZq+3KoRvLRMQ9r6nqvo+hHBioCrFEnMByKC8T/uG8/j3gdnQnqXTgC9db7VmxWUJ63v3EuGwQ8qQFkERJh9Ppj6XUa+nyeGSJbXHVSJ+8G7g6Kn7JV45mQmNOM3BsoKLiHPor0EZlauu7ni0DG6lUGOZpQXp7PN3PKA4dRYz7g4Ru1EgiKV4ySOMjkjbb8FKH9R4g/rtuwoK2YzK8wSKhAx9fgNGwkF2c4Bfno8dljeHXZdAsS8OQagJhBvE8BRRRME4QqXi1oEhnzSQieZ5TibckOZagXa8Ch5CWm41Y/4FdrsGOKMIEPWxAM+mGhZbgFXlRYkeBXdV/yo457KawqBB7vC9iB3j+lgSGGxS7CUKffKuX+rDqyeHNyicWqL+SKg64MJf/09JKdov1DWZzseZ24ubvzvCJFz34uS5lizZNjUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(376002)(366004)(396003)(346002)(1800799009)(186009)(451199024)(31686004)(36756003)(86362001)(4326008)(44832011)(4744005)(5660300002)(8936002)(31696002)(41300700001)(6512007)(53546011)(26005)(6506007)(2616005)(6486002)(6666004)(8676002)(66946007)(38100700002)(478600001)(2906002)(316002)(110136005)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkwvV3JPZnJITWI1ajM1ZmI2SDFzdHR2T3d6YXhjSE4xYkkzYlN1VnpsWTdi?= =?utf-8?B?emdBSGNCQ3pkaEQvUEpCWk9ZNmdacXZMdEhia0JNSEJzUW5tc3lxc0txT2VR?= =?utf-8?B?YmtWRXNJbnBzalJDN0FqbXk5amVGYlQ5cXhQcFE1c2tad3Q4d2k2Z290Y1JV?= =?utf-8?B?SHhXZ0FjRi9yWlV4alhlQmVNYndMSC81dVEzNkJvMHhydGpaaHZJRFRySStn?= =?utf-8?B?N2lRZGI5djErd3lTb2JaOGZiOXpGOU5TWlB5bHNhMHZqbFUwZVZTaDNLTTRY?= =?utf-8?B?NzZFNjNYVG05akY2a3BkRlBnUFA2U0FwQng4R3ZPZDh4Mm0zOGw2ZTh6ZWda?= =?utf-8?B?U1pZRGNBNEZFd2pRWk9mcVJucE8xZzcyY0dBWWVncjZNM1BYcmJ2TDRKaHVR?= =?utf-8?B?SUMzNjRmTy9MRThzQTBTNjJ6a0NBUExuNEp4M0tzYm9ENnhJK1MxQlZEcEJN?= =?utf-8?B?NU14WmNiRkdGYkgxSytaeGdUcnhPSHJEV0hvUFAvakNyRExmN0puaWpFYU12?= =?utf-8?B?WTZOZEs3UktTMzkrMXgwQ1dLQTVGK1hZTVZBK1N6ZUFkM3JTU0dTck12dWJO?= =?utf-8?B?WTM0N0NtbVZPbU9KRzltSnBILzc0di9vMzBiRmVtSnVKd0dCUEJMdnhmeldS?= =?utf-8?B?N2lheDltT0tIRGFOcWl0cy8wMnRFbE5IWUFaMUhRZTdzM1d3NXA4QjE5Qkcy?= =?utf-8?B?NHAzUkJTbThzM09NSDZHWWpPSnNjYks2TG93UkhJWndpdDd4VGNYUFFIUDhr?= =?utf-8?B?WjB4L1FKWmtSbWVwdTk3dFcrVmtlN2NYVXJNbEJwaFAwQll0aXNpREdMeW4x?= =?utf-8?B?bDBJODJBMktGVm5jeHZZZ1RqQUgvVkY3Tms0bTJZa2FMakJuUzM4SDhpL0Jy?= =?utf-8?B?ZGN3aElZUmdvK1FJUTlqdTBjZEMxQTM5MlRFZ0UyT2ZVMnFqWlhDTWFOZmxL?= =?utf-8?B?MnJWelJ2THJiZk84RU5tM3NQUEVaY0NzSWpVR3RWZ1J4Q2ZqUjJtVHpHWlhw?= =?utf-8?B?cEcxOUtHUGhsL3dVR245b2U0cHhxbDdJcGU3V1lWOURtNTFidjRQc0VUSGhC?= =?utf-8?B?bTBOUHhHYk5uOW9yMVAreDhlQm8wNEdadjZLMVBJVndrUVZTbzI0VWR0Q3A1?= =?utf-8?B?MkJqc2hKVGdoWHlxTmVUVmRZYkQ5dXlKeStyOEpFcENKbXZQbUZ4VGtrTlpX?= =?utf-8?B?eVFCY0RJK25QU3pEQ0NQWkFxWXozMXdKNFlqSXl5d3RXSmZCdkdZSnFWdTFv?= =?utf-8?B?K0pUR25DdHM2c0JURWQvTDVCZEVoSW1JZWk1QU9vd2dsVEd2SHJYTjliaUJH?= =?utf-8?B?UnJTYjhBck5ncmsrZkZxTXErT1FPOUZueDVDU2N0RXo0RjBLVFIvcmJtYndh?= =?utf-8?B?ZW8rTkZ0VU9MSFlVVnI2MU9uZFpwSGFRTXVUNlJsT3o1ckZIeTlGdGE3UzBX?= =?utf-8?B?RUxuZEZRL3FzNjdSM0IzYjI3QWRCZ1g0dnB6djdyZDYvdTcwL3U0Z3cvYjlH?= =?utf-8?B?bjlKajlIVDRMWEZMdDZucjVnQzN6TVpRYnFjZUsxdWxWVk0rNGYyaDl1NGEz?= =?utf-8?B?WTZhVk5pcXBjRUNQVFBoSzIvSXJSVlorYzZiUWtTR2N3QWRKOXZSTnNWL1Br?= =?utf-8?B?Q2lHSXl1blNoTXpoQ2xYa0R3SGVqR2hvY0lBQ3lZN3hkVFFoZUczMjRJbnZ0?= =?utf-8?B?OUwyN2plNkhjOEtydWtvZFpkY203a1RkTHRGNXMrWjlFK0d3MDJTQjlyTTF2?= =?utf-8?B?WVFGMUlZaU1yVmJwR1pNZTZML2NENFg5VFFEVzhRNHBXZ2NET0YxNlRBR0U2?= =?utf-8?B?eHNGdFRzeldtMkh4ZjdSRS9wRVNSakd6blc5NCszNm83Ry9vSk1GOE9jd1Fj?= =?utf-8?B?aUhDeG9IVTdvY3ZPeGMzL3MrR3c5Skdvakl6TFJFWWJBZUpIK2N4OU90UDYy?= =?utf-8?B?THMvbk1yOUhrd3BJR3RsQ0VzMjlGMDNBcXFIUUMwTlBsMVZWZkJqODVWU0U2?= =?utf-8?B?R2Y1c0xCVUdRdFZLeUlhK2VjbEtQS1dRajh6KzlrSGczZUlqUEZlZHMyU3hK?= =?utf-8?B?VkpQR3hPZW11YkVTcXV2WkZITmxUMVJJUzRjV1hnMzNxVGRHNUhlM0lsYlQ1?= =?utf-8?Q?2D2F4i2VoLPrsSwpa5f532mR/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1573c144-7a1c-4540-f808-08dbbab53e09 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 15:12:59.9214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1toJsYMilAGZg7fycxOLNY5uwfDtCFT2nkbvZhTDLKc1RlNnTgGBd5MgXFROh1U2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7859 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/2023 9:15 AM, Bruce Richardson wrote: > On Thu, May 25, 2023 at 01:39:42PM -0700, Stephen Hemminger wrote: >> The various reserved fields added to ethdev could not be >> safely used for future extensions because they were never >> checked on input. Therefore ABI would be broken if these >> fields were added in a future DPDK release. >> >> Fixes: 436b3a6b6e62 ("ethdev: reserve space in main structs for extension") >> Cc: thomas@monjalon.net >> Signed-off-by: Stephen Hemminger >> --- >> lib/ethdev/rte_ethdev.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> > Acked-by: Bruce Richardson > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.