From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C70B0A00BE; Fri, 11 Feb 2022 11:37:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CE4B41144; Fri, 11 Feb 2022 11:37:42 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id CA8A740150 for ; Fri, 11 Feb 2022 11:37:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644575860; x=1676111860; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=hzwYa1tEL3CIolGQKG+kCXeHyBI7Ni1lW5L5DIxbHag=; b=CEax3x/RzNqGX8iLGQh/AiRjH4ZP4jaF5gg/YuNwvuGxeVXTo+vEGL54 gRhfYwReq9xBqG4WlZzIDx4LdUxqUDrjdR4VBMUjbcC/98ZFwFCMGwV1L Hl+3fk++SUP7qCSu+inigSxe3qFybJE7qrSKKlzk0h45gEmjfNAFNH2/8 cppQjbf0ShvlBKTbHwQqKKSs6Dd1eFlHMpjlwHh8jzV8pW+GZwMfChaXO hYRROlDDAYOj1dMIcOZpEt/VElYnJ8M77a8OOGAnquJje9UTzgqEX5POP stBKky8HIW08K02nQU5UiLr8XcuEgv2azwlDo7vHDn5oNZ+5naLxwhz1s g==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="229675655" X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="229675655" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 02:37:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="537612789" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 11 Feb 2022 02:37:39 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 02:37:39 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 02:37:39 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 02:37:39 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 02:37:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKkcuzFE3AjA8uxHUsGrNCYNl3TP8n3ZS+C68PQD8SnRMQAK26m7DfudcZvd1XxSdqIc7Qot+em27dtfNd7JZ4rm/YF+1vq5LdBP4/F99+KdWym34tQma3Nuha0zFHbpmWCPHNL3mibbktQBayAcA+VIPHtgmHTSJkawr40uGnCNJ7Jgvk7LCaXKOQy2muAMJxQE8oaiUu5HH4n0uSc3r2bnckWD+YrGV536ee/6U2WTlzCVxTGG1W3voafsMH0P+HxZwSjvnv4MamqwhJYWfRC+DNEiIzv56P09gWj9Zi/2TyLpFjnOG7FKItVmtYkJsgEH2MKEXRhEQ7Tsm1M33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ML4nMieJ36OEy668McdxwausamgE0FxwnVMTGGhfY4=; b=D6GZPA7OD1ygRpmxUSwPFImVFlLK6g4t9BW2NDsSqP/cf9aLRyaqkX+yXDviT/UP769KGO8VsVG7vbl3ksNMw9GFMNrUvZxHaJ9KvukLXQya0LHw5LK7ogKT7WnXL682Ijp3KwPB4xi9tw11sJeAegKK8ElR1pJ0lJsTMge6RSL1uzNn450V9HdqN7ul9HqkVPFIiw23qRRganw4NSSHCYtOcv644gj/4rT45VOVogca2556ot/kzBV0LZRYMXQPbuIBsup1Z+ygqmU1Z4Lo9Qp92AmfhjBzH3s+dWNye85LDZY4dOyLXJGArlkNwWNFG6ULmVrae5pUaNrsGj3pQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH0PR11MB5300.namprd11.prod.outlook.com (2603:10b6:610:bf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 10:37:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 10:37:33 +0000 Message-ID: Date: Fri, 11 Feb 2022 10:37:27 +0000 Subject: Re: [v2 1/4] lib: add optional fields in GRE header Content-Language: en-US To: "Sean Zhang (Networking SW)" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Olivier Matz CC: "dev@dpdk.org" , Andrew Rybchenko , Ori Kam References: <20220126084404.40178-1-xiazhang@nvidia.com> <20220211014530.77711-1-xiazhang@nvidia.com> <20220211014530.77711-2-xiazhang@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0161.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1eca63eb-9487-42f2-2981-08d9ed4a831e X-MS-TrafficTypeDiagnostic: CH0PR11MB5300:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D1gffbbILimHsfLbKrVkpxUsVbahz9Y9lwuiTlNqsLz30RFEexIQdBeDR0mP0oxdCcV3X2AthtZJ9KMXWmBRVnhUVTzDrU/aGKQ81nQ1DkL8ayXra/k1mtZyyRDB/yQFfUAyVSAtkjbis8qTKpB4RVsOXeZ3kRhDKo6sathAusVGVJYL2rCQMDchXaZJfhN4SBPlgiM35XlHXWDWqu0d7E4v6nkSB9/wn+Bhwkg0iFe05yYiO12jo2vt5Fg4eFU+r1WcK+tekkPA8XCJxYPWLzjfr3vZSrtHoeaQ9Vsq0kmwL0o2RKVWpBu+U9QpGVpm6r+SlQaOzQhXPKlkd1mJdieyNv7JQazuXu77qWgXj0n2TXMOPfvGbxFe1OEXW3RcBoq9pB3WbqMX9CyR8WyELbu5W6feS16tWzq8zihC4r7EICuc4OxG9UZlFvBwJq2qFNwWRbfVAURfeUqxMBFDQ9UKmKyQrB6F7fqMWjbGgykLGWRwVEUSouvzDNEt3w5+aLl4hMiScF9ogLDtFM3YYiRhcWrxu7CeadOtqTplws1KuGb4po39rvxXdva+GMuhZmWBG7h0vZgjqTaF5F2jqVlpsHucw37TTOEbU1bWeMGj2bfg2wD4M5eo3mq6M9fwFNSGbLzVY9L+lJXGcFrR3NlhyQPbE3Yo4wlLKIegpOatYRNfF/OQN3vlqwU/vxg8ucvZIVQj9pHfCA+/lQyrWBZpMUIHdxNM/PYkUzQ1aX1k8FmD8Rnm274BNMsbaR28kD1xJtztN97B+odGfRgNlKESs0/94DLDJWv5gI9tU58= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31686004)(316002)(186003)(26005)(54906003)(110136005)(2616005)(66556008)(66946007)(66476007)(4326008)(8936002)(8676002)(82960400001)(6486002)(6666004)(31696002)(508600001)(55236004)(86362001)(2906002)(6512007)(6506007)(5660300002)(38100700002)(83380400001)(36756003)(966005)(53546011)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zkt3ZUNKcVpNbXhvQzQ2NUdROTRhODlieTQ0WTQyb0hnUkFqRklnQW5qVXNp?= =?utf-8?B?ZGN2MFVsRjB5UCtTVVpLa3JnMWU3Y3BjcXRVb0JHa0lTVFA0eW1oU29KN2VO?= =?utf-8?B?eThLV0VmbnM4SjhXM0E0ZU13VGMvdjlDOEp1THpEeDdLZkJhYm9HOUZMWE9V?= =?utf-8?B?aWFmNVFyZENSTTdjclZqQ1VHOHkvQVN3NG8wM200VHZwUXdUWEJLNHQ1SWVy?= =?utf-8?B?OHJxVXVuSFprcTk5Y1loaEpleGtKR0lsUm1WL2VrRFVoODBDcGtWVVYxc1Ns?= =?utf-8?B?N1dUQzNsWkhQaVpvRjRDRDNPWU1hdTZpaVM1STU0bThTbUs4Z0t0L0RQRGha?= =?utf-8?B?SytxUFNTMlphdlY2SVFVd0FPQm1ZVWtKZWpvaURsbDBLWTZGbkRhcWxURDU5?= =?utf-8?B?SkFBRlh2YWxGYlFSVzRBUDJwU2dvdXYwSVJoUjdCelhsbTcrOW9uTWVvZDZS?= =?utf-8?B?SDQwb3RveEVkS1RxQ29Hb05Oc3JCVUZ2ZDM1cmF3cE0zSTJDbVY0Yk9tNmJa?= =?utf-8?B?d2w5QXYyVFR2R2poQi9RcXVQeFlNYnJmK2d2YldjUTVwOXFselJuRHBwWHph?= =?utf-8?B?Wk51OHdyOFVvSzhPWVAyWEh6RmlIdDFqRlQzdGFPZEFxRFFqMnZkMW1iK3VU?= =?utf-8?B?Z2pTVSszSXJmWFpVYTRnWUdPR0Rua0l5a2pMNXdPZkpiY25kelBKY0YwNGEx?= =?utf-8?B?TlF5eWlTbjVySjk0YjVFQWc5aUdSekFRRGltb1IxQ2hHcUJmbmpwaERsOHpX?= =?utf-8?B?NjczRHJCdk14WEFsK1NRdG4zN3BaY1o3RW9udFNVUkRGbEpWczBuT0tJQnUy?= =?utf-8?B?VzdkZUpFYnpodmR6WWo1dUtyVFNQOHBRYjBrUy9ZSHh6MDkvZU54cHF5M3Nz?= =?utf-8?B?QTkxajE5V0x6WWRBREo4cEVxckFFc2x3d21rVDhOd3Y5ZFRtTWxiWktZTEI5?= =?utf-8?B?aUxvbFFjUmtwNEcxbDdFbkxOb3VxKzB3T082Qnhad0R3NWJJTC9iZFp0YUpk?= =?utf-8?B?cGlyN1BVbmZ2WUdDU2hpYWR1SHYyVW9ucUdMS1RZUmZZbUtvd0kxK2hnZmN3?= =?utf-8?B?WDJycnZqSi93dmhKTmpySWppWklkQjZPcEUvVTFEYlhpNDkvOEpHczV3WjhZ?= =?utf-8?B?U0xBZk5QdjMyZnBJeG1VVlhaNUhOSkMrNUluZHR2TlNyVnU0TmhzbFVLOFhl?= =?utf-8?B?MWFaRnlhSzRwUVlpdnRkcGNwcG1WVnNLSnJiTzRpdlhkS3U2aGFvaWZPeXFK?= =?utf-8?B?b1daTTUzcVF3MlExdkNjT0xhdE9HQ1NMTGNzWVloZTM0YktPNlkwZVErSEY3?= =?utf-8?B?QjdjY0VTRlAvYXNpdjA4UXI1NHptRG03S0JTS25mMlNtcitmYU1OTU5XeUY0?= =?utf-8?B?clJwTHhkNVN6clRrRHNoemp6WGR6QnpRZDMvcjBlUzZla2NRRm4yd2VvTUVh?= =?utf-8?B?bmRvQ3pTUE5IWCsvVUdreXl1Sit0QWhISHFFZldFc0tzQm5pdjB5dUNORG1T?= =?utf-8?B?ZmRzVFVJSjhtelRZWG9QaGkyM2dQZGRhOENQdnFMcFlIYzQzMWk5MGdBUmxC?= =?utf-8?B?UEIvbXJIZ0NGdlIxUVFaQWFGUFJ2ZUZhakYrMlJ3VzQ1V3daa1o4eStJaXVH?= =?utf-8?B?NjZndElQakdZV2JUUExrZHNNYTF4QnVxWHhsMnlRWTBJQjZxQ2xKN2RuUEJF?= =?utf-8?B?Z01nR1JJZUU5ZEJJNTF5RllIaUFlWEZlR05lYXdUVkxpUW9zU3p5emlPN1dy?= =?utf-8?B?Wll1NzJGSnp3Z25qeU9WMFJ1ZnpveFliWG1KV3FpSnEyVFIvSjlrZXFLb1Zk?= =?utf-8?B?SkdGa1FrdytoZEhZWDNGUGl1L2x1YnZNcno1YllrMEl3Q1o3Y1VCeFlNZGtj?= =?utf-8?B?YlpSKzVWSUFuVEhpWExKSzlaNmNVbWpBbzN3ekx0US81UjhzTkpIVUF1VnlT?= =?utf-8?B?V04wNmpMcTZ0QnVLSmtrZ0twd3FRWktrNUFpVVZBSVRWL3MvaVhYMklQQita?= =?utf-8?B?eGNkWk1xYmxEbFVBVmJtSHUrMm1PZVhJcmhvclR5NHpDUmRaWXVwaVhIeEg4?= =?utf-8?B?M1FGWVAwTTkvTHJESCtxWlU0UkQzbC9GZHBTcG0xczhTbXZ5ZFZSZ2VKeEw1?= =?utf-8?B?VGcvY3ZCcE5GcytDL0UyTUdzNk55MkYwc1dHbXZLUTA1NGVYeUwxZDMrK0RE?= =?utf-8?Q?g1gheqThed1t4SNmbXKlJvg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1eca63eb-9487-42f2-2981-08d9ed4a831e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:37:33.5446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ggRa2P9ETVk0V2GQJ/TY1nUI8HLnmYgpA+j67vLqYG7cBDxAWKW8NAQX4hwo3kg+MYMvZYC02eLJb3t2qf/veA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5300 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2022 10:23 AM, Sean Zhang (Networking SW) wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, February 11, 2022 5:38 PM >> To: Sean Zhang (Networking SW) ; NBU-Contact- >> Thomas Monjalon (EXTERNAL) ; Olivier Matz >> >> Cc: dev@dpdk.org; Andrew Rybchenko ; >> Ori Kam >> Subject: Re: [v2 1/4] lib: add optional fields in GRE header >> >> External email: Use caution opening links or attachments >> >> >> On 2/11/2022 1:45 AM, Sean Zhang wrote: >>> There are optional fields in GRE header(checksum/key/sequence), this >>> patch adds definition of structures of the optional fields. >>> >>> Signed-off-by: Sean Zhang >>> --- >>> lib/net/rte_gre.h | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/lib/net/rte_gre.h b/lib/net/rte_gre.h index >>> 5897756..6c6aef6 100644 >>> --- a/lib/net/rte_gre.h >>> +++ b/lib/net/rte_gre.h >>> @@ -48,6 +48,28 @@ struct rte_gre_hdr { >>> uint16_t proto; /**< Protocol Type */ >>> } __rte_packed; >>> >>> +/** >>> + * Optional field checksum in GRE header */ struct >>> +rte_gre_hdr_opt_checksum_rsvd { >>> + rte_be16_t checksum; >>> + rte_be16_t reserved1; >> >> Can you please explain why this reserved field is added, I guess it i not part of >> the GRE spec, but added for mlx driver? >> > > Yes, the reserverd1 field is part of GRE spec, and the field go together with checksum field, so I add the reserverd1 field here. > > You can refer to section 2.6 of https://datatracker.ietf.org/doc/rfc2784/ > ack, thanks. >> Since these struts will be public, we can't update them later easily, so we >> should be careful on them. >> >>> +} __rte_packed; >>> + >>> +/** >>> + * Optional field key in GRE header >>> + */ >>> +struct rte_gre_hdr_opt_key { >>> + rte_be32_t key; >>> +} __rte_packed; >>> + >>> +/** >>> + * Optional field sequence in GRE header */ struct >>> +rte_gre_hdr_opt_sequence { >>> + rte_be32_t sequence; >>> +} __rte_packed; >>> + >>> #ifdef __cplusplus >>> } >>> #endif >