From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 917C4FA93;
 Wed, 18 Jan 2017 16:54:55 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 18 Jan 2017 07:54:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="1084483496"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga001.jf.intel.com with ESMTP; 18 Jan 2017 07:54:53 -0800
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1484739849-72803-1-git-send-email-jianfeng.tan@intel.com>
 <8fea300e-350e-6b83-a706-acadec98afc8@intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E365111870F@SHSMSX103.ccr.corp.intel.com>
Cc: "Liu, Yuanhan" <yuanhan.liu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <df0317c1-d094-68e6-8351-1675502b3266@intel.com>
Date: Wed, 18 Jan 2017 15:54:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E365111870F@SHSMSX103.ccr.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing
	driver name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jan 2017 15:54:56 -0000

On 1/18/2017 1:49 PM, Tan, Jianfeng wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 18, 2017 7:53 PM
>> To: Tan, Jianfeng; dev@dpdk.org
>> Cc: Liu, Yuanhan; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
>>
>> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
>>> API rte_eth_dev_info_get() fills driver name according to drv_name
>>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
>>>
>>> We do not use the same one with virtio device as some applications
>>> might depend on driver name to differetiate kinds of devices, such
>>> as VPP.
>>>
>>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
>>> CC: stable@dpdk.org
>>>
>>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>>> ---
>>>  drivers/net/virtio/virtio_user_ethdev.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
>> b/drivers/net/virtio/virtio_user_ethdev.c
>>> index c877968..110f6a9 100644
>>> --- a/drivers/net/virtio/virtio_user_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
>>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
>>>  	hw->use_simple_rxtx = 0;
>>>  	hw->virtio_user_dev = dev;
>>>  	data->dev_private = hw;
>>> +	data->drv_name = "virtio_user PMD";
>>
>> How driver naming done changed in next-net.
>> Please check any other virtual driver in next-net for sample.
> 
> Thank you for the info. And it seems that it's already fixed by that patch.

That patch modified during merge, can you please confirm the latest
version in the repo?