From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0069.outbound.protection.outlook.com [104.47.37.69]) by dpdk.org (Postfix) with ESMTP id C3CAE1E2B for ; Mon, 9 Jan 2017 07:31:05 +0100 (CET) Received: from BN6PR03CA0048.namprd03.prod.outlook.com (10.175.124.34) by DM5PR03MB2473.namprd03.prod.outlook.com (10.168.233.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7; Mon, 9 Jan 2017 06:31:04 +0000 Received: from BL2FFO11FD044.protection.gbl (2a01:111:f400:7c09::154) by BN6PR03CA0048.outlook.office365.com (2603:10b6:404:10c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.7 via Frontend Transport; Mon, 9 Jan 2017 06:31:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD044.mail.protection.outlook.com (10.173.161.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Mon, 9 Jan 2017 06:31:03 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v096V0Na000662; Sun, 8 Jan 2017 23:31:01 -0700 To: "Rosen, Rami" , "david.marchand@6wind.com" References: <1482756644-13726-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-5-git-send-email-shreyansh.jain@nxp.com> <9B0331B6EBBD0E4684FBFAEDA55776F93D482B72@HASMSX110.ger.corp.intel.com> CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" From: Shreyansh Jain Message-ID: Date: Mon, 9 Jan 2017 12:04:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F93D482B72@HASMSX110.ger.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131284170640152019; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39410400002)(39850400002)(39380400002)(39450400003)(39860400002)(39840400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(199003)(377454003)(24454002)(65826007)(54906002)(8936002)(64126003)(86362001)(105606002)(4326007)(77096006)(104016004)(83506001)(50466002)(5660300001)(106466001)(85426001)(97736004)(38730400001)(8676002)(5001770100001)(81166006)(229853002)(81156014)(54356999)(33646002)(5890100001)(189998001)(50986999)(4001350100001)(2950100002)(69596002)(2501003)(626004)(92566002)(76176999)(31686004)(6666003)(305945005)(36756003)(68736007)(230700001)(2906002)(93886004)(65806001)(65956001)(47776003)(23746002)(31696002)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2473; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD044; 1:5UnloKEh9mPLLNqsohrk8d8TPadTUn3GQcWSYKau+5RS17AY4OQRX5sYB7re+ZdQHIPTNNtv4vPJuqIe+2CMeKthWm2mkKsK1pHMHYfCnRAcnM/Tz96XyXkU+lWSuUfmeDvMaC+n1eW+IuyAH30c93fUUfeGKwQp/mAo7IBIZdOfTWh16QWto8syD7VSVLbWr9ftZ4L5wCCPBkIR1VLHf6W0cdgnksa8sYpP11iFFDGfcZTtDZ8TNYNs5Pu/JItj2r62/CCh50mEvAwwsKubZEQJtvBnPFY+02FpeiMZwWiPQr0GlOMNMJHyyyc+KjCm1P/e5EVFVaXDSICcgkFF5W9ykGDLljOactkfs3D1rNxrWtMaZeobJG9AYeXBkFXA8TFwQpv9zn7XAW8JNlEWb7Q/9gmenr10UXb2h/4mLvqSaaCgXQe1HMCkmo3Wd3c/kcwuDO5OcEeqVyG4sDG2oCkvOQts2JSTW3YtxhWxSzZt4g6t7WqHTA5izuSMKX3doUdwHo5pq04Sg7BTtrTHkOz9GDnQ3H7UHvwNtMDopOEN3eF9vjrapf7TrfhDy49RHKUraqnmDXxYLa03hr+M58LgXZxXkX6tm6VKXYMqqULhvcQkqaYBv7W4OwIcfuFt X-MS-Office365-Filtering-Correlation-Id: ece6b3ab-055f-4adb-e96a-08d438591604 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR03MB2473; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 3:IDmwxJAXCRfF6qtEBahqy7XO/tOsDD3CVWlRnXLWSKX1WaagfNobUkxsabndDfV2RxvHyOg015ACyU8bDlOV1aOX56vnNwGR1kdmLQTtWD4r/x/PWJEIB8MCehhZkYR8uZUUqzg8aZ/2s5J0kG2lzbqsKR0jVa75eM3PW5PQ3txg9XzXrKer/0p8FanggJRzNg/cZXYLFgYmUjS+EvsJf8CCZJb6edJd25UK4iYBTyBPU9ERAUEzucVcb0f8tm9BbfWYKIcDzz7f1Hyq8Pq69Lk4bcngwq4yMDNdwsInYs9GLx+FiKw5qRKkDXmB4WOWp6DCrxE+crBlgqSrsCuHfomHbZPAag/QAhkENi97lhslXp8O00srzgqdxBGDa+WT X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 25:uCLmIxWKpuaR4YymZilatD7FkzixQkMXCWWm7cx0m23U+agCs28sJh8ZAij7Qq9C81U3OL4Jonzy5HiBeA3oGPl8S4x2i0CSdr+ut+lYcUahboYk1QOy95LHf98NaUsyPzJveFsJLagQu5kRUB+k/1o7bewvOP0nx8IgiuCUOfbFif2opKjfT7Y8nSuof2TYxsDiuuJMlggr9X0ejacrbAhVAtSB3sVKjT/CYnV8+i0AJPws/pvCRyoSoz9HLO000MCGm/VtkmkWgqhnFFhZgYzvdRgu6cPUWxRTGJ4y2+WmW0GIuZLkUJR6EDfcNGF8dIYXRJuwu6kf183yMbucXq/NFhsNApzCzg78Bz0gPeqztg3EeS+Jwd3xk+rVNT6FrJdPIw6dZydNClUIA+Y/9KnFiDsKaugfl7oPrSE8qCYLKHkQhH41bQYU2e9xMj66XH+x/8GIq8fCfQ8lN10daoX1jt6fotp/f7VRTjX5RzBnuu2ae0ZdcH8wLlp7eOz7cUfPYIfnGrQEEuIdXjOrPkWERMuDGHEV8dEauJlSqVN5geTQ4ourDLNSRrEAH0Ea0d+4irTunssk2DgvNoRJSR1p1E3kI06XugISIIcdWKO2fZAeoipbt7hkjaEs2daxqVLJVM59MhvlARoOnyAfMEFEGbFiN5r0qaq8/jHaTGI8tm1/3LmdDtaSaG8FXfwzWQCjLMYoVwb2UvTbGX8f0MdZzXFpMA4I7DkKzu61QDZF0+OkRFRiJuaX0rC/QfGt33VfnC0IxXcRy6XL38fieKRB9W8i2NS8g5GhhRbpbag= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 31:N+R+YTsh1Ad6pl8Mh2NzzS3hRSHwWp/tx+Q8Khs0TbVzNqrM8ryt0uNJEwfqxV0F9z1OJA/iP81KPla+7o6f0RETZH6jkfiszFomWoIVXpgd//XubZDb55xmL0iJXk+cTRoOIWV4spzjeEGwtDyzM8BMEAVDwJfDEXf8KZxswgScpmbPI9GM1dY/kjvD1r/S8SQlrkuN1jN51nHqZAzP+IysRK/XD8OI3x/7A5jVc2F1N7a9RnPqV0J1KrUPkRf0L4MxtBUFq2LZo6TBEGL70MesIRY+07HvuBJWM5VLPP0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13017025)(13015025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:DM5PR03MB2473; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2473; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 4:ovUHjRfqXATSZ/huZNjfdyPC2BWL9U4RJGnrus67VPwFW/iEpTpeMNwTOK1C2mSIhfHeEad972WpV7cPV6SoZtOZfAO+o9F2djUHDaspoTJ0W03sNyOojYSwOOX3G+QmF+xjpC4/YbX1k85hdK6aTYFBBJwGirAtVaiMSi8MDjMQoUrxm4EF7l9G70XeFvd746VzRIj2kTec98NXXejJMfGnjRLQhWHVqoSIo9g1lFg+w4JkZNFkmDmlba+iOGTb6BWxhgg2YXFB+pkqnnaStkeDuGZzuNtFofHZyjVcn9TZz5KGPaj+uRMYvticD1S3rLtpAzrVqWASA+FgXkqlx4COTFWm4ZG8WYxKtea9pvz/KXbe0xe5dP4tRGxUdbVa+Bn4Yirw3IQkimhNxAFyUqpGV2O6xtazswRr4M2Ufl/71TpYfbH5fFtl2w2dnMVqB4I8C0xr7jofIMDG0NeqO22Op009heAqs2AfWqXDYn+ZjKjikGDEnpEwssV+6JbCFxIp9MKfEXDCCDzFMC9/d3p6C5WrOqp435yyD8J1evpuFWM8vPLYYFNf1gro/NYS8W4BTEtaPxWCdEHIPA7Ye1ZvA89003E3gihz7hLLcXQf2uulfG/3WkVBMDOalZlMIks6ISuJu965TjeAcHywwwt06hfUSj2NIE+Hvtbhcg/fd/5rYCWGtwktTojO0Op/D6782TrZXaBBfF0qENdi6A== X-Forefront-PRVS: 0182DBBB05 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2473; 23:nOdoGIV5oiYAlKw34k+sNiUl15mibpVWPFWht?= =?Windows-1252?Q?DDvV0yu7070UWS/aAFSU+C7udIdW3AgtK/JDFyhcwi3Ldbyf3NIKUCZ/?= =?Windows-1252?Q?FHA5EVlSKSj+ma5EYwbLM6J4Spw8RFQOoLhuhQm+pSW7k9gyWXYWehK2?= =?Windows-1252?Q?6HIFOvQnZkmI39qvgphL4IFXA+bZ/lqaSWXWqFZdlJueUp5AQPsMecKu?= =?Windows-1252?Q?H3f3dGMNPSlHHHLTF1NF4KXmpO2x7HzDbOXlsklbiFBgubptmZTfIZWn?= =?Windows-1252?Q?jakrlX620htaE4oJ1PGYRb8zFt8Vx1ZdyIIK7Nwe1HmTgmSUAbWIPWXx?= =?Windows-1252?Q?/P5vsHCEGIq/9IIwkc0NyYTQFJauYz1osIEHeYVLYCMZaOm0e+W9VGqB?= =?Windows-1252?Q?wzTCd4S8EUSUeamXgmTmGUACduMAdi5KjNfKJmzPZ17PuYuPIqiVe0fL?= =?Windows-1252?Q?7KjARCmhIzPaBNw3f+Gdeg3aYLw7Fn1HLRDsUjmjZOPhkGiRR9vr+DRO?= =?Windows-1252?Q?PPegLpris3wzU/dOhvi0wTAUEMLPfqcFQpCo7LqIIapsY0Gk+kq2O3vL?= =?Windows-1252?Q?e9iYoB+J3BQeeZvFSvBycZ1OtqVj4Jd6oAcvhEZ+c3xqVtkJYH/t7aBR?= =?Windows-1252?Q?o03tvN+Mn8yiXTy0xcgRDWD7f+65CmmkpC/z3QEhLJ+wnWtBTLltBZxD?= =?Windows-1252?Q?EOAL/r1+CWvp8K7ROIfSSscO+p02qGa2uCVwjeq+V2/Vs6KU5t7jJX4z?= =?Windows-1252?Q?E74Sajim0qJUF4wRHENY1JuvAN5Gg4HTlXUvLm3MBCRvxGEjxn9mkxzU?= =?Windows-1252?Q?aXHw46P+sEpqjqsuq/t26XdetFWKrB/aybODoNMOiMWaRZaALaBg8Kdb?= =?Windows-1252?Q?yHTkJH/cE/2TYib930j1MQLkLF20dGAPTbZqi9kIF1bNb/tJIbPGjJDu?= =?Windows-1252?Q?kMe28b0SfSVVHltmQl3Ph2GMWSIzl4+GrRtHL6dv/tOqiAOUxOYjNrPh?= =?Windows-1252?Q?DsEPsmYojfJha/9nC+kgNffvmVuoa5jTkk/2ALTJGjBryHgt8B/U13iF?= =?Windows-1252?Q?KBnJxxE9KZwsG1OjIzHJiwlNnhsDCJxX0qMGt1dZeUfoD4YSFn1mlrDy?= =?Windows-1252?Q?MCuYXj231GpJtSL9YLicVVUO372Q5LLDkMeTehBwpKHl17tnTqpZoP6v?= =?Windows-1252?Q?YTsApG613oW5SkhpKuTdRf6vXXIue1y+LVnLPJ5kWjoPwoB5rO9yyTZy?= =?Windows-1252?Q?50SjsR81cLu2wJcAm2CB2yj5/EkaNjaT9ZB4HTgOIVj7DHaw9y3GXJDm?= =?Windows-1252?Q?2siLssOGiwzYdvByaZGIlji2D0vlc2TMFRJ8HQYWN6aVYE4BJRxRcwZi?= =?Windows-1252?Q?XPP4gXsM+MXC8mLBtTtPaW0N7UNyy8/RjOSQOvTcipuYJZdyga0Ei6FD?= =?Windows-1252?Q?xaBUJIZJNnBVSunww834og6rlW0RmWHHXMA+3drRVnNp+cAysicmZl3i?= =?Windows-1252?Q?idVCKDF0BLfiAELqVVijkMRgupHJQH6RiiLkeX0hhhb+xwk4LlwBUYog?= =?Windows-1252?Q?bJ/oTXTUXLK8HPKJazmwrju+QSEgDm8ZDqAS+SZyWUIo0g3rXXSSsSgY?= =?Windows-1252?Q?KK5L7s1nL9gJn3/yCeDOJHZ/otaJQlcfkzk6iq5B7A5WMeP/j9DiiKVd?= =?Windows-1252?Q?dsaIXcear0LhKCcACeqIcPHNg1TnaDMsJRXWXDbQLWG0XMTMKgt?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 6:9wO8ZektkpAZV5fHiLOQIHR6O151OVbepbPPBejY40aqvcos2/DpqZRNRt7ruSwjJ7sjv9mXlkm4fg8OTaejs4IxIy4mOQzdbF1WLXgiR4V+L2kI3IyackCHG6a7vqAC0MtMsaZg4uK5n1VbGGFkxlinJjiAUi8UR5Cq0Ly0zgMDzat1KxutRcAvOwvI5fi+eLBEj1NT06tWi8kBjRfu0nrsYveS+J0ok3H6VglUg1VZ5KuvCjFqHHczuiBD0V1DbNgOwBAMAyAiG5IcdRq6jipnK5gvcTWxJ2Y/JiJ5eCMp2q9SMmCJnnRoXxkPJOVnKXlCJFoFs3oViHWgB0/o40/ODkga4LvvrpO2c5xcGoLm6UIs+gefAMhkQYz62c8vCR64U+N4t5ydRMaTrdLCFbpymJkUORaDAkUbjCoZfytxTmcXWJxN52YiIrdDGdqj; 5:pAd8Pjdkg2wmFqXyT1Wio9BrsANyVFt5ROkRJvjeVHIhhFDm8u1BiEKumifOhXXsGRh/zPKPuwbG8F+7wC3QlkrS6ECTX1G00dzQVoY3k6G7+tO/jqpazt+Y1LzadyliFRnanCRvMUdpBkZKD/TzrD9VkDx44kvyvJO5o3eBLWVB+PBhGNOn1Q0LiL+2oUVO; 24:1GqwwprUKXHhHhbgt/Vej/+FbXz4uuvDSD4Pss4usApY50z66LxDUdvfXy7thCLMDS7lR1EqRqEteqKnthnTxsD3L6Re+Lpjp0249zpaA8s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2473; 7:lfHthbBau+l6v6zmWhihcN+xVyX1Sj0CkMIihXeSVXw1+kJbjpdUHymHPqczGhYo/VPGBDvm3kBDeq16oS5CWMFavuXuXCmwKKiYOMDXtUJoG18GVBwkU9DE3xiyVhg8sVl9PPYpDjggR0TTGDqptGRLVwiSCxxAlON89qLqKLmipa2tpqQnqzjnBd6vtodrCi+K9MTaoFSGjfBnjj2t1ehcqpybGSxtA+fXrKibt5MCTVbh0W6LhqnRwmv2Wv8Bcvef0ZEma1vivG/zWV0T9NOfb7BMnee5D9a9PtiBEA/iMNUKFzOkuhVw1C9FnrsN1C+fht0hnh3dfbK8PhNPGP8v4C9DkHi/m0EyAGMvHMtF37cHfZ+TBTdQh+tAHvn13YC9vSY3la1voZtJRTvWGDNQBIlGOKnym2K7zj6agJ8FB+XsO1SKdUPSIax3WTyyxKxa9izYQZLAR3k+HTY/ZQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 06:31:03.4067 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2473 Subject: Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 06:31:06 -0000 Hello, On Sunday 08 January 2017 05:51 PM, Rosen, Rami wrote: > Hi, > .... > .... > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 2206277..2c223de 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > .... > > +/* Scan all the buses for registering devices */ int > +rte_eal_bus_scan(void) > +{ > + int ret; > + struct rte_bus *bus = NULL; > + > + TAILQ_FOREACH(bus, &rte_bus_list, next) { > + ret = bus->scan(bus); > + if (ret) { > + RTE_LOG(ERR, EAL, "Scan for (%s) bus failed.\n", > + bus->name); > + /* TODO: Should error on a particular bus block scan > + * for all others? > + */ > + return ret; > + } > + } > + > + return 0; > +} > + > > Nitpick - the return type of rte_eal_bus_scan() is int and not void: Thanks for review. I will fix this before sending v6. > > * Scan all the buses attached to the framework. > + * > + * @param void > + * @return void > + */ > +int rte_eal_bus_scan(void); > > > Rami Rosen > - Shreyansh