From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 01B81237 for ; Mon, 11 Sep 2017 18:12:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 09:12:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,378,1500966000"; d="scan'208";a="899165824" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2017 09:12:16 -0700 To: Adrien Mazarguil , Matan Azrad Cc: Nelio Laranjeiro , dev@dpdk.org References: <1504710238-25726-1-git-send-email-matan@mellanox.com> <20170906151414.GY4301@6wind.com> From: Ferruh Yigit Message-ID: Date: Mon, 11 Sep 2017 17:12:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170906151414.GY4301@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 16:12:22 -0000 On 9/6/2017 4:14 PM, Adrien Mazarguil wrote: > On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: >> Link status is sometimes inconsistent during a LSC event. >> When it occurs, the PMD refrains from immediately notifying >> the application; instead, an alarm is scheduled to check >> link status later and notify the application once it has settled. >> >> In the previous code the alarm callback calls to the interrupt >> handler for link status recheck and may cause to unnecessary >> interrupt events check. >> >> This patch separates the link status update and the interrupt event >> handler to avoid the unnecessary check and arranges the interrupt >> handler for more interrupt supports in the future. >> >> Comment was added in the new function to explain the inconsistent >> link status reason. >> >> Signed-off-by: Matan Azrad > > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.