From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3FD4F7CDA for ; Tue, 25 Sep 2018 13:34:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 04:34:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="89153802" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 04:33:21 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20180922045559.27438-1-ajit.khaparde@broadcom.com> <20180922045559.27438-10-ajit.khaparde@broadcom.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Tue, 25 Sep 2018 12:33:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180922045559.27438-10-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 09/12] net/bnxt: set MAC filtering as outer for non tunnel frames X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 11:34:39 -0000 On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > We need to set HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST bit in > L2_FILTER_ALLOC for filtering non-tunnel packets based on outermost MAC. What happens if that bit is not set, filtering is not working as expected? If so can you please convert this patch to a fix patch? > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 51fe3a4c2..b605659ed 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -383,6 +383,8 @@ int bnxt_hwrm_set_l2_filter(struct bnxt *bp, > HWRM_PREP(req, CFA_L2_FILTER_ALLOC, BNXT_USE_CHIMP_MB); > > req.flags = rte_cpu_to_le_32(filter->flags); > + req.flags |= > + rte_cpu_to_le_32(HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST); > > enables = filter->enables | > HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_DST_ID; >