From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 48E6CA0A0C;
	Thu, 22 Jul 2021 22:24:20 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D17A94014D;
	Thu, 22 Jul 2021 22:24:19 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mails.dpdk.org (Postfix) with ESMTP id CC73D40040
 for <dev@dpdk.org>; Thu, 22 Jul 2021 22:24:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1626985458;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=Dd/mvlyNjQKxMEPPwcpEG60UCE6YV3r06VOqGNPMrxw=;
 b=fSEydgwrJC+9j8daYIwW+NAo7+p/OpTYIgaIUu8xyfKH2dRLTBJsuixn5usnWmZODS8v6T
 M7o+J8DZKRc+Br9z8oY/w4TQ7YKY4H5QO7kV4E6qq7DJeHH1QSCjUys9DyS/R0FQgVtvi5
 67QwiwdOOdyW2Up4HX5ZZheOQoolEHo=
Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com
 [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-187-stinv4IXND2Ipii2-6J-KA-1; Thu, 22 Jul 2021 16:24:16 -0400
X-MC-Unique: stinv4IXND2Ipii2-6J-KA-1
Received: by mail-wr1-f71.google.com with SMTP id
 32-20020adf82a30000b029013b21c75294so2846476wrc.14
 for <dev@dpdk.org>; Thu, 22 Jul 2021 13:24:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:cc:references:from:subject:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=Dd/mvlyNjQKxMEPPwcpEG60UCE6YV3r06VOqGNPMrxw=;
 b=YTfBIizle7q/eXOUh2BdXAex7mRcI4RLRrILvCjquKFL0P3LgukBFJZvtDhGDRrDu/
 NKfS4gsPvSFsXLDmDaeLYzg3PXazK1pYScj904Ik35wio8YybrmD5K+eA5s4kW7T1y9c
 llWtcCwcjkY+XuukQF3gAxxhCFbu3l2bxErkqQI7VOCgyMXR+A+fK90VXbFRJVbPWKw5
 KCHupSp9LOvu+nhDwsRVUEoT4UfGivKbHM6ZS9ewcPnTJS6fESkMDwzxAY/Ejoi5Wjji
 9IvYlJ1R7gnGGQnX9Rug4ubzi07o+7EffbghFLGxYQgrupNTLlfs2POkuZvxkc25K4y/
 SYCQ==
X-Gm-Message-State: AOAM533sT+qAMT29KRWJXAqbbJ3L8eMjxSAJvisDsW5BSFP4Yr0OOAXZ
 IB6bS0hMoc5S1coR/mg+at5UX90Lz01Kp1pysCohSGajRfepGExFlbHEgkvYc76QMtIlDwZ4XX7
 Dt2c=
X-Received: by 2002:a05:600c:2187:: with SMTP id
 e7mr10902266wme.161.1626985455438; 
 Thu, 22 Jul 2021 13:24:15 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy48M8ydqbXimI4Vxqmb2csA92uEVfnPqkeZLTWm8kohbSXN7NvusxtBhGUDzrDXW956LP1EA==
X-Received: by 2002:a05:600c:2187:: with SMTP id
 e7mr10902253wme.161.1626985455254; 
 Thu, 22 Jul 2021 13:24:15 -0700 (PDT)
Received: from [192.168.0.36] ([78.17.79.77])
 by smtp.gmail.com with ESMTPSA id v21sm3349190wml.5.2021.07.22.13.24.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 22 Jul 2021 13:24:14 -0700 (PDT)
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, mdr@ashroe.eu
References: <20210709151938.701895-1-ktraynor@redhat.com>
 <2185865.z788A1Ek0O@thomas>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <df52310e-add0-4d15-1703-9ebce21eca9a@redhat.com>
Date: Thu, 22 Jul 2021 21:24:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <2185865.z788A1Ek0O@thomas>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to
 match API description
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 22/07/2021 20:46, Thomas Monjalon wrote:
> 09/07/2021 17:19, Kevin Traynor:
>> rte_stats_bitrate_reg() API states it returns 'Zero on success'.
>>
>> However, the implementation directly returns the return of
>> rte_metrics_reg_names() which may be zero or positive on success,
>> with a positive value also indicating the index.
>>
>> The user of rte_stats_bitrate_reg() should not care about the
>> index as it is stored in the opaque rte_stats_bitrates struct.
>>
>> Change the implementation of rte_stats_bitrate_reg() to match
>> the API description by always returning zero on success.
>>
>> Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> Does it require a deprecation notice?

I'm not certain, but I don't think it does. It is fixing the
implementation so it behaves as the API is documented to.

> At least I suggest a release note in API section.
> 
> What is the target for this series? 21.11?
> 

No urgency, 21.11 is fine for this set.

> 
>