From: Luca Boccassi <bluca@debian.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] autotest: fix for pure python3 environments
Date: Thu, 07 May 2020 10:36:35 +0100 [thread overview]
Message-ID: <df617e07851d13d5bd8dc0c00e6fc115d5f4a493.camel@debian.org> (raw)
In-Reply-To: <20200507072629.2374881-1-christian.ehrhardt@canonical.com>
On Thu, 2020-05-07 at 09:26 +0200, Christian Ehrhardt wrote:
> Without this fix in a pure python3 environment this will run into
> issues like:
> ModuleNotFoundError: No module named 'StringIO'
> or later string encoding issues on check_output.
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> app/test/autotest_runner.py | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
Note that this makes the file python3-only (as far as I can see) - I
think it's fine at this point, given python2 is EOL?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-05-07 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 7:26 Christian Ehrhardt
2020-05-07 9:36 ` Luca Boccassi [this message]
2020-05-07 11:25 ` Bruce Richardson
2020-06-04 14:43 ` Christian Ehrhardt
2020-06-04 16:22 ` Bruce Richardson
2020-05-07 9:43 ` Robin Jarry
2020-06-04 16:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df617e07851d13d5bd8dc0c00e6fc115d5f4a493.camel@debian.org \
--to=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).