From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A609A0508; Mon, 9 May 2022 02:49:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E522B4068F; Mon, 9 May 2022 02:49:43 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A145640395 for ; Mon, 9 May 2022 02:49:41 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KxMv02rSLzGpdZ; Mon, 9 May 2022 08:46:52 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 9 May 2022 08:49:38 +0800 Subject: Re: [PATCH v2 1/2] config/arm: add SVE ACLE control flag To: Rahul Bhansali , , Jan Viktorin , Ruifeng Wang , Bruce Richardson CC: References: <20220505142744.1423344-1-rbhansali@marvell.com> <20220507093943.2065586-1-rbhansali@marvell.com> From: fengchengwen Message-ID: Date: Mon, 9 May 2022 08:49:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20220507093943.2065586-1-rbhansali@marvell.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022/5/7 17:39, Rahul Bhansali wrote: > This add the control flag for SVE ACLE to enable or disable > RTE_HAS_SVE_ACLE macro in the build. > > Signed-off-by: Rahul Bhansali > --- > Changes in v2: > - Renamed the flag to sve_acle from sve > - Added double-indent. > > config/arm/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 8aead74086..2e12b541ef 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -603,7 +603,8 @@ if (cc.get_define('__ARM_NEON', args: machine_args) != '' or > compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] > endif > > -if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' > +if (cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' and > + soc_config.get('sve_acle', true)) > compile_time_cpuflags += ['RTE_CPUFLAG_SVE'] > if (cc.check_header('arm_sve.h')) the above sve_acle also impact RTE_CPUFLAG_SVE which don't mentioned in commit log. suggest add soc_config.get('sve_acle', true) in above if statement. > dpdk_conf.set('RTE_HAS_SVE_ACLE', 1) > -- > 2.25.1 > > > . >