From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85AD6A04B5; Fri, 6 Nov 2020 13:39:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4556697A; Fri, 6 Nov 2020 13:39:18 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E56156947 for ; Fri, 6 Nov 2020 13:39:16 +0100 (CET) IronPort-SDR: n847uNyeFWBlq50hsKNNbhC2D3Uh4nMZ8yQBMcqUWn3U2AHu7G5Y5ZiqPeaDPOctei45+S9Na8 rQGmS6FaYCPg== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="169687781" X-IronPort-AV: E=Sophos;i="5.77,456,1596524400"; d="scan'208";a="169687781" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 04:39:14 -0800 IronPort-SDR: 7Z8+RL7YM14ZVS+Bmmya5aVJaXPdXHROfhSpelvN8sLMZZpDmBnOuETFsFfr9OP0O4NVYZShuV DR4j9OsmpQFg== X-IronPort-AV: E=Sophos;i="5.77,456,1596524400"; d="scan'208";a="539826965" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.228.45]) ([10.213.228.45]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 04:39:13 -0800 To: Jiawen Wu , dev@dpdk.org References: <20201106021053.2015777-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Cc: Thomas Monjalon Message-ID: Date: Fri, 6 Nov 2020 12:39:10 +0000 MIME-Version: 1.0 In-Reply-To: <20201106021053.2015777-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove warning functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/6/2020 2:10 AM, Jiawen Wu wrote: > Remove rte_panic(), and use rte_atomic_thread_fence() > instead of rte_smp_[r/w]mb. > > Signed-off-by: Jiawen Wu Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. The remaining fix is : Using compiler attribute directly I can see two instances are used: 1) drivers/net/txgbe/base/txgbe_dummy.h 10:#define TUP(x) x##_unused __attribute__((unused)) 2) drivers/net/txgbe/base/txgbe_osdep.h 152:#define __rte_weak __attribute__((__weak__)) I think 2) simple can be removed completely, since it is not used at all. For 1) can it be moved to osdep.h? like: #define TUP(x) x##_unused txgbe_unused txgbe_osdep.h: #define txgbe_unused __rte_unused