From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBB92A054F; Tue, 7 Jun 2022 18:20:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A92F14021D; Tue, 7 Jun 2022 18:20:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A147440156 for ; Tue, 7 Jun 2022 18:20:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654618846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z0Z7eGGWfpeAiBJRYZovWggweSVQYhurrjlStkVFAUI=; b=DSTzJhH1VrLU+bmvIoUQUv+AxDHS2kr1Jg1ofbNewits/0R28pQB1KpAmFMW88FcvFarEQ ngc5GxXTaGjYYkxdMSCv71QriJJPvADhBaDsYylHOXVOVI2AujBpDjvr/V4ZhuyRyQBOJU GgarzP5QwGjGN2gBX6ikVdj02NZyn1A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-393-hwwP8hGfPoiVGdKYFmyC2g-1; Tue, 07 Jun 2022 12:20:43 -0400 X-MC-Unique: hwwP8hGfPoiVGdKYFmyC2g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91D0D801756; Tue, 7 Jun 2022 16:20:42 +0000 (UTC) Received: from [10.39.208.20] (unknown [10.39.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C60E1415100; Tue, 7 Jun 2022 16:20:40 +0000 (UTC) Message-ID: Date: Tue, 7 Jun 2022 18:20:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1] bbdev: add device status info To: "Chautru, Nicolas" , Stephen Hemminger Cc: "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" References: <1654555808-218770-1-git-send-email-nicolas.chautru@intel.com> <1654555808-218770-2-git-send-email-nicolas.chautru@intel.com> <20220606170906.6265c598@hermes.local> <9f995dde-738e-6c56-c4ef-41c9ad0f4926@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, On 6/7/22 17:44, Chautru, Nicolas wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Tuesday, June 7, 2022 5:43 AM >> To: Stephen Hemminger ; Chautru, Nicolas >> >> Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; >> hemant.agrawal@nxp.com; Vargas, Hernan >> Subject: Re: [PATCH v1] bbdev: add device status info >> >> Hi Stephen, >> >> On 6/7/22 02:09, Stephen Hemminger wrote: >>> On Mon, 6 Jun 2022 15:50:08 -0700 >>> Nicolas Chautru wrote: >>> >>>> @@ -298,6 +313,8 @@ struct rte_bbdev_driver_info { >>>> const struct rte_bbdev_op_cap *capabilities; >>>> /** Device cpu_flag requirements */ >>>> const enum rte_cpu_flag_t *cpu_flag_reqs; >>>> + /** Device Status */ >>>> + enum rte_bbdev_device_status device_status; >>>> }; >>>> >>> >>> This ends up being an ABI breakage, can't change a struct like that >>> until 22.11 release. >>> >> >> Indeed, but Nicolas mentioned in the cover-letter that the patch targets >> v22.11; not this release. >> >> However, a deprecation notice should be sent for v22.07 if it hasn't been >> done yet. > > I have sent this deprecation Maxime: > https://patches.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-send-email-nicolas.chautru@intel.com/ > Do you believe this needs to be extended to cover more details the change and including this device status info explicitly? I can update the verbiage in more details if required Thanks for the pointer, I missed it. Reading the deprecation notice, it is not clear to me it is about the device status info enum. Maybe rewording it a bit to be more specific would help. Thanks, Maxime > >> >> Maxime >