From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: Trevor Tao <taozj888@163.com>, dev@dpdk.org
Subject: Re: [PATCH v2 1/3] examples/l3fwd: relax RSS requirement with option
Date: Tue, 17 Oct 2023 19:06:03 +0100 [thread overview]
Message-ID: <dfb9a97e-4b11-4056-804a-09f1282863b6@yandex.ru> (raw)
In-Reply-To: <20231013042722.429592-2-taozj888@163.com>
13.10.2023 05:27, Trevor Tao пишет:
> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS
> by default, but some hw and/or virtual interface does not
> support the RSS and offload mode presupposed, e.g., some
> virtio interfaces in the cloud don't support
> RSS and the error msg may like:
>
> virtio_dev_configure(): RSS support requested but not supported by
> the device
> Port0 dev_configure = -95
>
> So to enable the l3fwd running in that environment, the Rx mode requirement
> can be relaxed to reflect the hardware feature reality here, and the l3fwd
> can run smoothly then.
>
> An option named "relax-rx-mode" is added to enable the relax action
> here, and it's disabled by default.
>
> Signed-off-by: Trevor Tao <taozj888@163.com>
> ---
> examples/l3fwd/main.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index 6063eb1399..89ad546a5e 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -73,6 +73,7 @@ static enum L3FWD_LOOKUP_MODE lookup_mode;
> static int numa_on = 1; /**< NUMA is enabled by default. */
> static int parse_ptype; /**< Parse packet type using rx callback, and */
> /**< disabled by default */
> +static int relax_rx_mode; /**< Relax RX mode is disabled by default */
> static int per_port_pool; /**< Use separate buffer pools per port; disabled */
> /**< by default */
>
> @@ -678,6 +679,7 @@ static const char short_options[] =
> #define CMD_LINE_OPT_MAX_PKT_LEN "max-pkt-len"
> #define CMD_LINE_OPT_HASH_ENTRY_NUM "hash-entry-num"
> #define CMD_LINE_OPT_PARSE_PTYPE "parse-ptype"
> +#define CMD_LINE_OPT_RELAX_RX_MODE "relax-rx-mode"
> #define CMD_LINE_OPT_PER_PORT_POOL "per-port-pool"
> #define CMD_LINE_OPT_MODE "mode"
> #define CMD_LINE_OPT_EVENTQ_SYNC "eventq-sched"
> @@ -705,6 +707,7 @@ enum {
> CMD_LINE_OPT_MAX_PKT_LEN_NUM,
> CMD_LINE_OPT_HASH_ENTRY_NUM_NUM,
> CMD_LINE_OPT_PARSE_PTYPE_NUM,
> + CMD_LINE_OPT_RELAX_RX_MODE_NUM,
> CMD_LINE_OPT_RULE_IPV4_NUM,
> CMD_LINE_OPT_RULE_IPV6_NUM,
> CMD_LINE_OPT_ALG_NUM,
> @@ -728,6 +731,7 @@ static const struct option lgopts[] = {
> {CMD_LINE_OPT_MAX_PKT_LEN, 1, 0, CMD_LINE_OPT_MAX_PKT_LEN_NUM},
> {CMD_LINE_OPT_HASH_ENTRY_NUM, 1, 0, CMD_LINE_OPT_HASH_ENTRY_NUM_NUM},
> {CMD_LINE_OPT_PARSE_PTYPE, 0, 0, CMD_LINE_OPT_PARSE_PTYPE_NUM},
> + {CMD_LINE_OPT_RELAX_RX_MODE, 0, 0, CMD_LINE_OPT_RELAX_RX_MODE_NUM},
> {CMD_LINE_OPT_PER_PORT_POOL, 0, 0, CMD_LINE_OPT_PARSE_PER_PORT_POOL},
> {CMD_LINE_OPT_MODE, 1, 0, CMD_LINE_OPT_MODE_NUM},
> {CMD_LINE_OPT_EVENTQ_SYNC, 1, 0, CMD_LINE_OPT_EVENTQ_SYNC_NUM},
> @@ -853,6 +857,11 @@ parse_args(int argc, char **argv)
> parse_ptype = 1;
> break;
>
> + case CMD_LINE_OPT_RELAX_RX_MODE_NUM:
> + printf("Relax rx mode is enabled\n");
> + relax_rx_mode = 1;
> + break;
> +
> case CMD_LINE_OPT_PARSE_PER_PORT_POOL:
> printf("per port buffer pool is enabled\n");
> per_port_pool = 1;
> @@ -1260,6 +1269,13 @@ l3fwd_poll_resource_setup(void)
> if (dev_info.max_rx_queues == 1)
> local_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
>
> + /* relax the rx rss requirement */
> + if (relax_rx_mode && !local_port_conf.rx_adv_conf.rss_conf.rss_hf) {
> + printf("warning: modified the rx mq_mode to RTE_ETH_MQ_RX_NONE base on"
> + " device capability\n");
> + local_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
> + }
> +
> if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=
> port_conf.rx_adv_conf.rss_conf.rss_hf) {
> printf("Port %u modified RSS hash function based on hardware support,"
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
next prev parent reply other threads:[~2023-10-17 18:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 4:27 [PATCH v2 0/3] example/l3fwd: relax l3fwd rx RSS/Offload if needed Trevor Tao
2023-10-13 4:27 ` [PATCH v2 1/3] examples/l3fwd: relax RSS requirement with option Trevor Tao
2023-10-17 18:06 ` Konstantin Ananyev [this message]
2023-10-13 4:27 ` [PATCH v2 2/3] examples/l3fwd: relax the Offload requirement Trevor Tao
2023-10-17 18:13 ` Konstantin Ananyev
2023-10-13 4:27 ` [PATCH v2 3/3] doc: add a relax rx mode requirement option Trevor Tao
2023-10-31 20:08 ` Stephen Hemminger
2023-10-13 7:07 ` [PATCH v2 0/3] example/l3fwd: relax l3fwd rx RSS/Offload if needed David Marchand
2023-10-15 14:06 ` taozj888
-- strict thread matches above, loose matches on Subject: below --
2023-10-13 3:27 Trevor Tao
2023-10-13 3:27 ` [PATCH v2 1/3] examples/l3fwd: relax RSS requirement with option Trevor Tao
2023-10-13 3:08 [PATCH v2 0/3] example/l3fwd: relax l3fwd rx RSS/Offload if needed Trevor Tao
2023-10-13 3:08 ` [PATCH v2 1/3] examples/l3fwd: relax RSS requirement with option Trevor Tao
2023-10-12 16:03 Trevor Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb9a97e-4b11-4056-804a-09f1282863b6@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=dev@dpdk.org \
--cc=taozj888@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).