From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A7333A0542;
	Sat, 24 Sep 2022 10:03:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8AACE4021F;
	Sat, 24 Sep 2022 10:03:05 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 1C2C7400D4
 for <dev@dpdk.org>; Sat, 24 Sep 2022 10:03:04 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.56])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MZLxk5D03zlXPk;
 Sat, 24 Sep 2022 15:58:50 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Sat, 24 Sep 2022 16:03:01 +0800
Subject: Re: [PATCH v3 2/7] app/procinfo: add firmware version dump
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "thomas@monjalon.net" <thomas@monjalon.net>, "ferruh.yigit@xilinx.com"
 <ferruh.yigit@xilinx.com>, "andrew.rybchenko@oktetlabs.ru"
 <andrew.rybchenko@oktetlabs.ru>
References: <20220722091236.15469-1-liudongdong3@huawei.com>
 <20220921142655.16427-1-liudongdong3@huawei.com>
 <20220921142655.16427-3-liudongdong3@huawei.com>
 <BYAPR11MB33669CB027166EA8C693D950FF519@BYAPR11MB3366.namprd11.prod.outlook.com>
CC: Min Hu <humin29@huawei.com>, Maryam Tahhan <maryam.tahhan@intel.com>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <dfd45390-fdce-5ad1-3b04-b021828aeba7@huawei.com>
Date: Sat, 24 Sep 2022 16:03:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <BYAPR11MB33669CB027166EA8C693D950FF519@BYAPR11MB3366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Reshma

Many thanks for your review.
On 2022/9/23 17:22, Pattan, Reshma wrote:
>
>
>> -----Original Message-----
>> From: Dongdong Liu <liudongdong3@huawei.com>
>> Subject: [PATCH v3 2/7] app/procinfo: add firmware version dump
>>
>> Add support for dump ethdev firmware version.
>>
>> The command is like:
>> dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- --firmware-version
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>
>> +		if (rte_eth_dev_fw_version_get(i, fw_version,
>> +					       ETHDEV_FWVERS_LEN) == 0)
>> +			printf("Ethdev port %u firmware version: %s\n", i,
>> +				fw_version);
>> +		else
>> +			printf("Ethdev port %u firmware version: %s\n", i,
>> +				"not available");
>
> Small question, do you want to show generic msg "Not available" ?  instead of different printing messages  based on what is returned from the " rte_eth_dev_fw_version_get" .
Tt is ok to show generic msg "Not available".

Thanks,
Dongdong
>
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
>
>
> .
>