From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAE7CA3295 for ; Wed, 23 Oct 2019 16:14:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C00D61C223; Wed, 23 Oct 2019 16:14:38 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 225811C20F for ; Wed, 23 Oct 2019 16:14:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 07:14:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="372887714" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga005.jf.intel.com with ESMTP; 23 Oct 2019 07:14:32 -0700 To: Olivier Matz , Kiran Kumar Kokkilagadda Cc: Raslan Darawsheh , Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" References: <20191021091617.11290-1-kirankumark@marvell.com> <20191022041648.4812-1-kirankumark@marvell.com> <8339b371-b0db-480c-426c-2f1cae244d3b@intel.com> <20191023113913.GK25286@glumotte.dev.6wind.com> <20191023140444.GN25286@glumotte.dev.6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Wed, 23 Oct 2019 15:14:32 +0100 MIME-Version: 1.0 In-Reply-To: <20191023140444.GN25286@glumotte.dev.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v10] ethdev: add HIGIG2 key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/23/2019 3:04 PM, Olivier Matz wrote: > On Wed, Oct 23, 2019 at 11:43:58AM +0000, Kiran Kumar Kokkilagadda wrote: >>> -----Original Message----- >>> From: Olivier Matz >>> Sent: Wednesday, October 23, 2019 5:09 PM >>> To: Raslan Darawsheh >>> Cc: Ferruh Yigit ; Kiran Kumar Kokkilagadda >>> ; Adrien Mazarguil >>> ; Wenzhuo Lu ; >>> Jingjing Wu ; Bernard Iremonger >>> ; John McNamara >>> ; Marko Kovacevic ; >>> Thomas Monjalon ; Andrew Rybchenko >>> ; dev@dpdk.org; ajit.khaparde@broadcom.com >>> Subject: [EXT] Re: [dpdk-dev] [PATCH v10] ethdev: add HIGIG2 key field to flow >>> API >>> >>> External Email >>> >>> ---------------------------------------------------------------------- >>> Hi, >>> >>> >>> >>> On Wed, Oct 23, 2019 at 10:50:52AM +0000, Raslan Darawsheh wrote: >>> >>>> Hi, >>> >>>> >>> >>>> This patch broke the compilation of MLX5 PMD in debug mode: >>> >>>> >>> >>>> from /root/dpdk/x86_64-native-linux- >>> gcc/include/rte_ethdev_driver.h:18, >>> >>>> from /root/dpdk/drivers/net/mlx5/mlx5_mp.c:11: >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:112:2: error: type of >>> bit-field 'opcode' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t opcode:3; >>> >>>> ^ >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:113:2: error: type of >>> bit-field 'resv1' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t resv1:2; >>> >>>> ^ >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:114:2: error: type of >>> bit-field 'src_t' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t src_t:1; >>> >>>> ^ >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:115:2: error: type of >>> bit-field 'pfm' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t pfm:2; >>> >>>> ^ >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:116:2: error: type of >>> bit-field 'resv2' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t resv2:5; >>> >>>> ^ >>> >>>> /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:117:2: error: type of >>> bit-field 'hdr_ext_len' is a GCC extension [-Werror=pedantic] >>> >>>> uint16_t hdr_ext_len:3; >>> >>>> >>> >>>> and this is with gcc 4.8.5 >>> >>> >>> >>> From https://urldefense.proofpoint.com/v2/url?u=https- >>> 3A__stackoverflow.com_questions_10906238_warning-2Dwhen-2Dusing- >>> 2Dbitfield-2Dwith-2Dunsigned- >>> 2Dchar&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=owEKckYY4FTmil1Z6oBUR >>> wkTThyuRbLAY9LdfiaT6HA&m=GZ- >>> 6cngPycaUlGJT20VEOf9oTcp5PMwk7j1JV1vAQfs&s=SCg5yVPS4zZa8GSn9bl_eUtI >>> vBmoDzi35PspWUttIUY&e= >>> >>> it seems that it is allowed in c99, so I guess it's a gcc 4.8 bug. >>> >>> >>> >>> Adding __extension__ above the struct solves the warnings, I suggest to >>> >>> add it. >> >> /** >> * >> * higig2 ppt type1 header. >> */ >> RTE_STD_C11 >> struct rte_higig2_ppt_type1 { >> uint16_t classification; >> uint16_t resv; >> uint16_t vid; >> #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN >> uint16_t opcode:3; >> uint16_t resv1:2; >> uint16_t src_t:1; >> uint16_t pfm:2; >> uint16_t resv2:5; >> uint16_t hdr_ext_len:3; >> #elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN >> uint16_t pfm:2; >> uint16_t src_t:1; >> uint16_t resv1:2; >> uint16_t opcode:3; >> uint16_t hdr_ext_len:3; >> uint16_t resv2:5; >> #endif >> }; >> >> I have already added it. RTE_STD_C11 , this is a macro for __extension__. >> /** C extension macro for environments lacking C11 features. */ >> #if !defined(__STDC_VERSION__) || __STDC_VERSION__ < 201112L >> #define RTE_STD_C11 __extension__ >> #else >> #define RTE_STD_C11 >> #endif > > The __extension__ is only added if compiled for < c11. > But there is apparently a problem with gcc-4.8: even in c11, it does > not support bitfields on u16. See: https://godbolt.org/z/hRIbgg > > On gcc-4.9, the problem disappeared: https://godbolt.org/z/kkzz9v > > So as a workaround, using __extension__ should work, probably with a short > explanation. > Thanks Olivier, this was also our finding with Raslan and he sent the fix already. https://patches.dpdk.org/patch/61748/ Also it looks like gcc4.8 thinks this is not c11 standard but extension only for uint16_t type, structs with uint32_t bit-fieds works as expected.