From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 49372DED for ; Fri, 26 Oct 2018 16:56:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 07:56:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="81143414" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.8.177]) ([10.252.8.177]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 07:56:24 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: Stephen Hemminger References: <20180725182019.31518-1-stephen@networkplumber.org> <20180725182019.31518-3-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: Date: Fri, 26 Oct 2018 15:56:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180725182019.31518-3-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 14:56:27 -0000 On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: > No need for profanity in comments. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnx2x/elink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c > index 34a29373af3b..08fe817720a1 100644 > --- a/drivers/net/bnx2x/elink.c > +++ b/drivers/net/bnx2x/elink.c > @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc, > PORT_HW_CFG_E3_MOD_ABS_MASK) >> > PORT_HW_CFG_E3_MOD_ABS_SHIFT; > > - /* Should not happen. This function called upon interrupt > + /* > + * Should not happen. This function called upon interrupt > * triggered by GPIO ( since EPIO can only generate interrupts > * to MCP). > * So if this function was called and none of the GPIOs was set, > - * it means the shit hit the fan. ...then what? :) > */ > if ((cfg_pin < PIN_CFG_GPIO0_P0) || > (cfg_pin > PIN_CFG_GPIO3_P1)) { > -- Thanks, Anatoly