DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com,
	yskoh@mellanox.com
Cc: dev@dpdk.org, stable@dpdk.org, Xueming Li <xuemingl@mellanox.com>
Subject: [dpdk-dev] [PATCH v2 5/6] net/mlx5: fix Memory Region cache last index
Date: Thu, 25 Jan 2018 18:18:02 +0200	[thread overview]
Message-ID: <dfe213846108b94890f3a4170aaf73835b469bce.1516896871.git.shahafs@mellanox.com> (raw)
In-Reply-To: <cover.1516896871.git.shahafs@mellanox.com>

In case Memory Region cache is full, the new mempool will be
inserted in the last index of the array.

Update the last entry being hit to reflect it.

Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search")
Cc: stable@dpdk.org
Cc: yskoh@mellanox.com

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index e6d163a59..7e7db0e8c 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -567,7 +567,6 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb)
 			return txq->mp2mr[i]->lkey;
 		}
 	}
-	txq->mr_cache_idx = 0;
 	mr = mlx5_txq_mp2mr_reg(txq, mlx5_tx_mb2mp(mb), i);
 	/*
 	 * Request the reference to use in this queue, the original one is
@@ -575,6 +574,7 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb)
 	 */
 	if (mr) {
 		rte_atomic32_inc(&mr->refcnt);
+		txq->mr_cache_idx = i >= RTE_DIM(txq->mp2mr) ? i - 1 : i;
 		return mr->lkey;
 	} else {
 		struct rte_mempool *mp = mlx5_tx_mb2mp(mb);
-- 
2.12.0

  parent reply	other threads:[~2018-01-25 16:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 17:08 [dpdk-dev] [PATCH 0/5] fix Memory region lookups Shahaf Shuler
2018-01-23 17:08 ` [dpdk-dev] [PATCH 1/5] net/mlx5: fix Memory Region cache lookup Shahaf Shuler
2018-01-23 17:08 ` [dpdk-dev] [PATCH 2/5] net/mlx5: fix secondary process mempool registration Shahaf Shuler
2018-01-24  8:14   ` Nélio Laranjeiro
2018-01-24 13:37     ` Shahaf Shuler
2018-01-23 17:08 ` [dpdk-dev] [PATCH 3/5] net/mlx5: assert for un-successful memory registration Shahaf Shuler
2018-01-24  8:15   ` Nélio Laranjeiro
2018-01-23 17:08 ` [dpdk-dev] [PATCH 4/5] net/mlx5: fix memory registration cache last index Shahaf Shuler
2018-01-23 17:08 ` [dpdk-dev] [PATCH 5/5] net/mlx5: fix Memory Region boundary checks Shahaf Shuler
2018-01-25 16:17 ` [dpdk-dev] [PATCH v2 0/6] fix Memory region lookups Shahaf Shuler
2018-01-25 16:17   ` [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix Memory Region cache lookup Shahaf Shuler
2018-01-25 16:17   ` [dpdk-dev] [PATCH v2 2/6] net/mlx5: fix secondary process mempool registration Shahaf Shuler
2018-01-25 16:18   ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: remove assert un-accessible from secondary process Shahaf Shuler
2018-01-25 16:18   ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: warn for un-successful memory registration Shahaf Shuler
2018-01-25 16:18   ` Shahaf Shuler [this message]
2018-01-25 16:18   ` [dpdk-dev] [PATCH v2 6/6] net/mlx5: fix Memory Region boundary checks Shahaf Shuler
2018-01-25 19:06     ` Yongseok Koh
2018-01-25 16:25   ` [dpdk-dev] [PATCH v2 0/6] fix Memory region lookups Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfe213846108b94890f3a4170aaf73835b469bce.1516896871.git.shahafs@mellanox.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=xuemingl@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).