From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E2AE43ACF; Sat, 10 Feb 2024 01:09:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99E7540297; Sat, 10 Feb 2024 01:09:34 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id A1C9A40150; Sat, 10 Feb 2024 01:09:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pv6JxTXLXxE7T3w0ZbRBm1z/IKRudSI1p3VExWczeGO7/+q4HI0uQQ7Z0a+YVChv68zAgiea1ovuw8edTLBm4DFIMW83i7EHedAJ9+SG4sJ35agEu/KUoM7z5hE6tbmvceoUi0PYiJmniOpRM7I5yyG17SlBr2P0JbD+sJX0Qc+1LA6U1+ChCisey4NEI7olvMZ5ug2aUmH49z1hQrb6LZhWLPprlsCme1dXsBTF6+xnC2WMH/hpZMf4F64Lf47ZsLvAclIH+SYus7nG+eetgkCeha+boc4hEwsDGTcuByJk0ptRb/94U72vlDmb4JvMpfQsdD2aEAtEDJE1m2+3lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KG9ayg6aAtCf/GQyZ4+Q9E04QuOvPDZn6lvDb15461g=; b=majWYSvXIGFlpGN8B01Amm1rjAnfywo1PslCSLee2+2jPyvX5+9w1XEaIxyucpMmY6e3uuyTInXhaHwyfWjqMPqbyKxWZjjr1C72DuG4sNkL/Nzrt+cLToRAPg+cFk3RapIq1jQL2dU32rfxm2IXhg2e7dFtBeqIBzd8S14Nx8owJfkOSKkROYK/fV3dFAN51SlGckmesyp1Dj6+WtbZ3pI4cGWmOZHS+dJS1beO62fY9d6M9iokMst3GsklDTvMhxttHzXrFlZR5yYkjtrWcwgnuu+pcY5cpBrA7rJfr0/Cahz/vq4LXNdzAEmycbDJMR+ZwmC48tVswV8hMJEVhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KG9ayg6aAtCf/GQyZ4+Q9E04QuOvPDZn6lvDb15461g=; b=mchhG0Xbdx7/2HGhQAK9wkE5IMWuqIrHTCEIUJuSbXS0u4FKwbwBDJEfqNaJGmPe6VqfUGfJX/TvStZ1GUiAxSt3psxLtymJy19zMtHxBjgBd6AUcquiO2e/WM5IKZf1is7HGng/LHThydq6WaSxDMlsrZrDIywL+aFIerjGcV8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB5636.namprd12.prod.outlook.com (2603:10b6:a03:42b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.16; Sat, 10 Feb 2024 00:09:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Sat, 10 Feb 2024 00:09:31 +0000 Message-ID: Date: Sat, 10 Feb 2024 00:09:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v2 1/2] net/mana: fix memory leak on MR variable allocation Content-Language: en-US To: longli@microsoft.com, Andrew Rybchenko Cc: dev@dpdk.org, stable@dpdk.org References: <1706577886-29483-2-git-send-email-longli@linuxonhyperv.com> <1707437104-23548-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1707437104-23548-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0086.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB5636:EE_ X-MS-Office365-Filtering-Correlation-Id: e367fdb7-1092-4b28-ded8-08dc29cc8dc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlEIrVDQFXE3yDZ8c0KBeFsEgaZ9a0KPaaThm82C/xdhSjpk0EZUGquiUlHDkF+ETGeKv5cPkSPni77ctiWaoT7e+G/ouP6FoCXIwwObEe5JmMjFZNsYWeYBEXCyGMOidAkNJFJ8EqzfpjZC2naZu13fZPJ8f9h+TqktMyS4eW9fBSER36KqBXf0S3QSyR0BWYy8SMbbN1lrkCMbF2Bkw9PLBSyuTz5tgg5p6cPsfSE3zg5xzVxonrBQLWFQ+CcIfXCUS2lQe2F0Zz5bsA9ELHwasl24sWWWpRxnRZfl7D2v9nnrdKls+0hAaDF0ZcBpHMTSuf20WbhhMCXWEMmaOEhazWi/yhqS1MtRpnC7hjbCMe7WOnOchbu7kksmDlQ5Oxb8pUgB0N2EQuWJb+8I1HHGktDUlgj+loo2G4zzgSCiBPbKRWCZhIrqZGFU4QqaiFy3UtExWycSwJzn2oHTUejE9oU2/AokQsoqLRBCGujte0Uc7iqTnzVpXW0NkSyGE1ANk4ogd4rSlgZOcixKRVnD8zvTO2Fo5hWHKWr1l2UYSrGuPLUMzKD4HqzIiNVz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(478600001)(2616005)(53546011)(6506007)(36756003)(6666004)(38100700002)(41300700001)(26005)(86362001)(6512007)(31696002)(6486002)(8676002)(4326008)(8936002)(44832011)(4744005)(5660300002)(2906002)(45080400002)(31686004)(66476007)(66946007)(316002)(66556008)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUNOWFc0bkZhRlZnNVRGWDVSeWdHQnJhbnhhWmNDSEswQi9VRVZxUkhLRnd0?= =?utf-8?B?dXpkbGJUUVRiazFNNnNpaVZKOExwZVRTblNyK2Rac012L3BrYk5pbGN4ZUpF?= =?utf-8?B?WjV1aUdPUFM0ZVpUV3A2STR1YlVyNTFFcloweXp5aTJwYlFiN3pJVFpQaXpv?= =?utf-8?B?ZTRrUGhjNHFXMHVOMm40UXB6Q3M5ZUM2d2ZKdjZzdDJUTGlldXdXNGkvMkE1?= =?utf-8?B?aUVIeU96bXBLalNGbEJNdHE0QVBPbDFiT2JSVnNlYlFhYTVmMWZLVlZmUGg2?= =?utf-8?B?dElITklHM3RCM0dFeElNRVIxRmkvTWxHTEZHd1ZaMVpISTJSbUZZcXRsZWlK?= =?utf-8?B?SVl6RjJrYUxOY2FCRmo5MExTekRIMEo5QTY4NE9GRHk1M2t1UVlvNDJlc3dL?= =?utf-8?B?Sis5azU1Q3cwdDgxVUdXV3RuU2lWNE5paDlJUTltekFRNTU4dWZwYTFacFJv?= =?utf-8?B?THpOK1ZSdTkyM1VmdHB4cUl2NVNKY2Y5djc1dUJ0UFdiRFQweHN0YndSdWtV?= =?utf-8?B?bzcwall4VlpzUkNyVzFNenhyL08yS2wyeXgwRHhiY3hLZ3ZacVUwdzJUOHcv?= =?utf-8?B?SG90RmJDcWErUjdHZ01yZ1FkSnJBZUVsaEVOYjc2T2VSUm5JZ3dPNDQ4WVVT?= =?utf-8?B?OTBsVWtrcjNJOW16Q0xMcEdaL0hyVXdQWFE1L2xnZWRhSHhpaFpHVDVTOUN0?= =?utf-8?B?ZCs5L0hKQ0RGRmVIN0JtbVJJblRZdjBoOWZ2V0R6RnN4SlBCeDJCNHZOR09u?= =?utf-8?B?NURyak45c0lnWm5vbXBJN1dGY1IyUE9Wc2tYTnNVdVphNDN4bFhtYURmSTEx?= =?utf-8?B?cmN3OWt6Slo0cDJlSnhvQmtPUVhMUXlYUE84NzN5bzh5MXlwWGJsU0RZaW14?= =?utf-8?B?SzkxWTdYa3lBb01RdFJpMzUwNEo3MmcwZVd1OThTQ3pnUno5REQ5VnZyTGsv?= =?utf-8?B?MmFxMEdIUktyYVJTZ1VCQjg2VklsUUkxSmJ4TjZrL2lORlM2aEN5dDZqTzdi?= =?utf-8?B?UHdtVTAwYUhVcFNLNTk0dWVUc3FnMGVHNk11RzBCaTJJaFJnWkluUW5tc2w4?= =?utf-8?B?dFM5cmg2cVNxbEU4enQybU5xSXNMNnBOQWVrZ3RaVW1VV21JZjl3R3ZYOWpS?= =?utf-8?B?MCtNa0xYMTI5NXliRW42L2FicEFFSWd1bXpST0hjYS80SFE3UlRpZVJyM1RC?= =?utf-8?B?VVRYZUlnQWIvWm5PSFpLOHNXWWhnbDN4M0V2bnI1b0d0OWlPRjhIYmw5djA0?= =?utf-8?B?U3BobERBSk1FTXZ4TzRZb2F4TEtiTGRqZTJ1TU1uZGhTVGpDNFplWW05Unhq?= =?utf-8?B?UGl3ZFBza3RMTjhVc0xnOUZ0dFA1clNEL096L2tsYWxiQk42SG9RcDZFNktQ?= =?utf-8?B?OGdYa0RUTTJKV09qcE5GNG01RWF0eFRtNi9DVFJWRCtwYXZ0WWoweGo1SmIx?= =?utf-8?B?dEk4R3lJWTNmQ2IzUjlLbnhib0FlcHJKOGREbnQ4QU1GN2w2UEsyd0p3MjJP?= =?utf-8?B?dVk1aXRxRUQ5QmZwbHdzb3VsWHpxVnZLZHJFb2lDeWY2eGgySFQxS0ZoWVpp?= =?utf-8?B?QWJWMFFoRmUxNzM1RFBTeGdRLy9kdlJCTmVzV1EyOFZhTWRLSmpKTkhlOUd3?= =?utf-8?B?a1RlMURxa3dKSmxxQXoyVWI5WFBTWDdSNGYwR2dVQmhDMVhVYWY5eFMzZ1lO?= =?utf-8?B?b1J4OUJnMy9vWHBudk1WOHFFZ3lzTWJabWlwOFd3WkNGMTNsNzBtRi93UGxr?= =?utf-8?B?UzFvOUZqRm9pVUhpWjA0RldqVFpZN1VvRVE1ZFRLZG5jQyt6UFJSMkJ6bmJP?= =?utf-8?B?aXZCa1d4K0NSelEzS2hUNVRGVUl4RHNEVE9XU0psOTE0dGdJZ1BUMXU1Z1BX?= =?utf-8?B?c3AxZ2RmR1dodVdoc0lkV0xxcXN3RVcyMzA5dHNiaHVBU1BrNnQ0NWhZMk05?= =?utf-8?B?U2ZUK1ZGSEtkc2ZNa0VnTTlGL2s0MUIvL1FKY05wRU1NamI2cTFOZEplUVpJ?= =?utf-8?B?aFh4bGdpRTBNNDlXcWJFZzhlOHROL05wemcwQWtNYlFCQTdmdjhVaXFpWmVu?= =?utf-8?B?VDRkNHRnb3lLMG9PTnhERDNZWU50K3Z0YU11VGc2bW1LMEZFYnFCdTNoOGpV?= =?utf-8?Q?Km987vILWcJAPy8VbyC0eWrDH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e367fdb7-1092-4b28-ded8-08dc29cc8dc0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2024 00:09:31.0316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WQxKdQjYkHynQyNchbx2V9X5jW7pvjImJvmY6EPmzZUNJd86rVr9mdlvYCGJzSBU X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5636 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2024 12:05 AM, longli@linuxonhyperv.com wrote: > From: Long Li > > Use a MR on the stack instead of allocating it. This fixes the memory > leak in the code where a MR is allocated but never freed. > > Fixes: 0f5db3c68ba7 ("net/mana: implement memory registration") > Cc: stable@dpdk.org > > Signed-off-by: Long Li > Series applied to dpdk-next-net/main, thanks.