From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 101C5A04F2; Fri, 6 Dec 2019 14:18:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B0281BF90; Fri, 6 Dec 2019 14:18:29 +0100 (CET) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id D094E23D for ; Fri, 6 Dec 2019 14:18:27 +0100 (CET) Received: by mail-pl1-f194.google.com with SMTP id h13so2743812plr.1 for ; Fri, 06 Dec 2019 05:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X2HMNa8iYs1BfigGCB0HkWHHW9cWt1bDKbPfOWNhNIA=; b=PfDY6TB6mqtZejYSMgUlRDpVO3VN2a+tLBvOl4gYoaWFtIs2PAcU9UBH/xOvrLQY1F MhxZ0IQtthZrwjeDrVl0MEIktLmbzlF676CFMJxdrJ/hrGuYn17zl6T6tN/SsRIIqTR5 W+QAoftr+703E74PdtzlQ298Mueis4uLG5zA801wDIoJkwHCMU4+dBmyPVocf9QGKL1/ JUBIADlhF/7gtarugXPhZfLj2g0sdWXo/iAkodT5N2nDdZXyIKl39mOW1FwqPOL2CIMI bSCvVGA/Kt1H+s0Udvj+Q/F/gnoM3lidB/IhcV1ffSm9hoHYAc67PH5aY3kuBoCvw3Yd Qprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X2HMNa8iYs1BfigGCB0HkWHHW9cWt1bDKbPfOWNhNIA=; b=PUMHSmKV01SdGyc5liCuUwFI4/pGj2o/8yg3kBxB8tB9TNGb/HKUmjtmhD85vFtS8W imWMRqEhKEcdnW4Nhp7GsmXCLkWqI1SHwRCMyoJgeC3GOVuRtCG6iGlYnxELsqYT56xd l4pzOjpykUj23MZSnsCy51vItDFMHOm+wZFuDJMwu7+sbYyNVfo4hB/uPlMo1yVnALmH cP834DR4AA6XqC77vPEKjG688ZDI437pp2vOqMktzeqCBIY+GZRHuzKy6J44Kav/WBNH +utYtVZcZ4PNHHZKqpuuBGZi58Uf12S3CmCtxtzE5M5pX5BpOHy0QCcIKuOFNjnkKDrv ly5A== X-Gm-Message-State: APjAAAXHque4TqeJYlH+b0ovAkwEY+kM1drbNGOoXGndipMhENxzmFKs YoUG+MmLYgFQ2ftzq4YoR0U= X-Google-Smtp-Source: APXvYqxYS6NM+BJpDgMc77HLUyHOArGkOGdymPeBw9ufTZIYQxN5LYfmronvMBunUromJIuYlOGJug== X-Received: by 2002:a17:902:744b:: with SMTP id e11mr13728666plt.251.1575638306916; Fri, 06 Dec 2019 05:18:26 -0800 (PST) Received: from mugwort.local ([2400:4050:c8c2:de00:d492:d32b:8e10:e562]) by smtp.gmail.com with ESMTPSA id w4sm3428465pjt.21.2019.12.06.05.18.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2019 05:18:26 -0800 (PST) To: "Burakov, Anatoly" , konstantin.ananyev@intel.com, david.marchand@redhat.com, dev@dpdk.org Cc: yasufumi.ogawa.gy@hco.ntt.co.jp, Yasufumi Ogawa References: <20191113214346.33749-1-yasufum.o@gmail.com> <20191127084826.3519-1-yasufum.o@gmail.com> <20191127084826.3519-2-yasufum.o@gmail.com> <2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com> From: Yasufumi Ogawa Message-ID: Date: Fri, 6 Dec 2019 22:18:23 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019/12/06 19:44, Burakov, Anatoly wrote: > On 27-Nov-19 8:48 AM, Yasufumi Ogawa wrote: >> From: Yasufumi Ogawa >> >> In secondary_msl_create_walk(), it creates a file for fbarrays with its >> PID for reserving unique name among secondary processes. However, it >> does not work if several secondaries run as app containers because each >> of containerized secondary has PID 1, and failed to reserve unique name >> other than first one. To reserve unique name in each of containers, use >> hostname in addition to PID. >> >> Signed-off-by: Yasufumi Ogawa >> --- >>   lib/librte_eal/common/include/rte_fbarray.h |  7 ++++++- >>   lib/librte_eal/linux/eal/eal_memalloc.c     | 11 ++++++++--- >>   2 files changed, 14 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_eal/common/include/rte_fbarray.h >> b/lib/librte_eal/common/include/rte_fbarray.h >> index 6dccdbec9..df003b8dc 100644 >> --- a/lib/librte_eal/common/include/rte_fbarray.h >> +++ b/lib/librte_eal/common/include/rte_fbarray.h >> @@ -39,7 +39,12 @@ extern "C" { >>   #include >>   #include >> -#define RTE_FBARRAY_NAME_LEN 64 >> +/* Filename of fbarray is defined as a combination of several params >> + * such as "fbarray_memseg-1048576k-0-0_PID_HOSTNAME". >> + * The length of string before PID can be 32bytes, and the length of >> + * PID can be 7bytes maximamly. Final 1 byte is for null terminator. >> + */ >> +#define RTE_FBARRAY_NAME_LEN (32 + 7 + 1 + HOST_NAME_MAX + 1) > > This breaks ABI, but i believe this doesn't break *stable* ABI, so it is > OK. Thank you so much! Yasufumi > > Reviewed-by: Anatoly Burakov >