From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB4A8A0A0C; Mon, 29 Mar 2021 18:10:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6D5E140E32; Mon, 29 Mar 2021 18:10:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5BB3E140E30 for ; Mon, 29 Mar 2021 18:10:26 +0200 (CEST) IronPort-SDR: HsvwnJ3gjz7/KGxJWfs/iJN9tNLxNatDAdT7CWg43QKOpXVdQRQNAr+YlomcWkHDmXvWkjP3u6 8gYEpd3hiFQw== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="255575160" X-IronPort-AV: E=Sophos;i="5.81,288,1610438400"; d="scan'208";a="255575160" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 09:10:24 -0700 IronPort-SDR: ydDI94cgXl0nD4LeVBHWoZFJl8fcAt+FmJvzpBdsPcsBX5wgeHN+nBWeqK69HvVMfn+wGs64Wf CdSM9mZXfClw== X-IronPort-AV: E=Sophos;i="5.81,288,1610438400"; d="scan'208";a="444650419" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.213.51]) ([10.213.213.51]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 09:10:12 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1616507156-35880-1-git-send-email-humin29@huawei.com> <1616507156-35880-3-git-send-email-humin29@huawei.com> Cc: Aaron Conole , Honnappa Nagarahalli , David Marchand , Thomas Monjalon From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 29 Mar 2021 17:10:08 +0100 MIME-Version: 1.0 In-Reply-To: <1616507156-35880-3-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: > From: Huisong Li > > The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. > However, the modification in the SVE algorithm is omitted. > As a result, the driver fails to be compiled when the SVE > algorithm is used. > > Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath") > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > --- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c > index f8655fa..e1a1731 100644 > --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c > +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c > @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue, > > nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts); > if (unlikely(nb_pkts == 0)) { > - txq->queue_full_cnt++; > + txq->dfx_stats.queue_full_cnt++; > return 0; > } > > Hi Connor, This is a very obvious build error, I am concerned how this is released. Do you have any internal testing? + Aaron & Honnappa, If we can have a build test in our public CI with SVE?