From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9F8244079; Mon, 20 May 2024 19:47:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1A204067D; Mon, 20 May 2024 19:47:15 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2057.outbound.protection.outlook.com [40.107.236.57]) by mails.dpdk.org (Postfix) with ESMTP id 757B74067C for ; Mon, 20 May 2024 19:47:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VH0XnLAY1K8KP3Wb23Rk0D4dpaKwevzgHV0xR+pr3Oi0mvlVTHH4MN6PfcpwQeVJLUzFw6ANt4pqH/f0AqgmJ7sRPK8Wd2fOQJ1kBpjvtncG+7JqkfgV5U56aWp1L7djZOVaEE9f2iqsRVF9d44PiWtoF2X2X1bX0c1yRV/P4QYkq6d+t9vm2gH2G0KfLLEWQkQZIzA+SGT9b+apCJIH0wf97UVg0dOt5BDN4hP4Qe+bgiV1Kqy6LYlTPoqJkKz2OYuahvdsVlzz+9K46AeMeRAaA7RglLVAn1ocmqXUn19ginM6Xx2tVSC9MjRAcRPaucAlb7DAaQWNIbsm//Ydxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l51oagxlIy/TbRR7V6c36l/GIdvFpOvu1L+XkvRkcVc=; b=didK4vzxOZG2El7T0AFBsVVVHZ+q+sjs4zK5DFKwcSLYFYq31vZ4E7eUeeviSRgQhIYAVY7kbl5cyDEHB9gtI0wWA3TPv2wQXk9ecbEaHdePObIYH1N9g5qAqGT7bK68hq2Re1aP8siWzAGZEPBQuI0jYYHHuW+qf7oVN0MTiXAWfpHKP5esL3YMD3LpRobtUSKhc+QW/MhKQyi0ErcR0kfLbkqKRVY+Awg2yC23FEzv8X0H4ivRhwpyVjwgDfb+Ujd3VEJoiaTpvWUYEXIwQ4MtLZSeUiE/sDRXQRJsUa1qjBoBRVbX/ELDB6mIY6DIezKgJcFJk/N51ymU+1c7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l51oagxlIy/TbRR7V6c36l/GIdvFpOvu1L+XkvRkcVc=; b=hxoO8DrJpnD7KjzBYFu+6vJojXO3G/tArzrJYZrqbNxiZ0gGyLGJM9przltwLb6G91K0DfX0z1N4wj8MEB82IIelwtypFm5Nnre+Aoq8F0J//mqoKhZ1Rg8B4flKGqCleTpMP2kT9Bqky+zEMcPQbFXyrZdQ4SalgUS/zUGHO4c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW3PR12MB4378.namprd12.prod.outlook.com (2603:10b6:303:52::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 17:47:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 17:47:12 +0000 Message-ID: Date: Mon, 20 May 2024 18:47:08 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 04/12] net/tap: validate and setup parameters for BPF RSS To: Stephen Hemminger , dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-5-stephen@networkplumber.org> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240502213618.11391-5-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0374.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW3PR12MB4378:EE_ X-MS-Office365-Filtering-Correlation-Id: 050aced9-8e63-4596-408f-08dc78f4e0f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VTJaL2UxNkt4MUt6TU1KZ3VUZzY1S05OQjBDdy9pSzNlaHpTcy9lb0F6N0lU?= =?utf-8?B?WjJtQ3ZEVUFlMGtwQTZUdVZTYzlSa1dUTUlhbUhSZFdNWnd4aWZWaTBnRDRH?= =?utf-8?B?T1Z0WHFwNjRicndCbHdLMmpUaUN5bWIrNG9vR2RPN3FXd0UwREtkREhWcS92?= =?utf-8?B?SGZCc3JLR3FEOWZzRk1QMWdnQ3RZYXp5YWVyeDE4ZVNCQTdnZy9pS2FJMjNv?= =?utf-8?B?MmN3SllMS0h2KzZacmY1VXpha3RzZFhEc0M1S2V5SlZpZ0tUaEhkblJmUDhp?= =?utf-8?B?ZWFkWEdvTkZSUTZMNG5qTjhacGhCMzRPUTB5eDB0N0gvS1dUd2VwcnZwSmFR?= =?utf-8?B?bFlaaTNONDBiWHJaWlhnSXVCbDlDM253VjREaHhiTmc3THZuVHNreVNnMW8x?= =?utf-8?B?MlN5MkNFbFJaTnFBazlEbVdITnhaRTZvc3JVMWVZSEEwREhhNGhnOGs2anpS?= =?utf-8?B?bUhEVGpjRWlvcEIzbldpQXk2Q0kvakVFUUNCZjc5eXhJRHFQZWE4UGpZdmlj?= =?utf-8?B?S2h2QlFlOEhFbUh0cDBDSE1EMHZtNTlOZnNSaVp6ZUcvc2Ntd3JLd3FqZkFq?= =?utf-8?B?R0p4b1REKzJNVFFRSmh3TlFWZ1MyaEFXVzU5QUhGSFpqckRhOXhCK3RyNS84?= =?utf-8?B?elZucFVFYXhISmpVRjhiczdOOXpPMndZL05yYXZEV2RzU1lqMnNPR1dCbjE0?= =?utf-8?B?N2czRE12Vi9wdTlSRUxvYUJReGFzdk1yUzhwMTllY3FUK0RDZEp2enhpa01N?= =?utf-8?B?YXJxZm1TK0JWdC83S09UN1dKbnBoNlNVUEYvdmVaMGR2MUVjbCtVbkxjdWZX?= =?utf-8?B?RGtTVXVYL2IwVldyUVlrK3ZZaVJPS2dOK1l1MmNhTHVQTlRBK1FXRTV3TDd3?= =?utf-8?B?K09GRk1wZzZWMVRtNmdDWGNJaWRERUpQNm1tbWd1dVJtVkYxVFpIb3E5SWo0?= =?utf-8?B?MzRNYmtaR28zRzlSd0ZOYndCOGM2b1RkaitLdEZIYXBaWHRoRE4wY2lvTnRq?= =?utf-8?B?WWtmd2xYcURIUDFNRktuZW1MTXBoUG0xQnhhQU00aCtEcS9Mak1jY1dGT28w?= =?utf-8?B?MlRXS243OFBDM0VUNXFqcWs3d2h5L1FQd2I4Y1BpeEk4aTVvcHhnVWdNZ3BX?= =?utf-8?B?MEJwbHlmUENZQ3J1a1NBYWZaMDFzZ3haVDRGY0l5akovV05UL1JqckU2aXB2?= =?utf-8?B?c1BOT3hBZXI3Q0lQc0ZGUmpDb1dqNGduS2xHNktkU01iTEg0ZitrSXBYK01K?= =?utf-8?B?bWZldzRpeWZ5WmVpblFtOWxLZ0dIdUh1d0lHTTc2Q1ZoT0lualFMUnkrSVFY?= =?utf-8?B?aEo5N0c5QWo5azdUOXM4c0Eyc3BLTkNKeDdRMWlXeHV4dXdyS0pRYTNHWllP?= =?utf-8?B?eHFCcGx6d0dVVkhTUmU2c1I5YW14OW5DRHp3VVAvMkI1NWoveFBGc1VpSXZ2?= =?utf-8?B?Q1dpU1hBSWtvNkx4S2w5Rm9Ta3phZVE1UHArQVM1OVREMEQrWmJvaUJ6Z05w?= =?utf-8?B?Q2s4bVJnYlIxSGx4V0JKaGJUYXZDU0sxUDArdFZ4UTRYZzE1cEpuWjRuOTZG?= =?utf-8?B?NHNYTC94YWoxc1hlWEpYYngrWkNzeUlTVldTRDExWXdQT1ZVNUx3WVNJWUV5?= =?utf-8?B?V1N0V29LUWY5eGI3aE1oR3dObnp2Nkc1elMrMHc5cE83aVpGeFZjOUtyTkM0?= =?utf-8?B?aHEzZzUrQ1RvZTJzR2t0dEJ6WUFOOHNwV0FzUmhtZE9EZlliZEV0bHF3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjF0N0d1R3RlSDA1RlJRNkpLMzQxVTZGVXh6SERFb05OLzMxZUVGZjhiL245?= =?utf-8?B?MGE4T3gyODhmQmcybjQ0MHhXcXpFQ0IrVU1ZZHdDMm5HZVNjbDRxUElJcjZV?= =?utf-8?B?a1pnREdqQU9hTUM5d2pORU5RQkNhUGovZ2d5VjFlbGkzT2NOaU53S1RuZE5P?= =?utf-8?B?ZHA0a3hxOU05QmpQRSt4TGVEeFNlU3lHUWw0KzM3SzNlUzNRdXU4czEvUS94?= =?utf-8?B?OWhOcm9zUjlhWXJKQ3VOaXNzNUtHSEFjOG55REQrZk5GSEc1Y1d5TDk4T0FO?= =?utf-8?B?dlpseDV5MTJiYXN4aWVNM2RQM2F4Z2lnanFBaTI0SXMzenB1TWhHZ050bjdR?= =?utf-8?B?VGpmWkZsWlM0RFpWdFZUblUrTkJDMmhoRWdGR2Y4d2ZDNkZFbGt4dEVDMkVx?= =?utf-8?B?L0ZlQjMvZGhkYVUxRUNURHJERFdrYTFhM0hFVTNJZ3lWdFhyTTM1S2pEcFdM?= =?utf-8?B?Mm1iOWZpa0lkUWQzNDI3S2lKN01Rc3pWSFU1WFJ4MmNUK0JLS2QzREJId2Iz?= =?utf-8?B?VmV6ZFRLMXJTRGpPTlpTVGFuakNrckxhaFFHMzU4TUpabmVsZEx2S0QwSXdk?= =?utf-8?B?T21wN2FMQUtoTTZaazFkcHU4V3ZvSnF1ZTB6akRXSGtCb1RCalB5aDl3dTV6?= =?utf-8?B?MFFORmtlMXBKckJHaEhHMmRtcFFIVzdwZkZvYnZGNElkRFlHZW8zM2JyNWRr?= =?utf-8?B?K2gvNWhLTUxKT3hkOEQzSzdJbUlzRWExUXJOT3h2UFI3ckEzMUJqQXBxVjdL?= =?utf-8?B?cFpiSFhmS2J0YzNlcHc5RWF1ZmgxYkJEUHl0YUoyYlJ3N3dMYXpzaEpGVncz?= =?utf-8?B?Q3lwTzVyODZzZ291Z0JINnlnN2VScTZCd1VjSXM4cDBXWEVIeWtpK1dobG4v?= =?utf-8?B?bU5RUW1KMGQ5bDNIekNlbmU0dkJrbEFmbHp6ZzlvZTM3V3JyaDYzTlhSY2xJ?= =?utf-8?B?anNmd0RnbkMvR1ZiVmc0V1lUMnRzSy9LbEY3bVhiSHVicVVBQlIzUU9WUnRS?= =?utf-8?B?aVhOM0ZrZXBXSGZjZFJSWWtMN0N4cm1HOGM4S1ZOZVhiRm9Rb3Qvd2V6eU9o?= =?utf-8?B?Q2thMGR4YUVvUVRVdzdYM3RVNFI2dndmTVAwdHNGU1VPRnYwYlpCNGxsbDE4?= =?utf-8?B?U1JLK0ZtM2MxQks4U1MzM2QzYUJjR3N0ajFTZEVXYUx1Z1NNc0dzSzZlQjFJ?= =?utf-8?B?LzYzMWVNOEZnU3BjZEgzMWRVWjh4OFhzTWJmZnVERENqMHZGRDRCRTVFdlJG?= =?utf-8?B?VGkrbFhVNDN2TmR3dlVsQ3dGSmJseEFkN1czVzQrRWJ4V3kwVzVCQWZlc2pu?= =?utf-8?B?eUdKeG5xcnI2MXFKTGpQMXY4V0dHZnNqNTJmSVlaRjF4b0pzWml2QkM2blVG?= =?utf-8?B?ejIwLys4bnZQajA3b0VYR3c2aE1MQzk4SXhYdEExL29NOFNkaFRMSzZROEc4?= =?utf-8?B?NGxCRGZOcEVnYVdEOUp5RXUxeWMzSXZGN1o2UmFFOEZMQmM4dVUyekJ3QmNp?= =?utf-8?B?V295QzIyY2FvVktPTzVhMXl3UG1LbXowaDdRc0NIYlBpdUk3ZzF3RnlXalUx?= =?utf-8?B?RGtrVHl1Nll4eUtlTEVOQmlWSFhpUmg1MGtmd1dkVHVCQWlzemNZY3NVOUdn?= =?utf-8?B?VTJWZ0h1S29UMSsyTmIzcDVMQ1FaamZ2Q3RPbEhXNEdRSnU4aWRMMlcvdDdt?= =?utf-8?B?V29ZMENsN1dlTGxhRXprZkRlMDFmMHB3M2twaFdnOGdrZjlUK2F2SDIzTEhS?= =?utf-8?B?QnpIOTNPSjhnN0k3TDJON01vdzU4Q1N4MitPbDFRY3N6SVZGTHRGRndmdjAr?= =?utf-8?B?eGhPaVBMTDFGeUdNUFdJS0pLNVJvbTlNVWIyTVg3T205cXJhYmNpZkdMQnBF?= =?utf-8?B?Qmc4SGlsZjlhc2hVQ1Vkb2VTNmRLMHhSbEJaSFdZdHVFS2MvTUpFU0dqY0RY?= =?utf-8?B?MDlta3VLQmhIN3VOb0ZESHgwVGtkNmFLQ2IzMGc1Nk5uTXZvajdaa3pMczhU?= =?utf-8?B?dXBIcXZaMVhlZW82L1VLekNKRTRkSmV3VDhjWmNnaVY3RkFvV2JPTDNTd0Ry?= =?utf-8?B?NmR5bnIxeWhyOVNpbWt0L2pkQ0M1TmJnWUcxWWFnUkJ2Tm9tVEszbUtGQkov?= =?utf-8?Q?iNTSLIMuRATFGFC0HvdVkzwzH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 050aced9-8e63-4596-408f-08dc78f4e0f7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 17:47:12.3078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a3O0wGwR/I2FoLdIgIhBI4/X4Yhy2mLCIHrFTkiTE0anR69cRjSIsUsMwGABbAFw X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4378 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > The flow RSS support via BPF was not using the key, or > hash type parameters. Which is good because they were never > properly setup. > > Fix the setup and validate the flow parameters, the BPF > side gets fixed later. > > Signed-off-by: Stephen Hemminger > <...> > @@ -2095,6 +2112,41 @@ static int rss_add_actions(struct rte_flow *flow, struct pmd_internals *pmd, > (error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > "a nonzero RSS encapsulation level is not supported"); > > + if (rss->queue_num == 0 || rss->queue_num >= TAP_MAX_QUEUES) > + return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > + "invalid number of queues"); > + > + /* allow RSS key_len 0 in case of NULL (default) RSS key. */ > + if (rss->key_len == 0) { > + if (rss->key != NULL) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > + &rss->key_len, "RSS hash key length 0"); > + key_in = rss_hash_default_key; > + } else { > + if (rss->key_len != TAP_RSS_HASH_KEY_SIZE) > + return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > + NULL, "RSS hash invalid key length"); > + if (rss->key == NULL) > + return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > + NULL, "RSS hash key is NULL"); > + key_in = rss->key; > + } > Does it make sense to add above expectations (like if "key_len == 0" default key used, or 'key_len' expectations, etc..) to the function comment? <...> > @@ -2109,8 +2161,11 @@ static int rss_add_actions(struct rte_flow *flow, struct pmd_internals *pmd, > rss_entry.nb_queues = rss->queue_num; > for (i = 0; i < rss->queue_num; i++) > rss_entry.queues[i] = rss->queue[i]; > - rss_entry.hash_fields = > - (1 << HASH_FIELD_IPV4_L3_L4) | (1 << HASH_FIELD_IPV6_L3_L4); > + > + rss_entry.hash_fields = hash_type; > + rte_convert_rss_key((const uint32_t *)key_in, (uint32_t *)rss_entry.key, > + TAP_RSS_HASH_KEY_SIZE); > + > Why 'rte_convert_rss_key()' is required? Is this making an assumption on the CPU architecture?