From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Chenbo Xia <chenbox@nvidia.com>
Cc: dev@dpdk.org, jerinj@marvell.com
Subject: Re: [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list
Date: Mon, 10 Jun 2024 06:35:32 +0200 [thread overview]
Message-ID: <e012a809-7753-40db-8c64-a54d965bde64@redhat.com> (raw)
In-Reply-To: <20240220114001.2228041-1-ndabilpuram@marvell.com>
On 2/20/24 12:40, Nithin Dabilpuram wrote:
> VIRTIO_F_ORDER_PLATFORM is needed feature when working with
> real HW platforms that are exposing virtio-net devices
> via VDPA framework. This feature helps in having more
> real ordering requirements between descriptor updates and
> notification data updates. Hence enable it if the
> device supports the feature.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index d395fc1676..6ece3c6621 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -701,6 +701,7 @@ virtio_user_free_vrings(struct virtio_user_dev *dev)
> 1ULL << VIRTIO_F_VERSION_1 | \
> 1ULL << VIRTIO_F_RING_PACKED | \
> 1ULL << VIRTIO_F_NOTIFICATION_DATA | \
> + 1ULL << VIRTIO_F_ORDER_PLATFORM | \
> 1ULL << VIRTIO_NET_F_RSS)
>
> int
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2024-06-10 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 11:40 Nithin Dabilpuram
2024-04-15 9:45 ` Nithin Dabilpuram
2024-06-10 4:35 ` Maxime Coquelin [this message]
2024-06-12 8:34 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e012a809-7753-40db-8c64-a54d965bde64@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).