From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4F09A0524; Tue, 13 Apr 2021 03:55:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5E8316097C; Tue, 13 Apr 2021 03:55:17 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 721CB16097A for ; Tue, 13 Apr 2021 03:55:15 +0200 (CEST) IronPort-SDR: Ozg1JQ2+laEpHmdZGcQyW2u/BptufmDgQEht334zARxVLYFgPcMse62I+17sMNpH6CoC1jm8Hr EJLMMFiW5Glw== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="174415973" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="174415973" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 18:55:13 -0700 IronPort-SDR: KbFCORuiTcYFqYxaGGiWe6l0gC35XsYH3+7wm09Og2tR7i7IY6TTRNbIkZSRg2+nf05wzZApdc 5b+0IPAii9jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="398588887" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 12 Apr 2021 18:55:13 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 18:55:12 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 09:55:10 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 13 Apr 2021 09:55:10 +0800 From: "Guo, Jia" To: "Xu, Ting" , "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR Thread-Index: AQHXLpmdqrWI2gN3u0CT9bMQ3U7Gt6qwCQUAgAGpoRA= Date: Tue, 13 Apr 2021 01:55:10 +0000 Message-ID: References: <20210324135407.60637-1-jia.guo@intel.com> <20210411060659.72525-1-jia.guo@intel.com> <20210411060659.72525-2-jia.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ting > -----Original Message----- > From: Xu, Ting > Sent: Monday, April 12, 2021 4:31 PM > To: Guo, Jia ; Zhang, Qi Z ; Yan= g, > Qiming > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDI= R >=20 > Hi, Jeff, >=20 > Best Regards, > Xu Ting >=20 > > -----Original Message----- > > From: Guo, Jia > > Sent: Sunday, April 11, 2021 2:07 PM > > To: Zhang, Qi Z ; Yang, Qiming > > > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > > > > Subject: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR > > > > Add support for IP fragment RSS hash and FDIR according to packet ID. > > Separate IP fragment and IP other packet types. > > > > Signed-off-by: Ting Xu > > Signed-off-by: Jeff Guo > > --- > > drivers/net/ice/base/ice_fdir.c | 50 > > +++++++++++++++++++++++++++++++-- drivers/net/ice/base/ice_fdir.h > | 22 > > ++++++++++++--- drivers/net/ice/base/ice_flow.c | 50 > > ++++++++++++++++++++++++++++++++- > drivers/net/ice/base/ice_flow.h | 5 > > +++- drivers/net/ice/base/ice_type.h | 1 > > + > > 5 files changed, 120 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/ice/base/ice_fdir.c > > b/drivers/net/ice/base/ice_fdir.c index 2b39c13127..0eb7cdd729 100644 > > --- a/drivers/net/ice/base/ice_fdir.c > > +++ b/drivers/net/ice/base/ice_fdir.c > > @@ -518,6 +518,24 @@ static const u8 ice_fdir_ipv4_udp_ecpri_tp0_pkt[] > > =3D { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; > > > > +static const u8 ice_fdir_ipv6_frag_pkt[] =3D { 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x86, 0xDD, 0x60, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x2C, 0x40, 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x3B, 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, }; > > + > > +static const u8 ice_fdir_ipv4_frag_pkt[] =3D { 0x00, 0x00, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x00, 0x45, > > +0x00, 0x00, 0x14, 0x00, 0x00, 0x20, 0x00, 0x40, 0x10, 0x00, 0x00, > > +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; > > static const u8 ice_fdir_tcpv6_pkt[] =3D { 0x00, 0x00, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x86, 0xDD, 0x60, > > 0x00, @@ -716,6 +734,16 @@ static const struct ice_fdir_base_pkt > > ice_fdir_pkt[] =3D { sizeof(ice_fdir_ipv4_pkt), ice_fdir_ipv4_pkt, > > sizeof(ice_fdir_ip4_tun_pkt), ice_fdir_ip4_tun_pkt, }, > > +{ > > +ICE_FLTR_PTYPE_FRAG_IPV4, > > +sizeof(ice_fdir_ipv4_pkt), ice_fdir_ipv4_frag_pkt, > > +sizeof(ice_fdir_ipv4_pkt), ice_fdir_ipv4_frag_pkt, }, >=20 > Should be the same, "ice_fdir_ipv4_frag_pkt" >=20 As you said that is, will correct it. > > +{ > > +ICE_FLTR_PTYPE_FRAG_IPV6, > > +sizeof(ice_fdir_ipv6_frag_pkt), ice_fdir_ipv6_frag_pkt, > > +sizeof(ice_fdir_ipv6_frag_pkt), ice_fdir_ipv6_frag_pkt, }, > > { > > ICE_FLTR_PTYPE_NONF_IPV4_GTPU, > > sizeof(ice_fdir_ipv4_gtpu4_pkt), >=20 > Skip... >=20 > > diff --git a/drivers/net/ice/base/ice_type.h > > b/drivers/net/ice/base/ice_type.h index a6599363f9..5abe9dc9ea 100644 > > --- a/drivers/net/ice/base/ice_type.h > > +++ b/drivers/net/ice/base/ice_type.h > > @@ -349,6 +349,7 @@ enum ice_fltr_ptype { > > ICE_FLTR_PTYPE_NONF_ECPRI_TP0, > > ICE_FLTR_PTYPE_NONF_IPV4_UDP_ECPRI_TP0, > > ICE_FLTR_PTYPE_FRAG_IPV4, > > +ICE_FLTR_PTYPE_FRAG_IPV6, > > ICE_FLTR_PTYPE_NONF_IPV6_UDP, > > ICE_FLTR_PTYPE_NONF_IPV6_TCP, > > ICE_FLTR_PTYPE_NONF_IPV6_SCTP, > > -- > > 2.20.1 >=20