From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0586AA04B5; Thu, 1 Oct 2020 00:49:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59FDE1D5B1; Thu, 1 Oct 2020 00:49:13 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E9B411D5A8 for ; Thu, 1 Oct 2020 00:49:09 +0200 (CEST) IronPort-SDR: mR7Af8ptYcWpuDHfSPchKuQ9nD//8s7XEzuXPWAskg5y7xAgaVtARuPPx4HHSYEVvQYVB6F9Jf Nu9K6wCyYBbg== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="150215333" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="150215333" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:49:05 -0700 IronPort-SDR: DtUzpU4cIulkx4tR5+ypDh8Eca1HMcUD6yzPWyd8ow/iUAnzkgRuP4K7nqvuu0544TkZ6nlsBI daFKgx7+Hdww== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312760483" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:49:04 -0700 To: "Wei Hu (Xavier)" , dev@dpdk.org Cc: xavier.huwei@huawei.com References: <20200929110945.70761-1-huwei013@chinasoftinc.com> <20200929120117.50394-1-huwei013@chinasoftinc.com> <20200929120117.50394-8-huwei013@chinasoftinc.com> From: Ferruh Yigit Message-ID: Date: Wed, 30 Sep 2020 23:49:00 +0100 MIME-Version: 1.0 In-Reply-To: <20200929120117.50394-8-huwei013@chinasoftinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > The new generation hns3 network engine supports independent enabling and > disabling of a single Tx/Rx queue. So, it can support the queue start and > stop feature. In addition, when different numbers of Tx and Rx queues need > to be enabled in some applications, hns3 pmd does not need to create fake > queues to enable these scenarios. > > This patch Add queue start and stop feature for the new generation hns3 > networking engine. Cancel the creation of fake queue on the new generation > network engine. And the previously improperly named queue related function > was renamed to improve readability. > > Signed-off-by: Chengchang Tang > Signed-off-by: Wei Hu (Xavier) <...> > @@ -5626,6 +5666,10 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { > .tx_queue_setup = hns3_tx_queue_setup, > .rx_queue_release = hns3_dev_rx_queue_release, > .tx_queue_release = hns3_dev_tx_queue_release, > + .rx_queue_start = hns3_dev_rx_queue_start, > + .rx_queue_stop = hns3_dev_rx_queue_stop, > + .tx_queue_start = hns3_dev_tx_queue_start, > + .tx_queue_stop = hns3_dev_tx_queue_stop, > .rx_queue_intr_enable = hns3_dev_rx_queue_intr_enable, > .rx_queue_intr_disable = hns3_dev_rx_queue_intr_disable, > .rxq_info_get = hns3_rxq_info_get, Can you please update feature files ('hns3.ini' & 'hns3_vf.ini') to announce "Queue start/stop" feature?