From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A9CCA052A; Wed, 23 Dec 2020 03:32:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEC37CA2E; Wed, 23 Dec 2020 03:32:57 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 36942CA2C for ; Wed, 23 Dec 2020 03:32:56 +0100 (CET) IronPort-SDR: pX2CgXfi3jvMd8fCADcgLKuFUc4ue8wlrt7GdfUJ4aZVk+EXzxwIx9HgcG2kduf3c6NfKq1f+i SSdLohrPftCg== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="237512281" X-IronPort-AV: E=Sophos;i="5.78,440,1599548400"; d="scan'208";a="237512281" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 18:32:52 -0800 IronPort-SDR: npxl8dcX4rydPLHgT6B91wGkseKzuG7OSEWZRlOwlB0Ha62DY3xdvf99X8D+9shiA7aeEVH2IP IEcm8YI+sSOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,440,1599548400"; d="scan'208";a="338584184" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 22 Dec 2020 18:32:52 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 18:32:51 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Dec 2020 10:32:49 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 23 Dec 2020 10:32:49 +0800 From: "Guo, Jia" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, MurphyX" Thread-Topic: [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully Thread-Index: AQHW1QYvto8nSGeeekCu96Ox9afv4KoD+gXw Date: Wed, 23 Dec 2020 02:32:49 +0000 Message-ID: References: <20201209071438.32419-1-murphyx.yang@intel.com> <20201218061843.72422-1-murphyx.yang@intel.com> In-Reply-To: <20201218061843.72422-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, murphy > -----Original Message----- > From: Murphy Yang > Sent: Friday, December 18, 2020 2:19 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; Guo, Jia ; Wu, Jingjing > ; Xing, Beilei ; Yang, > MurphyX > Subject: [PATCH v2] net/iavf: fix negative GTP-U flow rules create > successfully >=20 > Currently, when use 'flow' command to create a negative GTP-U rule, it wi= ll > be created successfully. >=20 > The list shows the impacted outer and inner 'ipv4' GTP-U patterns with 'i= pv4' > or 'gtpu' type: > - iavf_pattern_eth_ipv4_gtpu_ipv4_udp > - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_udp > - iavf_pattern_eth_ipv4_gtpu_ipv4_tcp > - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_tcp > - more impacted patterns with 'gtpu' type: > > iavf_pattern_eth_ipv4_gtpu_ipv4 > > iavf_pattern_eth_ipv4_gtpu_eh_ipv4 >=20 > Same as the outer and inner 'ipv6' GTP-U patterns. >=20 > So, this commit adds the invalid RSS combinations in 'invalid_rss_comb' > array to make result correct. >=20 > The list of added invalid RSS combinations: > - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP > - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4 > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6 > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP > - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP >=20 Seem that you add some specific negative flow case for the "ipv4(outer/inne= r) + gtpu" and "ipv4(outer/inner) + ipv4-udp(tcp)" in the currently invali= d checking mode, so you commit log could be more clear and clean for that, = thanks. =20 > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") >=20 > Signed-off-by: Murphy Yang > --- > v2: > - add invalid RSS combinations >=20 > drivers/net/iavf/iavf_hash.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c = index > c4c73e6644..8393d8535b 100644 > --- a/drivers/net/iavf/iavf_hash.c > +++ b/drivers/net/iavf/iavf_hash.c > @@ -806,7 +806,15 @@ static void iavf_refine_proto_hdrs(struct > virtchnl_proto_hdrs *proto_hdrs, >=20 > static uint64_t invalid_rss_comb[] =3D { > ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP, > + ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP, > ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP, > + ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP, > + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP, Shouldn't it be " ETH_RSS_GTPU | ETH_RSS_IPV4" if outer ip case is the same= ? Whatever you should considerate both if you check one. > RTE_ETH_RSS_L3_PRE32 | RTE_ETH_RSS_L3_PRE40 | > RTE_ETH_RSS_L3_PRE48 | RTE_ETH_RSS_L3_PRE56 | > RTE_ETH_RSS_L3_PRE96 > -- > 2.17.1