From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D1CA0540; Thu, 7 Jul 2022 04:33:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FB4B40A7B; Thu, 7 Jul 2022 04:33:08 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 5E957406B4 for ; Thu, 7 Jul 2022 04:33:07 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id bh13so10005074pgb.4 for ; Wed, 06 Jul 2022 19:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vvdntech-in.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zb4JHAvtg9/v7SqCUaIfgvFKNPH/LSiiqYFg5AkLKCI=; b=R1rKA8vMjBJc8By+5APXQ93jyI34TkWqD9uapP5YWxv8ggaZ7V5zaqfuRr6hJR+Cw8 j7WpXcHNs4A75VpAZ2qgn2e8kfeTvPtMxI3ceQZiURfXLdlpuA+gOb+SqneSmBu8BCWB keZAK/1I88fsf225UPlr77xUmxOdu++H+zpjbfdb8Jvc1ap5DLJg2OTplJ2TAIHeogaM +5bq8mUs5e+wnaRxEDB7dDXgVjWGVkwFjuQnliyYoUlBJYERRz66+o1syRmcdbMcpzqm qSxusbdZJu2QfZBPDgfG7h5w07CNKWova9kzij2TRwEVBEC6S/w66y+WWcFeF3s09z3u rLpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zb4JHAvtg9/v7SqCUaIfgvFKNPH/LSiiqYFg5AkLKCI=; b=qWG1gX0AXWwkNoPhVrS2sXY4Grna5rCTDG6D56b/fO9JAewgSaKmge+aWTyVkAj3M3 PxAIyOc6WQ6OXj5AqpJf6bTrccBWfbedi04WbHpMGOXXQk5o3m56RYLL99aMbfbfMoDE zGrfLs1dK6KbarmCKQSrfVF9YzADxVOyoTQUI3wi6wPTRkzxM53AUDY6PmjFrKAKl3gu Uw3Voz+ZMPfc9z8rIs14MqZTVKljx15VIsGhfOd5Mqdat9Rx1FW6pcOL5PezI+QzFQGa Xh2MaVoK441M4M21zDC1ES9QlknTl7BpTyqlpUiyApmO7vJEX++XwvAwDDKnPa6V2tjI 7Wig== X-Gm-Message-State: AJIora/zxAWltxCGnlP7b3FvZADI7pV+ZYCqEmsplDOc8Pesu2zoOv7h BCHjP/Ny2s0kiIBdta66Tywkzw== X-Google-Smtp-Source: AGRyM1sogIQCR9llA27/li8LP6iNGzwGjlOC/GRMy3BBiLFJlaCn2DYeQRB/6SLJ76yNvLUZXe1A6Q== X-Received: by 2002:a17:90b:4c4d:b0:1ec:bb28:9819 with SMTP id np13-20020a17090b4c4d00b001ecbb289819mr2171885pjb.140.1657161186465; Wed, 06 Jul 2022 19:33:06 -0700 (PDT) Received: from [172.24.1.88] ([49.249.29.178]) by smtp.gmail.com with ESMTPSA id f8-20020a056a001ac800b005251b1fde90sm26023206pfv.219.2022.07.06.19.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 19:33:05 -0700 (PDT) Message-ID: Date: Thu, 7 Jul 2022 08:02:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 04/29] net/qdma: add logging support Content-Language: en-US To: Stephen Hemminger Cc: dev@dpdk.org, maxime.coquelin@redhat.com, david.marchand@redhat.com References: <20220706075219.517046-1-aman.kumar@vvdntech.in> <20220706075219.517046-5-aman.kumar@vvdntech.in> <20220706082734.0e24f587@hermes.local> From: Aman Kumar In-Reply-To: <20220706082734.0e24f587@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06/07/22 8:57 pm, Stephen Hemminger wrote: > On Wed, 6 Jul 2022 13:21:54 +0530 > Aman Kumar wrote: > >> +extern int qdma_logtype_pmd; >> +#define PMD_DRV_LOG(level, fmt, args...) \ >> + rte_log(RTE_LOG_ ## level, qdma_logtype_pmd, "%s(): " \ >> + fmt "\n", __func__, ## args) > Did you test this. Looks like your log messages are going > to end up double spaced. Because many of the later calls put a > newline on the message. Example: > > + PMD_DRV_LOG(INFO, "QDMA devargs desc_prefetch is: %s\n", value); Additional lines did not bother us during feature testing. I'll fix this in v2. Thanks for pointing this.