Re: [PATCH] net/bonding: fix socket_id type

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 10/12/2022 12:45 PM, Markus Theil wrote:
> From: Thorben Roemer <thorben.roemer@secunet.com>
> 
> DPDK uses int or u32 in most other places for
> socket IDs. Fix compilation warnings by also
> using int in the bonding code.
> 

Hi Markus,

'rte_eth_bond_create()' is part of API, so changing it impacts the users.

Since 'rte_socket_id()' returns 'int', it is reasonable to make 
'socket_id' parameter type 'int', but I am not sure if it worth the 
trouble it may cause in user end.

Maybe we can announce the change in this release and update the API in 
v23.11?


Can you please list the mentioned compile warning?

> Signed-off-by: Thorben Roemer <thorben.roemer@secunet.com>
> ---
>   drivers/net/bonding/rte_eth_bond.h     | 2 +-
>   drivers/net/bonding/rte_eth_bond_api.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h
> index 874aa91a5f..3ce2b29052 100644
> --- a/drivers/net/bonding/rte_eth_bond.h
> +++ b/drivers/net/bonding/rte_eth_bond.h
> @@ -99,7 +99,7 @@ extern "C" {
>    *	Port Id of created rte_eth_dev on success, negative value otherwise
>    */
>   int
> -rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id);
> +rte_eth_bond_create(const char *name, uint8_t mode, int socket_id);
>   
>   /**
>    * Free a bonded rte_eth_dev device
> diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
> index b44dd219cb..3c6e236382 100644
> --- a/drivers/net/bonding/rte_eth_bond_api.c
> +++ b/drivers/net/bonding/rte_eth_bond_api.c
> @@ -148,7 +148,7 @@ deactivate_slave(struct rte_eth_dev *eth_dev, uint16_t port_id)
>   }
>   
>   int
> -rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id)
> +rte_eth_bond_create(const char *name, uint8_t mode, int socket_id)
>   {
>   	struct bond_dev_private *internals;
>   	struct rte_eth_dev *bond_dev;