From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0084.outbound.protection.outlook.com [104.47.38.84]) by dpdk.org (Postfix) with ESMTP id 292CE1B72F; Fri, 13 Oct 2017 17:45:04 +0200 (CEST) Received: from BN3PR03CA0084.namprd03.prod.outlook.com (10.167.1.172) by BN3PR03MB2353.namprd03.prod.outlook.com (10.166.74.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 15:45:03 +0000 Received: from BY2FFO11FD040.protection.gbl (2a01:111:f400:7c0c::111) by BN3PR03CA0084.outlook.office365.com (2a01:111:e400:7a4d::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Fri, 13 Oct 2017 15:45:03 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD040.mail.protection.outlook.com (10.1.14.225) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 15:45:02 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9DFixW6010274; Fri, 13 Oct 2017 08:45:00 -0700 To: , CC: , , References: <20171012130726.4332-2-alok.makhariya@nxp.com> <20171013153854.8444-1-alok.makhariya@nxp.com> From: Akhil Goyal Message-ID: Date: Fri, 13 Oct 2017 21:14:58 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013153854.8444-1-alok.makhariya@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523831024467493; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(346002)(39860400002)(376002)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(377454003)(199003)(104016004)(54356999)(64126003)(83506001)(8936002)(53546010)(97736004)(356003)(305945005)(8656003)(229853002)(81156014)(68736007)(36756003)(8676002)(47776003)(65826007)(86362001)(81166006)(5660300001)(77096006)(4326008)(31696002)(50466002)(23676002)(110136005)(6246003)(54906003)(58126008)(50986999)(189998001)(76176999)(230700001)(31686004)(65806001)(85426001)(33646002)(316002)(2950100002)(65956001)(498600001)(53936002)(105606002)(106466001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2353; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD040; 1:9ozkb6ncZahiXBUpXDQZbUIWPHiIPDtXo51WO/ay8CQLKnhpo6Edr17GuTZGKguMZJ1HV5+WI7UC3XWkK7xx4vj/45bk/p8GsNwcoTdhX1gJy1s4LgeqBix4WQ0boNap X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24ce4425-1bf8-4995-3e25-08d512515e2d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2353; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 3:THlUfHjlt2eSrZLaFuYt7WyGWr2NuG+pdiibQYCLJePUKrDkNN2f6RLG1LnixmoZ2mDTLDRVWgI+6yPGp3iSUKZkURIeW4ekG1VY2j8jLtPo7ivRN2awyE2PwOKGSLFRHRP9zqsG7Bv/m1ZxpAi4wuvRo+p4YaCyNL1Gdxq+i37w35JAoMnW8ZqlchCu1POiUSYFFSdeVkFz+aeYerPlfJ8zqyQ5QjBUl3+VZwKceDZl4/eO6XoobvGLCCQpHfwyHsDUyth6EVm7x2EtsoNptIWlTbn/9TQ7gsM/Miwto6ycQJexJgPOnLAc9tPObmsXkF3yZ95Q5ho9+gxE7KqUgz5BZntEJc1Y9VbWPE1txjk=; 25:UW40SWUXaej/u/3rxhhEWkpAM/g2ikTJhSzjEKh8oXlZfxA16f2b1/cto+At/9nx02XM1YtUrDW52R7kG2bhnDnkGf83YDnvypM01fe+9SIxHFef111+NuI27qQx5VGdmLv33/y//PIKS3wiDvlPSYo4pYnqYzVN8/cGoU3C1t1u4pYMrsyPpq/UYXgY+lz39ybDbg0FAlLiaKUrZdHiwNnuPnF4k+mQEA3KUtGvnvqcq+qwAF0Ga6gZ8mPxEGrPG+y87eQjSuLmcbx606CUk9wSvW2c7V7w1XgnuBaRTgGIf4qO28krXcubI9n9nf3akmYQyQxK67Z4ad/ArI3IiA== X-MS-TrafficTypeDiagnostic: BN3PR03MB2353: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 31:bvDLpRoJEU4Zx8cSqJcjTQ0PPqS92zPClI94pabUaPw5Epa4R+j6hHztUuxEXK51IynTzHmlVRT3GnSMxCj2RKSfVjb3ZGOhMMtVJe/Vshkk/C+sj0k4VKt4/1smbyOb1AVyLm7466bK8BDrqNp9u0MMeFs7LthMcA2UzLfsnpfxlu+Hq/o+9JLOorWxIMANQSC9tJCzhrVySpE4YN8aKEIL/XxdpzFCgGLKxeKcXaw=; 4:IPGBX2ARr8e2VyZj0OguT/ugttOYY1N0l5XKX8vyWjmLsahUDm9Dq5sn7iU68Nw49j4zc+JtFgc7qAl9q1SE7+Nr3sR1doaKpsqvXuBPdNbJFOCW/448YG7vixMxQuxPktlRsnx1sNSJcFFaTorKRmHs2Ex1eUPtPzyqKEosb5uQgTHg1qYkWauBtVoztM30IJUXTu8hgrgg3FPR5gGVP+yNpJteiH23Pzmyhx8zzR4bEDx4rA5kfad/zBQnaXKDJC+HniF36hpldFhuOmz9r6HXV4LUEzLQJXzgiQOjmk8= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123561025)(20161123559100)(20161123563025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2353; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2353; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMzUzOzIzOmk2OGJjS2tmK1dZRlozc09YRnIwbFBaWW5N?= =?utf-8?B?RmVXYWorbTBTcmZxMHNMM2o0QmtreGU3b2NYRURiQnFpL3A3N0xUSENnTHBl?= =?utf-8?B?S2pENVdYbTFKY28xRlViZXVjWmdaa1FmU0hDOU5UaStlZjl1dGdBVS9EUGp4?= =?utf-8?B?R285aFJzUThXZi9QM3QxR1h2TzkxMEVFVCttOW1sWCtGQnVtSDBhUUQ3R0FB?= =?utf-8?B?V0I4amFjMmlzL1BnckNBdFVpZlJKQW9weW5VT2pLdXV3TFRYR2xYRll1Ynh2?= =?utf-8?B?eUE0Z3UyaWliZWlaV25ybmlpRHFiZ0JZME00V0pCaU9lbXoyeHBadlpaYVBE?= =?utf-8?B?cmJqZkIyUHdvR2o2YlZCVjlINEIwZ1ZEQk1VcU8wcFlNNDNaZnJ0S3ROcFBO?= =?utf-8?B?cE1TRHVRNVJqY3BvV3lORWxtaGhqcjNlMHFRc1RIeHgzOEJkdWZCUGtmcGNX?= =?utf-8?B?NEtrcW1TdHMzSU9NU0FwWlR5MXlWYTJxU01Wa3ZPWEJHa2NuaExpc0hQY2dO?= =?utf-8?B?SHNvWnR0OWxMM1EwSWR0bS9PdWJuSEt4OTNWVEE0TG1IYXhZSzR4UzRkWnhJ?= =?utf-8?B?aUZhc0JMVDduVXFuMm14NFBZa1I0ZHN4Y3J5L2dZeEdVT3dUamFzY3RtODl2?= =?utf-8?B?WFRnQXV3Rm5FTjBZQitqVXB2c2E4V2RSZ0lrYWlGV05qYWdtL0NMRzgwNFVC?= =?utf-8?B?eVBlaW55bzBtb0VDSTdDSVdBdHIxaHBqWmhNeTZ2aEw2VHRNZXJlTHVwRHdk?= =?utf-8?B?elpoT0h6UFVxMFd6WGxzU1hENjJQb3NCNjdDdlEvRit6OFpYWkhndGdNNDQy?= =?utf-8?B?WjVYYVNvUnM2c0tCRW5HWDNncFVib0lrdlJBRDdQYkVKbC9RZElWQUVHSjAr?= =?utf-8?B?a1o4cWIrQndXRWErYTc2eFFBMzhvdGdXZzFNeDRjWW9iYURiZFg4b29wem9I?= =?utf-8?B?OEp1MThEczV3Zm13VUJBUHhYVzFjYlZWSXhGK1FzaVc3QS9rcGFGZUk1VDg0?= =?utf-8?B?YnFTaHN4WTVGRnYybVNNQk9PRllNNkE0LytvVlQzazIzQ2NLemtLSkcraThW?= =?utf-8?B?eW1GOWVhM3pYcUJOdzIyMWFCejlwN0hoUFhHdDJnK2l1SWxXUHVScXpRNWVq?= =?utf-8?B?NmU2dlpKUnF6aGJnQjBqMkR4bHRzcnhIbkZBbmtnMVJiWEx0T2w0cktjZDF3?= =?utf-8?B?MldJaHluQkQ4bGhnL052VlRPNDhBS1NGdnJnNnZJdi9EZWJyL1lLZFUwRlZY?= =?utf-8?B?b0RGMDJTVEpwaG5Ednc0Ym1WZS9CRGpVemlUcVcySkpHaFZ6N3BScElYRjV5?= =?utf-8?B?QmQzWHZHNE5iZFAwYlQ3MTROZllZOTVaTkpGNWtmQjhTNnZEdmxSQUd5a01P?= =?utf-8?B?ZE9wK0t1MWhDaDRvc0VuZE9wYW9UN2pGaFhFVWZIcHZJSDZ4NDFoUGhxNXQz?= =?utf-8?B?OGZGMnN4ZTQ3U3hRT1EwMmxUeFhaWm5pZEQ3ZlFSTzFSUmpSbTB3TDdyUkt3?= =?utf-8?B?RFRiZ1JrZlV1TjM0VEx3M255eCs3bkNHcmNuT1dEMUZZVXh3Q2xnNWxaclBD?= =?utf-8?B?TmFwOTZxbG1oQXFaZUhtV3pSWW44QkRlcllZQ3RuOFJQbjQ0enpaT2hoUVlR?= =?utf-8?B?ZVlzTjY2L0FuRHUwMUxQeGZjd3psRU5DekJCK0VoMXAxRHhKOS9BbmZ3akxS?= =?utf-8?B?YzR0TmNld1VoWWJNM1BHSk5MenZiQmVidlFOQml6ZFJLdGh4cVY3Wmt3cXda?= =?utf-8?B?UFFvN2pXcEtGQjJva2FQbVNDN2UrYm5OYm15YUJmRU1TRmNvb044T2s5cUUr?= =?utf-8?B?aGFQVllQc2JLUk5XNTNoVTI4ZUx3ZjQxWVJGTWR6SVpvYk02SjB2akFuSG01?= =?utf-8?Q?vZxfaV3Ek20=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 6:n0J5Htd6Cdi3mvXkoG8CjHXqi1VSoxOVk4rTzTRLg4qoPtdIja6tCdzkHEFXNYrLOzgt9taxXMTX8+oM7eBSGX2f392Hf+GMfME4RrmICTedXXGNwNjlJ7oXTVNCwEQeZzGrZIhWEsK6VEvb7LfdLV7zQtmdwl4lNBF9nZRNGR0cxlcsqHO1itvbqcpYFy1eix2Far4biT4ZDRs3mrbeUxMD+2vip/JtVY0e08R3Ijhz8hgB+SMoom69XlqiBeOCbnSF1qGmoS0+4Nj75zFTrg9KOQTZvDzFPgYu3OQiTDMhazkwIkL2JnWZPzRv/k8ebH7rKp+3ja1tphgxZqAULQ==; 5:EZzdfuVuKdc+RMgGiiutyGZNmNspPLyMHlfpN+TdjhrGIxGTe2ymHpKcoXIVeqOFH0ZrmoG6AvJP/TZwdzG1qBSD6/CiPL1sRONI5mcYok3TU0oEXN77NyJ7N8ejD82HZ5BanzZVZRiYAi2+Qb8ZzQ==; 24:kbwPbVHF3DD5rXkb0UaokW89dHPZzoBD1uzW60JlbLwUv7m16Afa3GQ+GCHoyClxSKiz+R3bjbQIvPuCPInCKtAI2+cYb8NKqh1iCk7VkDI=; 7:OS25yZ2K7Rg2h+Fhj5rPsVL2RgW6CDNBj3rNGJejhnMN6IxfgYv+VeZKkW603KWNjVRvaJ/SDZbye/gYG9JW5kCAl3lITL7nDw4z8+5tZGPQN0qcjoxTRDPODzVJoJK6guG64TwgQlBTqo3W9oVYYLwVSaXu+8XHm9UgAVpSVepJXFzt4UhLlZushbAyW0ADTwF284A4I3rfMR04saam3csZo2110MuSDbK6BE9Wil0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 15:45:02.2595 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2353 Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 15:45:04 -0000 On 10/13/2017 9:08 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya > > The code would crash for segmented buffer if no check. > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > Cc: stable@dpdk.org > > Signed-off-by: Alok Makhariya > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 672cacf..b33081c 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -551,7 +551,13 @@ build_sec_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > int ret = -1; > > PMD_INIT_FUNC_TRACE(); > - > + /* > + * Segmented buffer is not supported. > + */ > + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { > + op->status = RTE_CRYPTO_OP_STATUS_ERROR; > + return -ENOTSUP; > + } > switch (sess->ctxt_type) { > case DPAA2_SEC_CIPHER: > ret = build_cipher_fd(sess, op, fd, bpid); > Acked-by: Akhil Goyal