From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 498821B5D9 for ; Tue, 3 Oct 2017 21:01:16 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2017 12:01:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,474,1500966000"; d="scan'208";a="906337336" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.245]) ([10.241.224.245]) by FMSMGA003.fm.intel.com with ESMTP; 03 Oct 2017 12:01:13 -0700 To: Jerin Jacob Cc: dev@dpdk.org, santosh.shukla@caviumnetworks.com References: <20170831145436.5397-1-jerin.jacob@caviumnetworks.com> <20170911181539.GD26002@jerin> From: Ferruh Yigit Message-ID: Date: Tue, 3 Oct 2017 20:01:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170911181539.GD26002@jerin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/26] DPDK PMD for OCTEONTX NW device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 19:01:17 -0000 On 9/11/2017 7:15 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Tue, 5 Sep 2017 18:43:37 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , dev@dpdk.org >> CC: santosh.shukla@caviumnetworks.com >> Subject: Re: [dpdk-dev] [PATCH 00/26] DPDK PMD for OCTEONTX NW device >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >> Thunderbird/52.3.0 >> >> On 8/31/2017 3:54 PM, Jerin Jacob wrote: >>> This patch set provides the initial version of DPDK PMD for the >>> integrated NIC device found in Cavium OCTEONTX SoC(CN83xx) family. >>> >>> Introduction to OCTEONTX ARM processors can be found >>> here: http://www.cavium.com/OCTEON-TX_ARM_Processors.html >>> >>> OCTEONTX SoC family has two types of NIC controllers, >>> 1) nicvf HW, Which is more like traditional NIC(no NPU HW accelerators) >>> http://dpdk.org/doc/guides/nics/thunderx.html >>> >>> 2) NIC controller, based on NPU like HW accelerated coprocessors, like >>> HW assisted mempool manager, HW assisted packet scheduler, etc >>> >>> This driver adds support for the second type device and which will be >>> used as HW implementation driver ethdev-eventdev Rx adapter [1] >>> >>> Implemented features and PMD documentation added >>> in doc/guides/nics/features/octeontx.ini and doc/guides/nics/octeontx.rst >>> respectively in this patch set. >>> >>> This driver has the dependency on: >>> - IOVA infrastructure [2]. >>> - Dynamically configure mempool handle (ie.. --mbuf-pool-ops eal arg) [3]. >>> - Infrastructure to support octeontx HW mempool manager [4]. >>> - Cavium Octeontx external mempool driver [5] >>> Git source repo for all above dependency patches located at [6]. >> >> Hi Jerin, > > Hi Ferruh, > >> >> At first glance PMD looks good to me, but currently there are many >> dependencies and I am not able to apply the set. I will wait a little >> more for dependent patches to settle down and will re-visit this again. > > OK. The dependencies are more of runtime in nature not all of them are compile time. There may not be compile time dependency, but in case any change requested in dependent patches requires update in this patchset. > > >> >>> >>> The series has three check patch issues: >>> 1) 1 Error on Complex Macro (which I believe it cannot be fixed) # Patch 2 >>> 2) 1 Error on spacing while using gcc inline assembly(it is false positive) # patch 2 >>> 3) Added Co-authored-by: signature to reflect the patch authorship status instead >>> of "Signed-off-by". It can be changed or the contributing guide can be >>> updated based on the community feedback in v2. >>> >>> [1] http://dpdk.org/dev/patchwork/patch/24176/ >> >> Are these APIs used in this patchset, I looked for them but not able to >> find ... > > No. >