From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3998A4CAD for ; Tue, 30 Oct 2018 10:10:24 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B84883F40; Tue, 30 Oct 2018 09:10:23 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 890AB60487; Tue, 30 Oct 2018 09:10:22 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20181025094659.25492-1-tiwei.bie@intel.com> <20181025094659.25492-2-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 30 Oct 2018 10:10:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181025094659.25492-2-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 30 Oct 2018 09:10:23 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 09:10:24 -0000 On 10/25/18 11:46 AM, Tiwei Bie wrote: > Drop the duplicated reset() method in virtio_pci_ops. Currently > vtpci_reset() is implemented on set_status() and get_status() > directly. The reset() method in virtio_pci_ops isn't used and > its implementation in the legacy device isn't right. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_pci.c | 15 --------------- > drivers/net/virtio/virtio_pci.h | 1 - > drivers/net/virtio/virtio_user_ethdev.c | 1 - > 3 files changed, 17 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime