DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
Date: Tue, 19 Mar 2019 14:05:32 +0000	[thread overview]
Message-ID: <e099920d-f423-6356-4148-85b5b4012550@nxp.com> (raw)
In-Reply-To: <1190c5a2-6a89-19c5-bece-f9b04e0880b2@nxp.com>



On 3/19/2019 7:15 PM, Akhil Goyal wrote:
>
> On 3/5/2019 8:10 PM, Fan Zhang wrote:
>> This patch fixes the incorrect block size for AES-CTR in
>> legacy mode. Originally, wrong block size will cause
>> esp_inbound() drop AES-CTR encrypted packets if the payload
>> sizes not equal to multiple times of 16.
>>
>> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>>    examples/ipsec-secgw/sa.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
>> index 414fcd26c..93e3620bc 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
>>    		.keyword = "aes-128-ctr",
>>    		.algo = RTE_CRYPTO_CIPHER_AES_CTR,
>>    		.iv_len = 8,
>> -		.block_size = 16, /* XXX AESNI MB limition, should be 4 */
>> +		.block_size = 4,
>>    		.key_len = 20
>>    	},
>>    	{
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Title should be examples/ipsec-secgw:...
> Will correct it while merging
Applied to dpdk-next-crypto

Thanks.

  parent reply	other threads:[~2019-03-19 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 14:40 Fan Zhang
2019-03-06 10:08 ` Ananyev, Konstantin
2019-03-19 13:45 ` Akhil Goyal
2019-03-19 13:45   ` Akhil Goyal
2019-03-19 14:05   ` Akhil Goyal [this message]
2019-03-19 14:05     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e099920d-f423-6356-4148-85b5b4012550@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).