From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B15DEA00C5; Tue, 21 Jun 2022 14:19:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FFA740E25; Tue, 21 Jun 2022 14:19:30 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) by mails.dpdk.org (Postfix) with ESMTP id 53CAC40E25 for ; Tue, 21 Jun 2022 14:19:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qc2C99ouMgBp03VYMwBt93r2K/4/sMClpEiG2MtW2GR5uqoloRH5DgIew+ZYuT+Ct0vCU6pwB9GzN838AFeD0tqoUxqoJtByfre/sn+gVS8O4nBfMWMyh+V7NRqtld/qzAD+M6E6rebfrwoIKzjcIWEwIsCqtlm/V4FnU9TPnhAROin54NPDvvWAgr5OTn+Zc0iAfugck0zw4sLuIYjuT4uKUhCny9SIDzcmmnt4TbPFBa+mw8jyf/ubciSDl0PJCemHKeYmqGaEYINd08QpyXX/0fvfaiqMAWa4ShZ4LEboLoA29eJIZVNP9hpaIJgdyDYpUNTNjFuwkGXvELwqHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iMoj6MSzqqPh6Hv/pKDpf8YIFA96ywZWatXdQ8NW/6c=; b=kW8Zs86InoSwGnBLnpuLu45PpVQX24+50jOSZViCK8c3uTLYCnLfC6312sHaN78OsFz/cVW+JV1MCARP6QvdsKZr9Ox0yn+lYt90YIPZlAbSlyCANVTfss6H0DeyiZdl5if8F2yPXRye7ug0bw2sRn2QCGMZ4NAsQdktW7BJDiK3I4hsVJlg/JpiTpPAHsyRqcIgn9rKVYFRqzl3bCMrVhSrhH8bos0FHQW/haJw4c8NApAJPwwJdwBobPUw46XvzN1PFCBheiAM72/3KfQIb2E+LXJ5Z86R25jzQy5hHzGYJn22GTsmb0hy6vgBk8xsg6t0I1pSIzyRE3Dn9pQp0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 149.199.80.198) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=xilinx.com; dmarc=temperror action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMoj6MSzqqPh6Hv/pKDpf8YIFA96ywZWatXdQ8NW/6c=; b=tA52z/F+xWPQ8ueddA1hqGZWtEp7Xtx1Ea+KxFahkOdZFWxTTFU0U1ouj1EgJdVy4lxQPeKSv50fUihgRZ56OZ2EVVr+hyY0kNY3NcncTT5HBicgAoXBaYzhS04pzFOvdney57aFeqY8QVJonEg5RXMet3QClT4K+EnUpdheRfU= Received: from DS7P222CA0010.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::6) by IA1PR02MB9020.namprd02.prod.outlook.com (2603:10b6:208:3a8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 21 Jun 2022 12:19:26 +0000 Received: from DM3NAM02FT007.eop-nam02.prod.protection.outlook.com (2603:10b6:8:2e:cafe::61) by DS7P222CA0010.outlook.office365.com (2603:10b6:8:2e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 12:19:26 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=xilinx.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of xilinx.com: DNS Timeout) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT007.mail.protection.outlook.com (10.13.4.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 12:19:24 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 21 Jun 2022 13:19:23 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 21 Jun 2022 13:19:23 +0100 Envelope-to: jiawenwu@trustnetic.com, dev@dpdk.org Received: from [10.71.119.54] (port=14822) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3cqo-0003X1-Sd; Tue, 21 Jun 2022 13:19:23 +0100 Message-ID: Date: Tue, 21 Jun 2022 13:19:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/7] net/ngbe: support OEM subsystem vendor ID Content-Language: en-US To: Jiawen Wu , References: <20220620075512.588744-1-jiawenwu@trustnetic.com> <20220620075512.588744-3-jiawenwu@trustnetic.com> From: Ferruh Yigit In-Reply-To: <20220620075512.588744-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f63cdc1d-d283-474a-8387-08da5380479b X-MS-TrafficTypeDiagnostic: IA1PR02MB9020:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fxWWr7NhmsTmCxIUXrd950Zhf0WDvBb4voywB4HwQN8LEbsm5OHZ0Ks/YUN4iORT2QPm/u92Sy+1xYEH3bycFYxONY5wvqcGINpn8Vbu8NtTMA6Y7Gu1c6gxwAQ9/F/7BvduK8PL0CUXtyFGSNizAHJK4B3ksIHBIFLiXsr5uj9UYwXqbXjQsKMTcgXV20bGppMADFLww4ubIvIEt6g5a2XeH67RIQ82OSztZ47FQW8mEWaE9XA1EwOJsdOHcDiY6iSjM+utNiGx3qGMTeBVIa3p252JzU5PQyOJKF1bCMUcFOApIH/RruHvM09y7uNCGsGoVTRTmGl/qIpDkHtiPN0Zvte/wycLK2WKZ2Y0xK9DSffQDHly4olZTPW5uiiKpP4+dkxcvXEfyZhntMkujqU+rkN7hVFhVsK3ZO/ay/EzSnyTRBtDlNmbMLyy2+HJBqT51DUDfLgBwC3+61zrr9R1c1ntTwW6Xm/Yaxnh5ZroqoiBk3ZSmq3K2yLzMuFRpIoVMVvCuu5XC9OCckL1fJw6KabyI8rwwWs2cMHXvtBkaDb7b8RvZU8YIfOjHfnzO70PIxUng659hBaR8tZz45+a2IQc/LE/INBnYnJ+9H26mEUrohK3yeH1QAGVJzu4y+2BA9LzIE7HAvs/MWuZUokTPBgtpqnRFCSgcY90cQVVBIY6YTjacS81eZw6E8vqY6p/C5/rUGUmXigO4BB13c/5PZflM5lvngzjxr6KaFgKoGVEnDcKMdYMH9Ev8G3+WiyJ15AvZ94PjRd9Rrm6kw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(46966006)(40470700004)(36840700001)(2616005)(41300700001)(53546011)(82740400003)(47076005)(426003)(336012)(186003)(31696002)(26005)(356005)(7636003)(36860700001)(63370400001)(63350400001)(316002)(8936002)(83380400001)(478600001)(9786002)(31686004)(44832011)(82310400005)(36756003)(40480700001)(2906002)(40460700003)(8676002)(5660300002)(110136005)(70206006)(70586007)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 12:19:24.5827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f63cdc1d-d283-474a-8387-08da5380479b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT007.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/20/2022 8:55 AM, Jiawen Wu wrote: > Add support for OEM subsystem vendor ID. > > Signed-off-by: Jiawen Wu > --- > doc/guides/rel_notes/release_22_07.rst | 1 + > drivers/net/ngbe/ngbe_ethdev.c | 13 ++++++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst > index 96db85a707..b26efb8719 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -166,6 +166,7 @@ New Features > * **Updated Wangxun ngbe driver.** > > * Added support for yt8531s PHY. > + * Added support for OEM subsystem vendor ID. > > * **Updated Wangxun txgbe driver.** > > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c > index 5ac1c27a58..c4216f7e34 100644 > --- a/drivers/net/ngbe/ngbe_ethdev.c > +++ b/drivers/net/ngbe/ngbe_ethdev.c > @@ -315,6 +315,7 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > const struct rte_memzone *mz; > uint32_t ctrl_ext; > u32 led_conf = 0; > + u32 ssid = 0; Same comment with previous patch, can move the variable to the context it is used, and no need to initialize. > int err, ret; > > PMD_INIT_FUNC_TRACE(); > @@ -359,7 +360,17 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > hw->back = pci_dev; > hw->device_id = pci_dev->id.device_id; > hw->vendor_id = pci_dev->id.vendor_id; > - hw->sub_system_id = pci_dev->id.subsystem_device_id; > + if (pci_dev->id.subsystem_vendor_id == PCI_VENDOR_ID_WANGXUN) { > + hw->sub_system_id = pci_dev->id.subsystem_device_id; > + } else { > + ssid = ngbe_flash_read_dword(hw, 0xFFFDC); > + if (ssid == 0x1) { > + PMD_INIT_LOG(ERR, > + "Read of internal subsystem device id failed\n"); > + return -ENODEV; > + } > + hw->sub_system_id = (u16)ssid >> 8 | (u16)ssid << 8; > + } > ngbe_map_device_id(hw); > hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; >