From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Steve Shin (jonshin)" <jonshin@cisco.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] replay MAC address in rte_eth_dev_config_restore()
Date: Wed, 18 Jan 2017 18:39:11 +0000 [thread overview]
Message-ID: <e0ab0d0f-7620-5a7d-50bf-700525553cc2@intel.com> (raw)
In-Reply-To: <3CEF366F-80D7-49E1-838A-59D489585DC6@cisco.com>
On 1/18/2017 4:12 AM, Steve Shin (jonshin) wrote:
> Hi,
>
> I have a question on MAC address replay logic in rte_eth_dev_config_restore():
>
> lib/librte_ether/rte_ethdev.c:
> code snippet of rte_eth_dev_config_restore()
> ~~
> /* replay MAC address configuration */
> for (i = 0; i < dev_info.max_mac_addrs; i++) {
> addr = dev->data->mac_addrs[i];
>
> /* skip zero address */
> if (is_zero_ether_addr(&addr))
> continue;
>
> /* add address to the hardware */
> if (*dev->dev_ops->mac_addr_add &&
> (dev->data->mac_pool_sel[i] & (1ULL << pool)))
> (*dev->dev_ops->mac_addr_add)(dev, &addr, i, pool);
> else {
> RTE_PMD_DEBUG_TRACE("port %d: MAC address array not supported\n",
> port_id);
> /* exit the loop but not return an error */
> break;
> }
> }
>
> dev->data->mac_addrs[0] is filled with a HW MAC address (by default) when a device is initialized. But there’s no flag setting for dev->data->mac_pool_sel[0].
> As the value of “(dev->data->mac_pool_sel[i] & (1ULL << pool)) “ becomes 0 for i=0, the replay logic will be stopped without processing the rest of MAC addresses in dev->data->mac_addrs[] list.
> Shouldn’t ‘break’ statement be replaced with ‘continue’ to process other MACs in the list?
Hi Steve,
Looks like you are right. The commit that pool check added (4bdefaad) says:
"
Fix bug in rte_eth_dev_config_restore function, which will restore all
MAC address to default pool.
"
So intention looks like not stop adding mac_addr loop if mac is not in
pool, but instead not adding a mac address if it is not part of pool.
But pool check seems added later, and initial "break" is added for
"dev_ops->mac_addr_add" check.
Logic can be:
if (dev_ops->mac_addr_add)
if (mac in pool)
dev_ops->mac_addr_add()
else
continue
else
break
But of course, instead of checking the dev_ops in a loop for same
device, it makes more sense to remove it out of loop.
Are you planning to send a patch for this issue?
It is easier to discuss code based on patches..
>
> Any feedback would be appreciated.
>
> Regards,
> Steve
>
next prev parent reply other threads:[~2017-01-18 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 4:12 Steve Shin (jonshin)
2017-01-18 18:39 ` Ferruh Yigit [this message]
2017-01-18 19:10 ` Steve Shin (jonshin)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0ab0d0f-7620-5a7d-50bf-700525553cc2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jonshin@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).