DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Eli Britstein <elibr@nvidia.com>, <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Asaf Penso <asafp@nvidia.com>,
	"Slava Ovsiienko" <viacheslavo@nvidia.com>,
	Thomas Monjalon <thomas@monjalon.net>, <xiaoyun.li@intel.com>,
	<anatoly.burakov@intel.com>, <stable@dpdk.org>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix packet burst spreading stats
Date: Thu, 21 Oct 2021 13:46:18 +0100	[thread overview]
Message-ID: <e0b70f0c-e023-9bb2-93c1-5420d41b9375@intel.com> (raw)
In-Reply-To: <20211021080310.9892-1-elibr@nvidia.com>

On 10/21/2021 9:03 AM, Eli Britstein wrote:
> RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts'
> argument, which specifies the maximum number to receive/transmit.
> It can be 0..nb_pkts, meaning nb_pkts+1 options.
> Enlarge the spread stats array by one cell to fix the possible out of
> range memory access.
> 

This looks a valid problem, I guess problem is able to hide this long
because of big MAX_PKT_BURST value in testpmd.

Can you please briefly describe what 'pkt_burst_spread[]' is in the
commit log? That makes easy to understand the problem.

> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
> Reviewed-by: Matan Azrad <matan@mellanox.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

  reply	other threads:[~2021-10-21 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  8:03 Eli Britstein
2021-10-21 12:46 ` Ferruh Yigit [this message]
2021-10-21 13:20 ` [dpdk-dev] [PATCH V2 1/1] " Eli Britstein
2021-10-22  2:25   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0b70f0c-e023-9bb2-93c1-5420d41b9375@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=anatoly.burakov@intel.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=elibr@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).