From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC824A0C4B; Thu, 21 Oct 2021 14:46:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A7A74119C; Thu, 21 Oct 2021 14:46:31 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 1EBDA4118E; Thu, 21 Oct 2021 14:46:29 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="227791166" X-IronPort-AV: E=Sophos;i="5.87,169,1631602800"; d="scan'208";a="227791166" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 05:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,169,1631602800"; d="scan'208";a="719485907" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga006.fm.intel.com with ESMTP; 21 Oct 2021 05:46:28 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 05:46:28 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 21 Oct 2021 05:46:28 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 21 Oct 2021 05:46:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gfcp3QOu+MeDX+iUGV9p2JdwYrxOeSpyhzqTEb+G/19ft6Ar2sNrIp/n9GCf0o5WvxPpif9WKIX0FPxWBRVZN70mpHIxXO6nT/xOTHn2HapgLoCufWh/21pQds2UKSSJd6C60YvI1syTwKOJ+i0hHk8MpA324MIUCK80eYOVb0Y0FLy8HkXS3kutVEHDiJ5UvJsxHZv2lqHu8sVQGmAm+TosY31E+iuBgScyhTl3bJShBfm9IWMpXsOd3hLGeSmOiygQnXsMimzOJck4hk1fh88S7ezZ7CZMHV/EQyM1k6kvTCPstxTNDYTanUgAqYo8g0Sw6XCsD3GC3BLXcn6X4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0CwT2jS78GHzROg9WryURtHins4rhwjFcKUot2efnK8=; b=Z2acfPdE6Bv47dG+aXpOi2Ep8DgvBgwEzufdSPAcmr02FM/HaaOsqWHVQGZFntdYrxtMTizrupdXjw6dVlhpdFUpq5kyxUcnYq7sJGzJ7IsNeVl7e7Q37UiHPa3/HoLW+pK3qlY3BMlputda9JCZXdg8GkKI2/M+W85Q90Xz2ugJCHjmvrGCwuDGqg1566sUrmgKTrqY7aUH/CNniidvdUYWVHxtZc80T9VYjW3/MwSVwYTlEL1vw3FyUUw5oBDbReSIDDe5B/vHowDDkDz0hJ/FH0ulD0ogp1uUq/oZj7sjb3BxDJy+6GD55fX+w+JEMF9I4jCYvjEYG5p6GmNYjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0CwT2jS78GHzROg9WryURtHins4rhwjFcKUot2efnK8=; b=RVArMTCVQWYdbHCI90bHYapYZ86OD8iHm5F70UpFDJARl/ixUy8bb++TzIrnuEjIT4FeXSH0mCbZDmPVbZ7u0f2HFkp7p9MghZuMADBV7JHgIYzkS7/6KBBO9hmSQQVq7R/k9O6WY+a6Moj/s+jAbJYrtJJXO554jypTJ0WQrSI= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4904.namprd11.prod.outlook.com (2603:10b6:510:40::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Thu, 21 Oct 2021 12:46:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021 12:46:26 +0000 Message-ID: Date: Thu, 21 Oct 2021 13:46:18 +0100 Content-Language: en-US To: Eli Britstein , CC: Matan Azrad , Asaf Penso , "Slava Ovsiienko" , Thomas Monjalon , , , , Honnappa Nagarahalli References: <20211021080310.9892-1-elibr@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021080310.9892-1-elibr@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:6:2d::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:6:2d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.8 via Frontend Transport; Thu, 21 Oct 2021 12:46:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa627ecc-365f-45c0-212f-08d99490cb80 X-MS-TrafficTypeDiagnostic: PH0PR11MB4904: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DjBIpCYeWNfPStI31HT7FjHOKJm7ynJrTw/tfxPAeDm+0vPw5UqZxZXcuNQvmc5rFJP6G2A/hrHYLhQ5+VC+aby33gHJQWwUGWqrb+/mBo5nZRWL2cty28UYXcVVehKg16P5NLajeXGN0+OU2TNHqgjkb5+gAuXZ5AsT1o+dif3CagEPvrnIHNOoD6ZyC9KK23hmyIZHAym0saoCOH4lSrJdarxY0IP2sUGJDE8HEQ2M41desepJUscqo4hrsBG1e17Rf4Q5OcmylfKu7K9Nf5baP4fCKACKVDARQ49BGJ8wBI3NS7vMNl9h0TRNMCgENDAZ7G3yQJHuG2h+BD4kr5ZjeSmu9YTjbnEd+n2ND/S9mOUdytsNKQ40ce4xTSQvMEXcy+4dgNU8LCERG4yEsjBVZnb7gnNZTPcaPzwH5pggHmfvOIIiv8HXJ1hDbWSisIDeuv5gO8fBBcWp+px3VqBVy5RGgvbB0LS+Cj1oqgRUXvU0mZ6oYs/xaOPGEqXKSjAmv0pFK23YicR+L+SLn7DpxPhAglI8QQoHIEnFce3yiNxjBnX5X2Y3kymR3MFD4qXXpZJoPHYdMUbOEl15bMLuoG0sNPhJb9pa02Vvaed7Q8YfJH6hwyMJctyiYX5mQp6CQeExOn5fEmfDolrsMWX/R0JKBmWS2d6RVsFWVkirxlZGxpVH9eF0PXR1B5fka5Qi3FjK/6OqKONtYWZXcg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(54906003)(53546011)(16576012)(26005)(6486002)(66946007)(66476007)(8936002)(36756003)(956004)(6666004)(8676002)(186003)(5660300002)(31696002)(31686004)(44832011)(82960400001)(2906002)(2616005)(83380400001)(38100700002)(508600001)(4326008)(316002)(86362001)(4744005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2ZUMDVTY3U0emFVc3pxNUR6aVUyU2dtcFVxUzhDKy9pYzBrM05hd0t4YUlN?= =?utf-8?B?SjRZTitwYVFIUEg2Umt3N0xtSlBGdWlxVVM3Z3hhbUdLQk9uZk1oKzAxeVNB?= =?utf-8?B?SlhsVlBwUjNVZ1BCWDFGOWhoVDZEMWNIRjhvRHFkRmVEQXJXMVJLQmNqQi9v?= =?utf-8?B?OXhOUjJqS3JVZ1NHc1RLeW1JQ2lZQVBqUmZGSWpyeWJDNjRteG94WTQrNWlY?= =?utf-8?B?d0RFekRiaGJ3cVdTWXNjbHJ2bHdEYlA3SEN0c2dRdEJtNkVIZXpla2FXWVpL?= =?utf-8?B?dkNVR2lsdGYzQitRUWdwYUhxYzlpalNYRTNKalQ1UVVQYkNzTC9PZWJ0bDRu?= =?utf-8?B?dW9LaHB1YmRVRWdWeWtVcEozbm5jUUtoK3F5TVZrdHlxZFhSU1c5RzFxTjVo?= =?utf-8?B?c0JXUHBqbmJ6aTR3NWVNTTZKcFFZM2NmV29La0VaeG80U01sNzd0YWFrKzN0?= =?utf-8?B?NWY5VHRSUkNQbU15QmdKNDBlbENuY0pSc3Nub21WQVNNMnMyT3Jlb3hyeFBR?= =?utf-8?B?ZW1jYitMalQwVWhFdENlUDVIQzdDZklKZ1hzanMxdkplNThvdTd2RUoydGdI?= =?utf-8?B?bk8xb1hoY0JNd00vRzhua0toSEJyZ0YzY3NFTEE4MzdxK2ovdk9Od2Q3UTN4?= =?utf-8?B?dFhPSnExNlNhUDVGd2tzaGx4aS9PdlF5ZjVhSmRXUDlJNHVSRzRaeWZoRVVW?= =?utf-8?B?bjFQZWM2U2xqRHNqd3g2VjN6a0lEVURrd2JCOHdRM0kyTU9MMmpXUEtIVkl5?= =?utf-8?B?d01uTjdWOWhqczJDUzEveUlVOUJwT3dJQWlaV3RuYzEyVHVmenJJdFdYMWRU?= =?utf-8?B?a1hncE5FMnBydTR1UmVNdDBjL0tjQTFJbk8vUDFqWmRKNlp1YnplQURZRVdu?= =?utf-8?B?TkJCR2x0enFOeFoxOWt4RzdMaW0wSGVMSnNsdUJLczl3TzBMVmNraUpBYzY5?= =?utf-8?B?dUllbis1ZjVkNUpMRzk3U2paQmlhSWtIV3A1cWdnQTRUTHBRQjZzaXFuQ3RE?= =?utf-8?B?ZVhXNFhuSjBNNHF3dGZvcERXdUxKYytFMmVXaldJUHJ1Z0V1dkNPMHRYRnZ5?= =?utf-8?B?ZnR3MUlGMUFUNW03Y3ZUbm9XNDFmRElNelJvMUNMc0k0cCtvYUZWTFhjd3Vs?= =?utf-8?B?dUZsakFSUUJuVnlpdFR4cFplaTVJN0ppTTcvZzM0cXBiUE1ReUVFS05xdDFx?= =?utf-8?B?R3NueUFBTG5Ud3dCcnF2a3c5L2Z1MGgvbHhTVFZDZmw3Sm9sbUE3OW5xdk5z?= =?utf-8?B?dE13cURKSjJ0RG8xQjRGMTAxWlJ4QmRaM3J1RVJmMGhrVmQ5UzVSL0hwQ0Ft?= =?utf-8?B?L3B0eEphUklXTVFkd2ZnaUhEeFRjNHVWYmJnVlE2U3QxalJEUy9aUjV2QUhj?= =?utf-8?B?dkZEUFZZMGpKRU5taURUY2xISVcrbTk3NTZZREU0S0Z1cXc4eUMrSUxZT0xS?= =?utf-8?B?Vzc0bGs2MkZ2VWFWZEdaM3BOSkNacEVxNFBIRmlHdUtMZEt6QllyVy9HQVh2?= =?utf-8?B?T0liKzZMV3BkVFhGalVlOHptUG1SVEZQTHorQzVZRmt5RXBablVoa3k1QlJq?= =?utf-8?B?R0lGM3VsM09qQnUvdE94QjlPQlhQZjFZMTh2S2NLeDF4SUMyVVJzNkFLYUdh?= =?utf-8?B?a3d5MzRqUjhzQmJvd1RvUWc4VzZUVTQ0ODE4RitmeHBrWlhFOCsyeXROK28w?= =?utf-8?B?S3JqQVJyc1lLZDM4SmJLemFGOUhocjF4NmU4bWY5b3h6NGZscUpWOEZqRlo5?= =?utf-8?B?ZTNEWXZoS0ZuaFd2M210RWRHR09mdjlXQVp5bFVjbmJ6a1E0Y2kyakROTUZY?= =?utf-8?B?QzNTMFdPL2ZEaHJud0ZUeE5naGc3Y3VvRjVvNUtVVmlXanpQMkN3MUpubjZo?= =?utf-8?B?ZHBFVnVWWDhKcFdpdFFiSWtOd1VkN1lNcjBoSTJHeW9CQm9YMWNwNUF3MVJk?= =?utf-8?Q?9+TYQ8oEMlVECLn5RVCujZDZbZkVi1VI?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa627ecc-365f-45c0-212f-08d99490cb80 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 12:46:26.6172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4904 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix packet burst spreading stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 9:03 AM, Eli Britstein wrote: > RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' > argument, which specifies the maximum number to receive/transmit. > It can be 0..nb_pkts, meaning nb_pkts+1 options. > Enlarge the spread stats array by one cell to fix the possible out of > range memory access. > This looks a valid problem, I guess problem is able to hide this long because of big MAX_PKT_BURST value in testpmd. Can you please briefly describe what 'pkt_burst_spread[]' is in the commit log? That makes easy to understand the problem. > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Eli Britstein > Reviewed-by: Matan Azrad Acked-by: Ferruh Yigit