DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Varghese, Vipin" <vipin.varghese@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation
Date: Fri, 25 May 2018 10:12:00 +0100	[thread overview]
Message-ID: <e0dd6692-34eb-a365-fb9c-cdb29f76d05e@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611531B8653@SHSMSX103.ccr.corp.intel.com>

On 5/25/2018 10:08 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Friday, May 25, 2018 4:35 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Thomas Monjalon
>> <thomas@monjalon.net>; Varghese, Vipin <vipin.varghese@intel.com>
>> Cc: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; Jain,
>> Deepak K <deepak.k.jain@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional
>> limitation
>>
>> On 5/25/2018 1:44 AM, Zhang, Qi Z wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>>>> Sent: Friday, May 25, 2018 1:06 AM
>>>> To: Varghese, Vipin <vipin.varghese@intel.com>
>>>> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Kovacevic,
>>>> Marko <marko.kovacevic@intel.com>; Jain, Deepak K
>>>> <deepak.k.jain@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
>>>> Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for
>>>> functional limitation
>>>>
>>>> 23/05/2018 12:05, Vipin Varghese:
>>>>> --- a/lib/librte_ethdev/rte_ethdev.h
>>>>> +++ b/lib/librte_ethdev/rte_ethdev.h
>>>>> @@ -1479,6 +1479,9 @@ int rte_eth_dev_attach(const char *devargs,
>>>> uint16_t *port_id);
>>>>>   * This function must be called when the device is in the
>>>>>   * closed state.
>>>>>   *
>>>>> + * Note:
>>>>> + * - Currently supported for primary process only.
>>>>
>>>> I think it should be possible to attach a device in secondary process.
>>>> If it is a recent limitation, it should be in "known issues" of the release
>> notes.
>>>
>>> For PCI device, we can only attached a device that is already resource
>>> mapped in primary process (for example, a device not in secondary process'
>> white list but in primary process's) And we should not detached a device in
>> secondary process, that will mess primary process and cause it can't be
>> attached again.
>>>
>>> For vdev, I think we still can attached/detach a new device which does not
>> exist in primary process.
>>
>> For vdev it was possible to attach a new device in secondary, but it seems
>> primary process checks has been added to virtual PMDs probe() function by [1]
>> which seems breaking this capability, can you please check it?
> 
> Yes, attach vdev "net_af_packet,iface=eth0" on secondary process will create a private device.

Yep, Qi kindly explained me that it is still possible create vdevs using
rte_eth_dev_attach() on secondary process.

So this patch is not exactly correct.

>>
>>
>> [1]
>> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")
>>
>>>
>>>>
>>>>
>>>
> 

      reply	other threads:[~2018-05-25  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 10:05 Vipin Varghese
2018-05-24 17:06 ` Thomas Monjalon
2018-05-25  0:44   ` Zhang, Qi Z
2018-05-25  8:34     ` Ferruh Yigit
2018-05-25  9:08       ` Zhang, Qi Z
2018-05-25  9:12         ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0dd6692-34eb-a365-fb9c-cdb29f76d05e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).