From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Jeff Guo <jia.guo@intel.com>, <stephen@networkplumber.org>,
<bruce.richardson@intel.com>, <ferruh.yigit@intel.com>,
<konstantin.ananyev@intel.com>, <gaetan.rivet@6wind.com>,
<jingjing.wu@intel.com>, <thomas@monjalon.net>,
<motih@mellanox.com>, <matan@mellanox.com>,
<harry.van.haaren@intel.com>, <qi.z.zhang@intel.com>,
<shaopeng.he@intel.com>, <bernard.iremonger@intel.com>
Cc: <jblunck@infradead.org>, <shreyansh.jain@nxp.com>, <dev@dpdk.org>,
<helin.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: Add API to enable device event handler
Date: Wed, 11 Jul 2018 11:49:30 +0300 [thread overview]
Message-ID: <e0e453d8-d0c3-a3de-1544-8f9bfab9440c@solarflare.com> (raw)
In-Reply-To: <1531227098-29564-2-git-send-email-jia.guo@intel.com>
On 10.07.2018 15:51, Jeff Guo wrote:
> Implement a couple of eal device event handler install/uninstall APIs
> in ethdev, it could let PMDs have chance to manage the eal device event,
> such as register device event callback, then monitor and process the
> hotplug event.
I think it is moving in right direction, but my problem with the patch is
that I don't understand what prevents us to make it even more generic.
Right now it looks like that PCI driver flag RTE_PCI_DRV_INTR_RMV is
sufficient and everything else could be done on ethdev layer.
RTE_PCI_DRV_INTR_RMV is mapped to RTE_ETH_DEV_INTR_RMV eth
device flag. The flag may be used as an indication in rte_eth_dev_create()
to register the callback.
May be I'm completely wrong above, but if so, I'd like to understand why
and prefer to see explanations in the patch description.
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> v4->v3:
> change to use eal device event handler install api
> ---
> doc/guides/rel_notes/release_18_08.rst | 12 +++++++
> lib/librte_ethdev/rte_ethdev.c | 59 ++++++++++++++++++++++++++++++++++
> lib/librte_ethdev/rte_ethdev_driver.h | 32 ++++++++++++++++++
> 3 files changed, 103 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst
> index bc01242..b6482ce 100644
> --- a/doc/guides/rel_notes/release_18_08.rst
> +++ b/doc/guides/rel_notes/release_18_08.rst
> @@ -46,6 +46,18 @@ New Features
> Flow API support has been added to CXGBE Poll Mode Driver to offload
> flows to Chelsio T5/T6 NICs.
>
> +* **Added eal device event process helper in ethdev.**
> +
> + Implement a couple of eal device event handler install/uninstall APIs in
> + ethdev, these helper could let PMDs have chance to manage the eal device
> + event, such as register device event callback, then monitor and process
> + hotplug event.
> +
> + * ``rte_eth_dev_event_handler_install`` for PMDs use to install the device
> + event handler.
> + * ``rte_eth_dev_event_handler_uninstall`` for PMDs use to uninstall the device
> + event handler.
> +
>
> API Changes
> -----------
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index a9977df..09ea02d 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -4518,6 +4518,65 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da)
> return result;
> }
>
> +static void __rte_experimental
> +eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,
> + void *arg)
> +{
> + struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)arg;
> +
> + switch (type) {
> + case RTE_DEV_EVENT_REMOVE:
> + ethdev_log(INFO, "The device: %s has been removed!\n",
Colon after 'device' above looks strange for me. I'd suggest to remove it.
If so, similar below for ADD.
> + device_name);
> +
> + if (!device_name || !eth_dev)
> + return;
> +
> + if (!(eth_dev->data->dev_flags & RTE_ETH_EVENT_INTR_RMV))
It looks like a typo above. Shouldn't it be RTE_ETH_DEV_INTR_RMV?
> + return;
> +
> + if (!strcmp(device_name, eth_dev->device->name))
> + _rte_eth_dev_callback_process(eth_dev,
> + RTE_ETH_EVENT_INTR_RMV,
> + NULL);
> + break;
> + case RTE_DEV_EVENT_ADD:
> + ethdev_log(INFO, "The device: %s has been added!\n",
> + device_name);
> + break;
> + default:
> + break;
> + }
> +}
> +
> +int __rte_experimental
> +rte_eth_dev_event_handler_install(struct rte_eth_dev *eth_dev)
> +{
> + int result = 0;
> +
> + result = rte_dev_event_callback_register(eth_dev->device->name,
> + eth_dev_event_callback, eth_dev);
> + if (result)
> + RTE_LOG(ERR, EAL, "device event callback register failed for "
> + "device:%s!\n", eth_dev->device->name);
Why ethdev_log() is used above, but here is RTE_LOG with EAL?
Similar question below.
> +
> + return result;
> +}
> +
> +int __rte_experimental
> +rte_eth_dev_event_handler_uninstall(struct rte_eth_dev *eth_dev)
> +{
> + int result = 0;
> +
> + result = rte_dev_event_callback_unregister(eth_dev->device->name,
> + eth_dev_event_callback, eth_dev);
> + if (result)
> + RTE_LOG(ERR, EAL, "device event callback unregister failed for"
> + " device:%s!\n", eth_dev->device->name);
> +
> + return result;
> +}
> +
> RTE_INIT(ethdev_init_log);
> static void
> ethdev_init_log(void)
<...>
next prev parent reply other threads:[~2018-07-11 8:49 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 10:39 [dpdk-dev] [PATCH 0/2] Enable eal event hotplug for i40e Jeff Guo
2018-07-05 10:39 ` [dpdk-dev] [PATCH 1/2] net/i40e: enable hotplug in i40e Jeff Guo
2018-07-05 10:39 ` [dpdk-dev] [PATCH 2/2] testpmd: remove the dev event callback register Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 0/3] Enable eal hotplug event detect for i40e/ixgbe Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe Jeff Guo
2018-07-09 7:38 ` Lu, Wenzhuo
2018-07-09 7:51 ` Matan Azrad
2018-07-09 8:57 ` Jeff Guo
2018-07-09 9:04 ` Matan Azrad
2018-07-09 9:54 ` Jeff Guo
2018-07-09 10:01 ` Matan Azrad
2018-07-09 10:14 ` Jeff Guo
2018-07-09 8:13 ` Andrew Rybchenko
2018-07-09 8:46 ` Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 2/3] net/i40e: enable hotplug detect in i40e Jeff Guo
2018-07-09 7:47 ` Matan Azrad
2018-07-09 8:54 ` Jeff Guo
2018-07-09 6:56 ` [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register Jeff Guo
2018-07-09 7:39 ` Lu, Wenzhuo
2018-07-09 8:16 ` Andrew Rybchenko
2018-07-09 8:23 ` Jeff Guo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 0/4] Enable eal hotplug event detect for i40e/ixgbe Jeff Guo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 1/4] ethdev: Add eal device event callback Jeff Guo
2018-07-09 13:14 ` Andrew Rybchenko
2018-07-10 7:06 ` Jeff Guo
2018-07-10 9:10 ` Zhang, Qi Z
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 2/4] net/ixgbe: enable hotplug detect in ixgbe Jeff Guo
2018-07-10 8:19 ` Lu, Wenzhuo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 3/4] net/i40e: enable hotplug detect in i40e Jeff Guo
2018-07-09 11:46 ` [dpdk-dev] [PATCH v3 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 0/4] Enable eal hotplug event handler in ethdev Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 1/4] ethdev: Add API to enable device event handler Jeff Guo
2018-07-10 13:24 ` Zhang, Qi Z
2018-07-11 8:49 ` Andrew Rybchenko [this message]
2018-07-11 11:17 ` Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-10 13:26 ` Zhang, Qi Z
2018-07-10 12:51 ` [dpdk-dev] [PATCH v4 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 0/4] Install eal hotplug event handler in i40e/ixgbe Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 1/4] ethdev: Add eal device event callback Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-08-24 16:22 ` Ferruh Yigit
2018-09-12 8:47 ` Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-11 11:51 ` [dpdk-dev] [PATCH v5 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 0/4] Install eal hotplug event handler in i40e/ixgbe Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 1/4] ethdev: Add eal device event handler APIs Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-07-11 11:58 ` [dpdk-dev] [PATCH v5 4/4] testpmd: remove the dev event callback register Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 0/4] Install eal event handler in i40e/ixgbe Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 1/4] ethdev: Add eal device event callback Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 3/4] net/i40e: install hotplug handler in i40e Jeff Guo
2018-08-17 10:50 ` [dpdk-dev] [PATCH v6 4/4] testpmd: remove the dev event callback register Jeff Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e453d8-d0c3-a3de-1544-8f9bfab9440c@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=helin.zhang@intel.com \
--cc=jblunck@infradead.org \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=motih@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=shaopeng.he@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).