From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 256EFA0C41; Tue, 7 Sep 2021 12:02:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1C79410ED; Tue, 7 Sep 2021 12:02:02 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1BEC5410EC for ; Tue, 7 Sep 2021 12:02:00 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10099"; a="207379515" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="207379515" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 03:01:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="694929241" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 07 Sep 2021 03:01:59 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 03:01:58 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 03:01:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 03:01:58 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 7 Sep 2021 03:01:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NaU6/UWnxAzBeKT1tW8soRqXfVLyvdWO2oU/2qoB4IRP39QsOtyL5Jiv1txaddoiid7sIxDnDBgGQl3m/gzYHhjaqcPpgW7zCuLl8eqggcTSwTXN7HMVz+T6yX0qxDKts702AWenlfu+L8dgervgOEq+8diUcukV1kihtBXH7hfzemTpSC3MR00BSP8wMlgAlYu+8iTkpC9ig0kyfRLR3GBNlaOqsU5xIzKhklu3q8E0BmaGnSQQgTrl1c9kSO920d4Q7LN0l2D8AgSSbvMPGGesKYMGJZ7vrk7kDLyQ3oOHcRpd+7yZNPQn8Ci7Ev6XYyRIWtj60mrotEQFa8UV8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w8pFBAdY/PLbq4wh6LwfPHna+aW55pkVNdmK+aPWfxM=; b=FbgCDYewGRST48c0DDvARL4BPoVATILUy/XjT7AVEnPjU1vHwXRov1uWq5SDUMSxFjXGV4KN9z+azazVL/zgFrtSbnKXyv57WiuImOSqM+0/VdQoDJyyUFXUK2Z3XBXDPapvr+GxgtOGRyN5gugH3jUglgsLjJPYZYhanFVHkbFA/0BmjbrqqEsvVCouindtoB5bKKMV0LwJTUqz89/olISvU8w9FKknGGL8krYclWs4k+CmyoNmeomIJNUw+Tbzjxn9zeK09G6fj/y7jwmQfiQzMn/2t7lDvP1hqd9MGZNKdAqBekvOlq2GiVAHcNK0osSofeH/kHOdHTcdjVX+xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w8pFBAdY/PLbq4wh6LwfPHna+aW55pkVNdmK+aPWfxM=; b=RbmsiKdpq9aoo+RWuPWlU/ToH880PRa4IiWf4rOtGTqOvZiIeHMJNocEja7K1nCmFiJcOBCi7G6gV77jpyJQFOHhcInxyDIfZ6zvnxkCQEdNFYCI9SZpq9R2AIk5LwEKEVHTqCS5GLOTDkWCYW+ZdfsKHo8RXgzVIyUBtQJv1Sw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB4879.namprd11.prod.outlook.com (2603:10b6:a03:2da::8) by SJ0PR11MB4909.namprd11.prod.outlook.com (2603:10b6:a03:2af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Tue, 7 Sep 2021 10:01:54 +0000 Received: from SJ0PR11MB4879.namprd11.prod.outlook.com ([fe80::4d2f:6c7:757c:8e93]) by SJ0PR11MB4879.namprd11.prod.outlook.com ([fe80::4d2f:6c7:757c:8e93%4]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 10:01:54 +0000 To: "Power, Ciara" CC: "dev@dpdk.org" , "Doherty, Declan" , "Richardson, Bruce" References: <20210903105725.243477-1-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: Date: Tue, 7 Sep 2021 11:01:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::12) To SJ0PR11MB4879.namprd11.prod.outlook.com (2603:10b6:a03:2da::8) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 10:01:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f598cf15-6182-4fc9-dfcf-08d971e68551 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4909: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /RS/gqD9YItNGTfSHSGmq8DnuWzK7BcIviYFZma9euvDkVjrE8J/YO4f6+i9vWLJooTvRRMf9VsxGqY0bqd/i/QR6nBKTYth+zgvCiL+dIOsIqWfldxL4PIDX1bmTYXwNIRpzXKsVdgH+xX5KBWW++mEke4ocfCT6lsJpWbuw9OkYkI0aSqOCbkiK+5zk1GU2WeECBN9SA2hZr90tQPinDXv0qQDqH6vmhsfGYWoODt7BZABbYhYtMg8aYLesyBtlm5qaWiPeuQd4S81qY/wZ+U3n0OTi4CsIU/nYD4/poUlagtTfUKrd3Dxl8xgLLhbXbRAZt9nNKUhZXb1T+E3zcmJqvAFiOWvcH5Zyj2EUy3KvtW04sX4RWtqoTssEMmAQh5uB4MQcSyq811zr7qJZMvL/YbDIqdvwPT6Rn7F8TuYIp0dkTtE6RKyGUad7tVA6BzWxZBy+HAZKk21yAnvzGerokZdvPJxLTkfhQKEi7G/hCOG+f/gzgrmGzNb1h0up8JUgae4d2yVVzOli0wmmiLk8Rd5GIsC2aMddMQAQnzdbW1RMQ9j+f3GDuY8BvCYFgCgMK1TLWRAZJ6mZ+KBehat7BRmTpTh9yKgOCosocXMlF2LvZ7vZ0VoTKgu5h3wcQ3K10QzCajesh8X9SZY2gxRRX7jXQZxX9pzaBtnqTNGcD7vWdLwxCXfbKyI0PCw8gwowJEb47BbBo1R6jR8mAvneKhEbK3euKS8lASXxeGW+aTES4cV2rUWwpw/nEnr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB4879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(16576012)(6666004)(54906003)(316002)(55236004)(66476007)(38100700002)(4744005)(31686004)(66556008)(37006003)(107886003)(36756003)(8936002)(5660300002)(53546011)(26005)(83380400001)(8676002)(6486002)(956004)(6636002)(2616005)(66946007)(31696002)(6862004)(4326008)(2906002)(186003)(508600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0RHVlVJcGJlOFZUbFhFTlA4Tlhoc3lNSEpxUjJ4OUt2TFRVT1RlSFBSNFVj?= =?utf-8?B?Sm5ieU1Qd3ZZbm40OXp3M0xIcGpPcHJwaWRSWEtzVi9IVEpsWkVtTEhhVElN?= =?utf-8?B?SzBBRVBCQkcrWUExd3R0emh2V0xGMGxXdllzajdpZGRtWUJobnU4YzBxNWta?= =?utf-8?B?NUMvRGVEUzg1OGU1UmxVb1hzV091QmJKelBMbVFWaTd2MXh6OEhhSkxUTjg5?= =?utf-8?B?RWhKdGNUZ283eEd1VEJFTUJ5VHlnM2NxcU5DcVJIdU42bGJoYnBrMWVOdU9D?= =?utf-8?B?YUJqcFRybWJkc1lrdjFiY3QzOWo3L0xjdzFDZWZQQ3VBSnNkQTNnMXduTXUv?= =?utf-8?B?RnFzeFlLNTRTWG1XSVNFZEdXK01RVG9IMnJ1cDVLU1M0Y3pXc2hPMzl2YmNn?= =?utf-8?B?VHFOVEx5cWJia3lLb2p2UXhBOHNNajVvYXlKZlVZQVFHeExvbGN5S0wyMS9q?= =?utf-8?B?TDhVdlhYWFRkSEU5Wk53ZkVPMGFPYjZ0K3V1TDNiWUEzT3dBTnUwcVlvRlo3?= =?utf-8?B?dWFYYmhzeDRTd0pXbU1zdG90QWRCQW0wOVRQQytkbm5rekgvMVlrb1kwRnVU?= =?utf-8?B?RndBQ3k4SnRVSDF3d2NmV3J0RFFVdXgvbW4vZENtdklxK2NTQmNsYmdhU1Nl?= =?utf-8?B?YmR5aUVRMjNOMGt4K1grdzJmdEF6V3cwK3dCS1B1L2l5L2FMeTEzY1lnYVVN?= =?utf-8?B?b0pxMEtEWVNZU2ZBUzVYbW5INnhRWlUrOUt3OEp3aWpiQ2dhKzEwdHhWVzVT?= =?utf-8?B?Y0RJY0Rrb3VPYXVRRDRWZ1haUW5QZmJDY2E1cmNkRVZIVWk3YVc3WmdadXN3?= =?utf-8?B?aC83dzU0NlJtWEMyVmI5WXJ5UGNIanM2UURLKzd4K3FsdEdEb0QzM3ZxZkcy?= =?utf-8?B?elhTY3gvbHVlNEpjQ3JyR0J4MUlCdm5vV0Q0OElvaWhsNG13Nno4VVJTaG9t?= =?utf-8?B?KzVoWDNndEJ0SUpqNlNBS2ZZemVTODhYVU1xUnBSdExPdytxMmhhNmM0Vkph?= =?utf-8?B?ZlM1d1I5QXpvY0xPMUtQVXROMlJJcjZnUFk3L3lSOGF1RG1xZ0dkVHVXbXB3?= =?utf-8?B?a1hPbjFZUGtQenRoMzdyVHBCMXRwY21ZVGxzQkl5Z1RZQTZNQmt4cDJQRVhF?= =?utf-8?B?c3I5MTJhWTlaQ01WZXJUdzQ3L21tVHdIa2tiUTRYR0NCU0l3YWJkVUZLTENS?= =?utf-8?B?WUFsd2JETWNNTEcxMkhWNnNtaEJUZFZ3OEdiYm1LTlQ2cTR1TG9UZ2h0ZHlS?= =?utf-8?B?d3Q0b2gwZzNyME90MGlZRDVzb3I4NTdQQnd6QXJIWTlHZW55UDl1SEM2V2RC?= =?utf-8?B?SDc4NVB4VWJjaUIvVWkxQ0xVUm5ZeE1FRjMyRGw2RGxwTDB2OXVuMjlISTVv?= =?utf-8?B?cXBYcDRINHBjKzVLVzk4aUVaZ0phS2R6VlF2M0hzay95Ynl2aVZ1S1hRUWox?= =?utf-8?B?RjVzZExOaHcwb1NlbnYxY0VPakdvMmRDTThuczRsT2tib0xQMVNNWlFpc2t0?= =?utf-8?B?VHVmNFdFcWdmeXhocTZoYzdqQktDbUh3UHI0MjJweGV4VWJhZkhyZmREWUUv?= =?utf-8?B?aVNlZE9pcVJrN3NvRkc2OXI5d3NGaGtpd295d1l3VmFrSklyVGhJMFFWdzJN?= =?utf-8?B?d1BpL2NqOUlxRUlNZU0xb3orbk1rdHZDdk9RZXljVTRsZGQzUTdhbGpodUcw?= =?utf-8?B?ek5wYThpZitBc2pITGp1VjRhalp4d09lSThEdDZrME5vakxyc2N3c3QwcUh3?= =?utf-8?Q?qAzs1QrjSyausvcGK37jvOLqrsty7Nt46tfHaIL?= X-MS-Exchange-CrossTenant-Network-Message-Id: f598cf15-6182-4fc9-dfcf-08d971e68551 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:01:54.5625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1kK30vs6hFHgyRpeKU3B0v1WCGZGp7ZfHKqCq+1/Xzv9M15AEAIqTCpzF5gtEIhS9WMQgnwJZ5iMbmEQ4BFyMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4909 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] telemetry: add support for dicts of dicts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/2021 5:25 PM, Power, Ciara wrote: > Hi Radu, > > >> -----Original Message----- >> From: Nicolau, Radu >> Sent: Friday 3 September 2021 11:57 >> To: Power, Ciara >> Cc: dev@dpdk.org; Nicolau, Radu ; Doherty, Declan >> >> Subject: [PATCH] telemetry: add support for dicts of dicts >> >> Add support for dicts of dicts to telemetry library. >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> --- >> 5.1 > > Thanks for this, it will be a good addition to Telemetry. > > I think tests should be added with this feature. > Different combinations of data are tested in the test_telemetry_data.c file, tests for these nested dicts would be valuable there. > > Thanks, > Ciara Hi Ciara, thanks for reviewing, I will add the tests.